[COMMITTERS] pgsql: Fix documentation of FmgrInfo.fn_nargs.

Fix documentation of FmgrInfo.fn_nargs. Some ancient comments claimed that fn_nargs could be -1 to indicate a variable number of input arguments; but this was never implemented, and is at variance with what we ultimately did with "variadic" functions. Update the comments. Branch -- master De

[COMMITTERS] pgsql: Fix broken logic in logical_heap_rewrite_flush_mappings().

Fix broken logic in logical_heap_rewrite_flush_mappings(). It's blatantly obvious that commit 4d0d607a454ee832574afd52a3c515099cc85eb3 wasn't tested. The leak's real enough, though. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c6a4ace5bf839b2480e8bb4c36bd3ec850c5

Re: [COMMITTERS] pgsql: release memory used while flushing logical mappings

On Tue, Apr 22, 2014 at 10:16:29PM -0400, Bruce Momjian wrote: > On Tue, Apr 22, 2014 at 10:09:33PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > release memory used while flushing logical mappings > > > > I imagine this patch is the reason why half the buildfarm is red. > > I am able t

[COMMITTERS] pgsql: revert 4d0d607a454ee832574afd52a3c515099cc85eb3

revert 4d0d607a454ee832574afd52a3c515099cc85eb3 Revert due to contrib/test_decoding regression failure Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cee850c403c9dde121dde042334554167f79d989 Modified Files -- src/backend/access/heap/rewriteheap.c |3

Re: [COMMITTERS] pgsql: release memory used while flushing logical mappings

On Tue, Apr 22, 2014 at 10:09:33PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > release memory used while flushing logical mappings > > I imagine this patch is the reason why half the buildfarm is red. I am able to reproduce the failure; it is in that pesky contrib/test_decoding test. Ch

Re: [COMMITTERS] pgsql: release memory used while flushing logical mappings

Bruce Momjian writes: > release memory used while flushing logical mappings I imagine this patch is the reason why half the buildfarm is red. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscript

[COMMITTERS] pgsql: doc: adjust 9970443640b4569cf72b3c8e84abe80bdf533c7f for "null

doc: adjust 9970443640b4569cf72b3c8e84abe80bdf533c7f for "null string" Report by Andrew Dunstan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2362c2bd234f01935336208fe2924c986564baa9 Modified Files -- doc/src/sgml/ref/copy.sgml |2 +- 1 file change

Re: [COMMITTERS] pgsql: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f12

On Tue, Apr 22, 2014 at 07:55:56PM -0400, Andrew Dunstan wrote: > > > > > On 04/22/2014 07:16 PM, Bruce Momjian wrote: > >doc: improve wording of COPY commit 7ec73783d88a743799b0c262f1235f772497fb1d > > > > > This isn't an improvement: it's made it incorrect. The null string > is not necessa

Re: [COMMITTERS] pgsql: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f12

On 04/22/2014 07:16 PM, Bruce Momjian wrote: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f1235f772497fb1d This isn't an improvement: it's made it incorrect. The null string is not necessarily empty, it is only empty by default. People keep making this mistake (and indee

[COMMITTERS] pgsql: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f12

doc: improve wording of COPY commit 7ec73783d88a743799b0c262f1235f772497fb1d Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9970443640b4569cf72b3c8e84abe80bdf533c7f Modified Files -- doc/src/sgml/ref/copy.sgml |5 ++--- 1 file changed, 2 insertions(+

[COMMITTERS] pgsql: doc: mention CREATE MATERIALIZED VIEW AS can be EXPLAINed

doc: mention CREATE MATERIALIZED VIEW AS can be EXPLAINed Patch by Amit Langote Report by Backpatch through Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8506a607a3b261576240d09f1ed4abfb2dba1635 Modified Files -- doc/src/sgml/ref/explain.sgml |5

[COMMITTERS] pgsql: docs: add results for JSON operator examples

docs: add results for JSON operator examples Patch by Sehrope Sarkuni Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/26cd1d7d9513b2b490efc746551ec5a786b56212 Modified Files -- doc/src/sgml/func.sgml | 15 +++ 1 file changed, 11 insertions(

[COMMITTERS] pgsql: build: add EXTRA_REGRESS_OPTS to all pg_regress invocations

build: add EXTRA_REGRESS_OPTS to all pg_regress invocations Patch by Christoph Berg Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/19fa6161dd6ba85b6c88b3476d165745dd5192d9 Modified Files -- src/Makefile.global.in |4 ++-- 1 file changed, 2 insertion

[COMMITTERS] pgsql: docs: clearify use of pg_database.datistemplate

docs: clearify use of pg_database.datistemplate Patch by Rajeev rastogi Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/72590b3a69baaf24d1090a2c2ceb9181be34043e Modified Files -- doc/src/sgml/catalogs.sgml |8 1 file changed, 4 insertions(+)

[COMMITTERS] pgsql: release memory used while flushing logical mappings

release memory used while flushing logical mappings Patch by Ants Aasma Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4d0d607a454ee832574afd52a3c515099cc85eb3 Modified Files -- src/backend/access/heap/rewriteheap.c |3 ++- 1 file changed, 2 insertio

[COMMITTERS] pgsql: doc: improve CREATE RULE event list

doc: improve CREATE RULE event list Patch by Fujii Masao Report by Emanuel Calvo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c27bf777cf4e05d318e202316857b354cc2f7a5a Modified Files -- doc/src/sgml/ref/create_rule.sgml |4 1 file changed, 4

[COMMITTERS] pgsql: regression test: fix hot standby tests by using repeatable read

regression test: fix hot standby tests by using repeatable read Serializable transactions won't work on a Hot Standby. Also fix VACUUM/ANALYZE label mixup. Patch by Martín Marqués Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2985e16031b61e9a428635e6860b3024570d

[COMMITTERS] pgsql: copy: update docs for FORCE_NULL and FORCE_NOT_NULL combination

copy: update docs for FORCE_NULL and FORCE_NOT_NULL combination Also update regression tests Patch by Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7ec73783d88a743799b0c262f1235f772497fb1d Modified Files -- contrib/file_fdw/file_fdw.c

[COMMITTERS] pgsql: Fix bug in the new B-tree incomplete-split code.

Fix bug in the new B-tree incomplete-split code. Forgot to update LSN of left sibling's page, when creating a new root. I fixed this for regular insertions and page splits earlier, but missed new root creation. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4a5d55ec

[COMMITTERS] pgsql: Fix Gin README.

Fix Gin README. The README incorrectly claimed that GIN posting tree pages contain an array of uncompressed items in addition to compressed posting lists. Earlier versions of the GIN posting list compression patch worked that way, but not the one that was committed. Branch -- master Details

[COMMITTERS] pgsql: doc: Improve "replication slot" index entries

doc: Improve "replication slot" index entries Now that we have accumulated two different "replication slot" concepts, make the index entries consistent. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/80ce90b9c40d10dc3acaf10ac0975c3b8d1e3289 Modified Files -

[COMMITTERS] pgsql: Fix bug in new B-tree page deletion code.

Fix bug in new B-tree page deletion code. When modifying a page, must hold an exclusive lock. A shared lock is obviously not good enough. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/77fe2b6d795f3f4ed282c9c980920e128a57624e Modified Files -- src/backe

[COMMITTERS] pgsql: Retain original physical order of tuples in redo of b-tree split

Retain original physical order of tuples in redo of b-tree splits. It makes no difference to the system, but minimizing the differences between a master and standby makes debugging simpler. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7e30c186da8eaae84ab30352ac23f

[COMMITTERS] pgsql: Fix rm_desc routine of b-tree page delete records.

Fix rm_desc routine of b-tree page delete records. A couple of typos from my refactoring of the page deletion patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7d98054f0dd115f57ad0ec1f424a66c13459013b Modified Files -- src/backend/access/rmgrdesc/nb

[COMMITTERS] pgsql: Avoid transient bogus page contents when creating a sequence.

Avoid transient bogus page contents when creating a sequence. Don't use simple_heap_insert to insert the tuple to a sequence relation. simple_heap_insert creates a heap insertion WAL record, and replaying that will create a regular heap page without the special area containing the sequence magic c