Re: [COMMITTERS] pgsql: Update 9.4 release notes for queryid control

2014-05-05 Thread Amit Langote
Perhaps a typo/copy-pasto in this commit, ;-) This allows monitoring tools to only fetch query texts for newly observe entries, as determined by queryid. s/observe/observed -- Amit

Re: [COMMITTERS] pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.

2014-05-05 Thread Tom Lane
Andres Freund writes: > On 2014-05-05 13:08:32 +, Heikki Linnakangas wrote: >> Replace SYSTEMQUOTEs with Windows-specific wrapper functions. > You noticed that the non MSVC windows animals don't like this patch? I think it might be just this: http://git.postgresql.org/gitweb/?p=postgresql.g

[COMMITTERS] pgsql: Properly detect read and write errors in pg_dump/dumpall, and pg

2014-05-05 Thread Bruce Momjian
Properly detect read and write errors in pg_dump/dumpall, and pg_restore Previously some I/O errors were ignored. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/14ea89366fe321609afc5838ff9fe2ded1cd707d Modified Files -- src/bin/pg_dump/compress_io.c

[COMMITTERS] pgsql: Update 9.4 release notes for queryid control

2014-05-05 Thread Bruce Momjian
Update 9.4 release notes for queryid control Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/768fb0032655e37810ab37a22f870af85ab1108c Modified Files -- doc/src/sgml/release-9.4.sgml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent vi

[COMMITTERS] pgsql: Run autoconf in wake of commit a692ee5870f0f442565b4c4bff3670945

2014-05-05 Thread Tom Lane
Run autoconf in wake of commit a692ee5870f0f442565b4c4bff367094599e9bdf. Heikki updated configure.in but evidently forgot to include the updated configure script in the commit. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9252b8eec27bbefbeae9d60d8c

[COMMITTERS] pgsql: Move pg_stat_statements into its on 9.4 release note section

2014-05-05 Thread Bruce Momjian
Move pg_stat_statements into its on 9.4 release note section Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a1c287a3836ff47e7ea01c82aceba75f15ba7c91 Modified Files -- doc/src/sgml/release-9.4.sgml | 76 ++--- 1 file c

[COMMITTERS] pgsql: In 9.4 release notes, add detail to pg_stat_statements items

2014-05-05 Thread Bruce Momjian
In 9.4 release notes, add detail to pg_stat_statements items Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/60832ea39d670cb6c39081e31ad175e0e1c555f8 Modified Files -- doc/src/sgml/release-9.4.sgml | 20 +++- 1 file changed, 15 insertions

[COMMITTERS] pgsql: Improve JSONB 9.4 release text

2014-05-05 Thread Bruce Momjian
Improve JSONB 9.4 release text Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/49c683bafda8659b885b2b119042e16cba1f702a Modified Files -- doc/src/sgml/release-9.4.sgml |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via pgsql-committe

Re: [COMMITTERS] pgsql: Again fix initialization of auto-tuned effective_cache_size.

2014-05-05 Thread Andres Freund
Hi, On 2014-03-20 16:58:42 +, Tom Lane wrote: > Again fix initialization of auto-tuned effective_cache_size. > > The previous method was overly complex and underly correct; in particular, > by assigning the default value with PGC_S_OVERRIDE, it prevented later > attempts to change the setting

[COMMITTERS] pgsql: Add doc links to 9.4 release notes, and add major features list

2014-05-05 Thread Bruce Momjian
Add doc links to 9.4 release notes, and add major features list Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a64560d994faab23b76848b4e95027b7b11ad9a7 Modified Files -- doc/src/sgml/datatype.sgml|8 +- doc/src/sgml/release-9.4.sgml | 1039 +++

Re: [COMMITTERS] pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.

2014-05-05 Thread Andres Freund
Hi Heikki, On 2014-05-05 13:08:32 +, Heikki Linnakangas wrote: > Replace SYSTEMQUOTEs with Windows-specific wrapper functions. You noticed that the non MSVC windows animals don't like this patch? http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2014-05-05%2015%3A01%3A24 http:

Re: [COMMITTERS] pgsql: Fix pg_type.typlen for newly-revived line type.

2014-05-05 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Note that if the line type had been in use in the field, this would >> break pg_upgrade'ability of databases containing line values; but >> it seems unlikely that there are any (they'd have had to be compiled >> with -DENABLE_LINE_TYPE). > Should we add

[COMMITTERS] pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM

2014-05-05 Thread Tom Lane
Fix possible cache invalidation failure in ReceiveSharedInvalidMessages. Commit fad153ec45299bd4d4f29dec8d9e04e2f1c08148 modified sinval.c to reduce the number of calls into sinvaladt.c (which require taking a shared lock) by keeping a local buffer of collected-but-not-yet-processed messages. Howe

[COMMITTERS] pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM

2014-05-05 Thread Tom Lane
Fix possible cache invalidation failure in ReceiveSharedInvalidMessages. Commit fad153ec45299bd4d4f29dec8d9e04e2f1c08148 modified sinval.c to reduce the number of calls into sinvaladt.c (which require taking a shared lock) by keeping a local buffer of collected-but-not-yet-processed messages. Howe

[COMMITTERS] pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM

2014-05-05 Thread Tom Lane
Fix possible cache invalidation failure in ReceiveSharedInvalidMessages. Commit fad153ec45299bd4d4f29dec8d9e04e2f1c08148 modified sinval.c to reduce the number of calls into sinvaladt.c (which require taking a shared lock) by keeping a local buffer of collected-but-not-yet-processed messages. Howe

[COMMITTERS] pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM

2014-05-05 Thread Tom Lane
Fix possible cache invalidation failure in ReceiveSharedInvalidMessages. Commit fad153ec45299bd4d4f29dec8d9e04e2f1c08148 modified sinval.c to reduce the number of calls into sinvaladt.c (which require taking a shared lock) by keeping a local buffer of collected-but-not-yet-processed messages. Howe

[COMMITTERS] pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM

2014-05-05 Thread Tom Lane
Fix possible cache invalidation failure in ReceiveSharedInvalidMessages. Commit fad153ec45299bd4d4f29dec8d9e04e2f1c08148 modified sinval.c to reduce the number of calls into sinvaladt.c (which require taking a shared lock) by keeping a local buffer of collected-but-not-yet-processed messages. Howe

[COMMITTERS] pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM

2014-05-05 Thread Tom Lane
Fix possible cache invalidation failure in ReceiveSharedInvalidMessages. Commit fad153ec45299bd4d4f29dec8d9e04e2f1c08148 modified sinval.c to reduce the number of calls into sinvaladt.c (which require taking a shared lock) by keeping a local buffer of collected-but-not-yet-processed messages. Howe

Re: [COMMITTERS] pgsql: Fix pg_type.typlen for newly-revived line type.

2014-05-05 Thread Alvaro Herrera
Tom Lane wrote: > Note that if the line type had been in use in the field, this would > break pg_upgrade'ability of databases containing line values; but > it seems unlikely that there are any (they'd have had to be compiled > with -DENABLE_LINE_TYPE). Should we add a test to pg_upgrade --check m

[COMMITTERS] pgsql: Fix pg_type.typlen for newly-revived line type.

2014-05-05 Thread Tom Lane
Fix pg_type.typlen for newly-revived line type. Commit 261c7d4b653bc3e44c31fd456d94f292caa50d8f removed the "m" field from struct LINE, but neglected to make pg_type.h's idea of the type's size match. This resulted in reading past the end of palloc'd LINE values when inserting them into tuples et

Re: [COMMITTERS] pgsql: Revive line type

2014-05-05 Thread Andres Freund
On 2014-05-05 13:24:15 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2013-10-10 02:43:20 +, Peter Eisentraut wrote: > >> Revive line type > > > That commit missed to update pg_type.h to the changed length of the line > > type. Patch attached. > > Ouch. Good thing we caught this now.

Re: [COMMITTERS] pgsql: Revive line type

2014-05-05 Thread Tom Lane
Andres Freund writes: > On 2013-10-10 02:43:20 +, Peter Eisentraut wrote: >> Revive line type > That commit missed to update pg_type.h to the changed length of the line > type. Patch attached. Ouch. Good thing we caught this now. In principle, fixing this breaks pg_upgrade'ability for anyo

[COMMITTERS] pgsql: Add SGML markup tags to 9.4 release notes

2014-05-05 Thread Bruce Momjian
Add SGML markup tags to 9.4 release notes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b2f7bd72c4d3e80065725c72e85778d5f4bdfd4a Modified Files -- doc/src/sgml/release-9.4.sgml | 409 + 1 file changed, 205 inserti

Re: [COMMITTERS] pgsql: Revive line type

2014-05-05 Thread Andres Freund
Hi Peter, On 2013-10-10 02:43:20 +, Peter Eisentraut wrote: > Revive line type > > Change the input/output format to {A,B,C}, to match the internal > representation. > > Complete the implementations of line_in, line_out, line_recv, line_send. > Remove comments and error messages about the li

[COMMITTERS] pgsql: Fix case of pg_dump -Fc to an unseekable file (such as a pipe).

2014-05-05 Thread Tom Lane
Fix case of pg_dump -Fc to an unseekable file (such as a pipe). This was accidentally broken in commits cfa1b4a711/5e8e794e3b. It saves a line or so to call ftello unconditionally in _CloseArchive, but we have to expect that it might fail if we're not in hasSeek mode. Per report from Bernd Helmle.

Re: [COMMITTERS] pgsql: Minor pg_dump improvements

2014-05-05 Thread Tom Lane
Bernd Helmle writes: > It stroke me today that there's still something broken. pg_dump fails when > used in custom archive mode and piping to e.g. pg_restore: > pg_dump -Fc -p 5447 regression | pg_restore > pg_dump: [custom archiver] could not determine seek position in archive > file: Illegal

Re: [COMMITTERS] pgsql: Minor pg_dump improvements

2014-05-05 Thread Bernd Helmle
--On 9. Februar 2014 13:55:03 -0500 Tom Lane wrote: Agreed; we should be using the same coding pattern wherever we call ftello. I suspect that this code may be left over from coping with some ancient non-spec-compliant version of ftello? Probably not worth digging in the archives to find ou

[COMMITTERS] pgsql: Update "huge pages" description in the 9.4 release notes

2014-05-05 Thread Bruce Momjian
Update "huge pages" description in the 9.4 release notes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f8db074049be74fa100b4f97d09ee76222660e7c Modified Files -- doc/src/sgml/release-9.4.sgml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

Re: [COMMITTERS] pgsql: Initial version of Postgres 9.4 release notes

2014-05-05 Thread Bruce Momjian
On Sun, May 4, 2014 at 07:13:08AM -0400, Bruce Momjian wrote: > On Sat, May 3, 2014 at 08:32:32PM -0700, Peter Geoghegan wrote: > > On Sat, May 3, 2014 at 8:16 PM, Bruce Momjian wrote: > > > Initial version of Postgres 9.4 release notes > > > > Did you forget to "git add release-9.4.sgml"? > >

[COMMITTERS] pgsql: Update 9.4 release notes with feedback from the hackers list

2014-05-05 Thread Bruce Momjian
Update 9.4 release notes with feedback from the hackers list Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5b8de6d4676ed9eb6df4685deb601be3db4eaa24 Modified Files -- doc/src/sgml/release-9.4.sgml | 141 ++--- 1 file c

[COMMITTERS] pgsql: doc: In FDW handler docs, mark up scan_clauses with .

2014-05-05 Thread Robert Haas
doc: In FDW handler docs, mark up scan_clauses with . Etsuro Fujita Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c70cc9afb3c561addeab805b15352d5ffb6d8f38 Modified Files -- doc/src/sgml/fdwhandler.sgml |6 +++--- 1 file changed, 3 insertions(+), 3 d

Re: [COMMITTERS] pgsql: Add missing 9.4 release file.

2014-05-05 Thread Bruce Momjian
On Mon, May 5, 2014 at 06:02:18PM +0900, Michael Paquier wrote: > On Mon, May 5, 2014 at 5:04 PM, Amit Langote wrote: > > Spotted a typo: > > > > + > > +worker_spi_launch() in worker_spi shows an example if its use. > > + > > + > > > > s/example if/example of > s/((Rob

Re: [COMMITTERS] pgsql: Add missing 9.4 release file.

2014-05-05 Thread Bruce Momjian
On Mon, May 5, 2014 at 05:04:44PM +0900, Amit Langote wrote: > Spotted a typo: > > + > +worker_spi_launch() in worker_spi shows an example if its use. > + > + > > s/example if/example of Thanks, fixed. -- Bruce Momjian http://momjian.us EnterpriseDB

[COMMITTERS] pgsql: Pass sensible value to memset() when randomizing reorderbuffer's

2014-05-05 Thread Heikki Linnakangas
Pass sensible value to memset() when randomizing reorderbuffer's tuple slab. This is entirely harmless, but still wrong. Noticed by coverity. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/377790fbd707b41bdf2264fe6c217e903e241f7c Modified Files -

[COMMITTERS] pgsql: Assert that pre/post-fix updated tuples are on the same page dur

2014-05-05 Thread Heikki Linnakangas
Assert that pre/post-fix updated tuples are on the same page during replay. If they were not 'oldtup.t_data' would be dereferenced while set to NULL in case of a full page image for block 0. Do so primarily to silence coverity; but also to make sure this prerequisite isn't changed without adaptin

[COMMITTERS] pgsql: Don't leak memory after connection aborts in pg_recvlogical.

2014-05-05 Thread Heikki Linnakangas
Don't leak memory after connection aborts in pg_recvlogical. Andres Freund, noticed by coverity. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/329de9fa983debc941ebd79f335f2574b72a3694 Modified Files -- src/bin/pg_basebackup/pg_recvlogical.c |8

[COMMITTERS] pgsql: Use Size instead of uint32 to store result of sizeof()

2014-05-05 Thread Heikki Linnakangas
Use Size instead of uint32 to store result of sizeof() Silences coverity and is more consistent with other functions in the same file. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c83457683968e2263d7e6bcdcdd52d472f9b0f8d Modified Files

[COMMITTERS] pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.

2014-05-05 Thread Heikki Linnakangas
Replace SYSTEMQUOTEs with Windows-specific wrapper functions. It's easy to forget using SYSTEMQUOTEs when constructing command strings for system() or popen(). Even if we fix all the places missing it now, it is bound to be forgotten again in the future. Introduce wrapper functions that do the the

Re: [COMMITTERS] pgsql: Add missing 9.4 release file.

2014-05-05 Thread Michael Paquier
On Mon, May 5, 2014 at 5:04 PM, Amit Langote wrote: > Spotted a typo: > > + > +worker_spi_launch() in worker_spi shows an example if its use. > + > + > > s/example if/example of s/((Robert/(Robert/g -- Michael -- Sent via pgsql-committers mailing list (pgsql-committ

Re: [COMMITTERS] pgsql: Add missing 9.4 release file.

2014-05-05 Thread Amit Langote
Spotted a typo: + +worker_spi_launch() in worker_spi shows an example if its use. + + s/example if/example of -- Amit -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpre