Re: [COMMITTERS] pgsql: Let installcheck-world pass against a server requiring a passwor

2014-06-19 Thread Noah Misch
On Thu, Jun 19, 2014 at 10:21:06PM -0400, Tom Lane wrote: > Noah Misch writes: > > Let installcheck-world pass against a server requiring a password. > > Give passwords to each user created in support of an ECPG connection > > test case. Use SET SESSION AUTHORIZATION, not a fresh connection, to >

Re: [COMMITTERS] pgsql: Let installcheck-world pass against a server requiring a passwor

2014-06-19 Thread Tom Lane
Noah Misch writes: > Let installcheck-world pass against a server requiring a password. > Give passwords to each user created in support of an ECPG connection > test case. Use SET SESSION AUTHORIZATION, not a fresh connection, to > reduce privileges during a dblink test case. Hm ... is this reas

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Avoid leaking memory while evaluating arguments for a table func

2014-06-19 Thread Tom Lane
Avoid leaking memory while evaluating arguments for a table function. ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM in the query-lifespan memory context. This is insignificant in simple cases where the function relation is scanned only once; but if the function is in

[COMMITTERS] pgsql: Let installcheck-world pass against a server requiring a passwor

2014-06-19 Thread Noah Misch
Let installcheck-world pass against a server requiring a password. Give passwords to each user created in support of an ECPG connection test case. Use SET SESSION AUTHORIZATION, not a fresh connection, to reduce privileges during a dblink test case. To test against such a server, both the "make

[COMMITTERS] pgsql: Fix contrib/pg_upgrade/test.sh for $PWD containing spaces.

2014-06-19 Thread Noah Misch
Fix contrib/pg_upgrade/test.sh for $PWD containing spaces. Most of the necessary quoting was in place; this catches the exceptions. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/686f362bee126e50280bcd3b35807b02f18a8966 Modified Files -- contrib/pg_upgr

[COMMITTERS] pgsql: Document SQL functions' behavior of parsing the whole function a

2014-06-19 Thread Tom Lane
Document SQL functions' behavior of parsing the whole function at once. Haribabu Kommi, somewhat rewritten by me Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b488daf0d59614e801059e3558f73b65b0cf7e06 Modified Files -- doc/src/sgml/xfunc.sgml |

[COMMITTERS] pgsql: Document SQL functions' behavior of parsing the whole function a

2014-06-19 Thread Tom Lane
Document SQL functions' behavior of parsing the whole function at once. Haribabu Kommi, somewhat rewritten by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f28d9b10f73440adcb2e094440b4b213673e491b Modified Files -- doc/src/sgml/xfunc.sgml | 15 +++

[COMMITTERS] pgsql: Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET.

2014-06-19 Thread Kevin Grittner
Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET. Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f failed to include NUM_BUFFER_PARTITIONS in this offset, resulting in a bad offset. Ultimately this threw off NUM_FIXED_LWLOCKS which is based on earlier offsets, leading to memory allocation pro

[COMMITTERS] pgsql: Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET.

2014-06-19 Thread Kevin Grittner
Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET. Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f failed to include NUM_BUFFER_PARTITIONS in this offset, resulting in a bad offset. Ultimately this threw off NUM_FIXED_LWLOCKS which is based on earlier offsets, leading to memory allocation pro

[COMMITTERS] pgsql: Don't allow data_directory to be set in postgresql.auto.conf by

2014-06-19 Thread Fujii Masao
Don't allow data_directory to be set in postgresql.auto.conf by ALTER SYSTEM. data_directory could be set both in postgresql.conf and postgresql.auto.conf so far. This could cause some problematic situations like circular definition. To avoid such situations, this commit forbids a user to set da

[COMMITTERS] pgsql: Don't allow data_directory to be set in postgresql.auto.conf by

2014-06-19 Thread Fujii Masao
Don't allow data_directory to be set in postgresql.auto.conf by ALTER SYSTEM. data_directory could be set both in postgresql.conf and postgresql.auto.conf so far. This could cause some problematic situations like circular definition. To avoid such situations, this commit forbids a user to set da