[COMMITTERS] pgsql: Install libpq DLL with $(INSTALL_SHLIB).

2014-08-18 Thread Noah Misch
Install libpq DLL with $(INSTALL_SHLIB). Programs need execute permission on a DLL file to load it. MSYS "install" ignores the mode argument, and our Cygwin build statically links libpq into programs. That explains the lack of buildfarm trouble. Back-patch to 9.0 (all supported versions). Branc

[COMMITTERS] pgsql: Finish adding file version information to installed Windows bina

2014-08-18 Thread Noah Misch
Finish adding file version information to installed Windows binaries. In support of this, have the MSVC build follow GNU make in preferring GNUmakefile over Makefile when a directory contains both. Michael Paquier, reviewed by MauMau. Branch -- master Details --- http://git.postgresql.o

[COMMITTERS] pgsql: Make pg_service.conf sample LDIF more portable.

2014-08-18 Thread Noah Misch
Make pg_service.conf sample LDIF more portable. The aboriginal sample placed connection parameters in groupOfUniqueNames/uniqueMember. OpenLDAP, at least as early as version 2.4.23, rejects uniqueMember entries that do not conform to the syntax for a distinguished name. Use device/description, w

[COMMITTERS] pgsql: Install libpq DLL with $(INSTALL_SHLIB).

2014-08-18 Thread Noah Misch
Install libpq DLL with $(INSTALL_SHLIB). Programs need execute permission on a DLL file to load it. MSYS "install" ignores the mode argument, and our Cygwin build statically links libpq into programs. That explains the lack of buildfarm trouble. Back-patch to 9.0 (all supported versions). Branc

[COMMITTERS] pgsql: Document new trigger-related forms of ALTER FOREIGN TABLE.

2014-08-18 Thread Noah Misch
Document new trigger-related forms of ALTER FOREIGN TABLE. Oversight in commit 7cbe57c34dec4860243e6d0f81738cfbb6e5d069. Back-patch to 9.4, where that commit first appeared. In passing, release-note the FDW API postcondition change from the same commit. Branch -- master Details --- http

[COMMITTERS] pgsql: Install libpq DLL with $(INSTALL_SHLIB).

2014-08-18 Thread Noah Misch
Install libpq DLL with $(INSTALL_SHLIB). Programs need execute permission on a DLL file to load it. MSYS "install" ignores the mode argument, and our Cygwin build statically links libpq into programs. That explains the lack of buildfarm trouble. Back-patch to 9.0 (all supported versions). Branc

[COMMITTERS] pgsql: Install libpq DLL with $(INSTALL_SHLIB).

2014-08-18 Thread Noah Misch
Install libpq DLL with $(INSTALL_SHLIB). Programs need execute permission on a DLL file to load it. MSYS "install" ignores the mode argument, and our Cygwin build statically links libpq into programs. That explains the lack of buildfarm trouble. Back-patch to 9.0 (all supported versions). Branc

[COMMITTERS] pgsql: Document new trigger-related forms of ALTER FOREIGN TABLE.

2014-08-18 Thread Noah Misch
Document new trigger-related forms of ALTER FOREIGN TABLE. Oversight in commit 7cbe57c34dec4860243e6d0f81738cfbb6e5d069. Back-patch to 9.4, where that commit first appeared. In passing, release-note the FDW API postcondition change from the same commit. Branch -- REL9_4_STABLE Details -

[COMMITTERS] pgsql: Make pg_service.conf sample LDIF more portable.

2014-08-18 Thread Noah Misch
Make pg_service.conf sample LDIF more portable. The aboriginal sample placed connection parameters in groupOfUniqueNames/uniqueMember. OpenLDAP, at least as early as version 2.4.23, rejects uniqueMember entries that do not conform to the syntax for a distinguished name. Use device/description, w

[COMMITTERS] pgsql: Install libpq DLL with $(INSTALL_SHLIB).

2014-08-18 Thread Noah Misch
Install libpq DLL with $(INSTALL_SHLIB). Programs need execute permission on a DLL file to load it. MSYS "install" ignores the mode argument, and our Cygwin build statically links libpq into programs. That explains the lack of buildfarm trouble. Back-patch to 9.0 (all supported versions). Branc

[COMMITTERS] pgsql: Replace a few strncmp() calls with strlcpy().

2014-08-18 Thread Noah Misch
Replace a few strncmp() calls with strlcpy(). strncmp() is a specialized API unsuited for routine copying into fixed-size buffers. On a system where the length of a single filename can exceed MAXPGPATH, the pg_archivecleanup change prevents a simple crash in the subsequent strlen(). Few filesyst

[COMMITTERS] pgsql: Install libpq DLL with $(INSTALL_SHLIB).

2014-08-18 Thread Noah Misch
Install libpq DLL with $(INSTALL_SHLIB). Programs need execute permission on a DLL file to load it. MSYS "install" ignores the mode argument, and our Cygwin build statically links libpq into programs. That explains the lack of buildfarm trouble. Back-patch to 9.0 (all supported versions). Branc

Re: [COMMITTERS] pgsql: Adjust Release Notes to reflect holding off wrapped expanded mod

2014-08-18 Thread Tom Lane
Greg Stark writes: > On Mon, Aug 18, 2014 at 4:55 PM, Tom Lane wrote: >> Actually, that needs to be done in master, which is always the >> authoritative copy of release-note SGML files. > hm, interesting. ok. To clarify --- there's certainly no harm in patching the back-branch copies too. But

[COMMITTERS] pgsql: Adjust Release Notes to reflect holding off wrapped expanded mod

2014-08-18 Thread Greg Stark
Adjust Release Notes to reflect holding off wrapped expanded mode until 9.5 (thanks Michael Paquier) Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/663675885ec2c97c8b59ce3e30f6ad05d162a584 Modified Files -- doc/src/sgml/release-9.4.sgml |8

Re: [COMMITTERS] pgsql: Adjust Release Notes to reflect holding off wrapped expanded mod

2014-08-18 Thread Greg Stark
On Mon, Aug 18, 2014 at 4:55 PM, Tom Lane wrote: > Actually, that needs to be done in master, which is always the > authoritative copy of release-note SGML files. hm, interesting. ok. -- greg -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your

Re: [COMMITTERS] pgsql: Adjust Release Notes to reflect holding off wrapped expanded mod

2014-08-18 Thread Tom Lane
Greg Stark writes: > Adjust Release Notes to reflect holding off wrapped expanded mode until 9.5 > (thanks Michael Paquier) > Branch > -- > REL9_4_STABLE Actually, that needs to be done in master, which is always the authoritative copy of release-note SGML files. reg

[COMMITTERS] pgsql: Adjust Release Notes to reflect holding off wrapped expanded mod

2014-08-18 Thread Greg Stark
Adjust Release Notes to reflect holding off wrapped expanded mode until 9.5 (thanks Michael Paquier) Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/61947069ffb27a7eb8037cbd7756dbcbb06ebd4a Modified Files -- doc/src/sgml/release-9.4.sgml |8 --

[COMMITTERS] pgsql: Fix further concerns about psql wrapping in expanded mode having

2014-08-18 Thread Greg Stark
Fix further concerns about psql wrapping in expanded mode having collateral damage on other formats, by Sergey Muraviov. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/458ef6bad15702a3ac9b7b302a0378f8817620c0 Modified Files -- src/bin/psql/print.c

[COMMITTERS] pgsql: Revert psql changes to support wrapped expanded mode. That featu

2014-08-18 Thread Greg Stark
Revert psql changes to support wrapped expanded mode. That feature is nice and we'll keep it in 9.5 but it'll take more time to iron out the collateral damage on other queries and also on tools like check_postgres. revert dbe31616c9be7380b8a88cdfbeaa68dbdcdebc36 revert 6513633b94173fc1d9e2b213c43f

Re: [COMMITTERS] pgsql: Break out OpenSSL-specific code to separate files.

2014-08-18 Thread Heikki Linnakangas
On 08/17/2014 03:15 PM, Andres Freund wrote: On 2014-08-11 09:11:08 +, Heikki Linnakangas wrote: Break out OpenSSL-specific code to separate files. This refactoring is in preparation for adding support for other SSL implementations, with no user-visible effects. There are now two #defines,

[COMMITTERS] pgsql: Reorganize functions in be-secure-openssl.c

2014-08-18 Thread Heikki Linnakangas
Reorganize functions in be-secure-openssl.c Move the functions within the file so that public interface functions come first, followed by internal functions. Previously, be_tls_write was first, then internal stuff, and finally the rest of the public interface, which clearly didn't make much sense.