[COMMITTERS] pgsql: Fix cost estimation for indexscans on expensive indexed expressi

Fix cost estimation for indexscans on expensive indexed expressions. genericcostestimate() and friends used the cost of the entire indexqual expressions as the charge for initial evaluation of indexscan arguments. But of course the index column is not evaluated, only the other side of the qual exp

[COMMITTERS] pgsql: Fix an obsolete reference to SnapshotNow in comment.

Fix an obsolete reference to SnapshotNow in comment. Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f8b031bca848a21fb9a7c9530f8cdc7eb6919dd9 Modified Files -- src/backend/replication/logical/snapbuild.c |2 +- 1 file changed, 1 insert

[COMMITTERS] pgsql: Fix long-obsolete code for separating filter conditions in cost_

Fix long-obsolete code for separating filter conditions in cost_index(). This code relied on pointer equality to identify which restriction clauses also appear in the indexquals (and, therefore, don't need to be applied as simple filter conditions). That was okay once upon a time, years ago, befo

[COMMITTERS] pgsql: Remove residual NULL-pstate handling in addRangeTableEntry.

Remove residual NULL-pstate handling in addRangeTableEntry. Passing a NULL pstate wouldn't actually work, because isLockedRefname() isn't prepared to cope with it; and there hasn't been any in-core code that tries in over a decade. So just remove the residual NULL handling. Spotted by Coverity;

[COMMITTERS] pgsql: Change many routines to return ObjectAddress rather than OID

Change many routines to return ObjectAddress rather than OID The changed routines are mostly those that can be directly called by ProcessUtilitySlow; the intention is to make the affected object information more precise, in support for future event trigger changes. Originally it was envisioned tha

[COMMITTERS] pgsql: Add comment for "is_internal" parameter

Add comment for "is_internal" parameter This was missed in my commit f4c4335 of 9.3 vintage, so backpatch to that. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2570e28827e3ac4a316300f92dfaf448e55c8e0c Modified Files -- src/backend/catalog/heap.

[COMMITTERS] pgsql: Add comment for "is_internal" parameter

Add comment for "is_internal" parameter This was missed in my commit f4c4335 of 9.3 vintage, so backpatch to that. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6f9d79904748c26a58991942dc6719db558f77b0 Modified Files -- src/backend/catalog/heap.c |

[COMMITTERS] pgsql: Add comment for "is_internal" parameter

Add comment for "is_internal" parameter This was missed in my commit f4c4335 of 9.3 vintage, so backpatch to that. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/73f236f5793e25f04933247917092de39011afd9 Modified Files -- src/backend/catalog/heap.

[COMMITTERS] pgsql: Reduce json <=> jsonb casts from explicit-only to assignment lev

Reduce json <=> jsonb casts from explicit-only to assignment level. There's no reason to make users write an explicit cast to store a json value in a jsonb column or vice versa. We could probably even make these implicit, but that might open us up to problems with ambiguous function calls, so for

[COMMITTERS] pgsql: pgbench: Fix mistakes in Makefile.

pgbench: Fix mistakes in Makefile. My commit 878fdcb843e087cc1cdeadc987d6ef55202ddd04 was not quite right. Tom Lane pointed out one of the mistakes fixed here, and I noticed the other myself while reviewing what I'd committed. Branch -- master Details --- http://git.postgresql.org/pg/co