Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Mark Dilger
> On Sep 22, 2015, at 6:09 AM, Andrew Dunstan wrote: > > You are fighting a losing battle. Think of they/them/their/theirs as being > indefinitely gendered third person singular pronouns, as well as being third > person plural pronouns. Yes it's a relatively new usage,

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Peter Geoghegan
On Tue, Sep 22, 2015 at 7:11 AM, Andrew Dunstan wrote: > You can think that if you like, but it's not even remotely true. It's a > deliberate choice to use a new, perfectly reasonable and now widely accepted > style of which you disapprove, but it's not lazy. It never

[COMMITTERS] pgsql: Teach planstate_tree_walker about custom scans.

2015-09-22 Thread Robert Haas
Teach planstate_tree_walker about custom scans. This logic was missing from ExplainPreScanNode, from which I derived planstate_tree_walker. But it shouldn't be missing, especially not from a generic walker function, so add it. KaiGai Kohei Branch -- master Details ---

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Geoff Winkless
On 22 September 2015 at 21:22, David Steele wrote: > I think conversations like this are a part of why we have trouble > attracting new contributors (of any gender) to the community. > ​It's very clear that my use of the word (which I shan't make the mistake of repeating!)

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Adam Brightwell
> I think conversations like this are a part of why we have trouble attracting > new contributors (of any gender) to the community. +1 -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription:

[COMMITTERS] pgsql: Fix sepgsql regression tests (9.2-only patch).

2015-09-22 Thread Joe Conway
Fix sepgsql regression tests (9.2-only patch). The regression tests for sepgsql were broken by changes in the base distro as-shipped policies. Specifically, definition of unconfined_t in the system default policy was changed to bypass multi-category rules, which the regression test depended on.

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread David Steele
On 9/22/15 11:00 AM, Andrew Dunstan wrote: On 09/22/2015 10:29 AM, Geoff Winkless wrote: ​ That's your opinion; my opinion remains otherwise. It's not "perfectly reasonable" to abuse the plural because some 1960s feminazis either misunderstood or didn't like the fact that (because of history)

[COMMITTERS] pgsql: Skip recently-added umask() call on Windows.

2015-09-22 Thread Noah Misch
Skip recently-added umask() call on Windows. Symbols S_IRWXG and S_IRWXO became available to Windows builds in commit 1319002e2ee166c06b38cdbc5e8508c7205fa115, so PostgreSQL 9.0 cannot use them in platform-independent code. Rewrite commit 24aed2124a5273e4cb543b06d4b7bb2c2ad5bf3c to not change

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Geoff Winkless
On 22 September 2015 at 09:28, Albe Laurenz wrote: > Peter Geoghegan wrote: > > On Mon, Sep 21, 2015 at 9:32 PM, Erik Rijkers wrote: > >> I think this compulsive 'he'-avoiding is making the text worse. > >> > >> > >> - environment variable); any

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Albe Laurenz
Peter Geoghegan wrote: > On Mon, Sep 21, 2015 at 9:32 PM, Erik Rijkers wrote: >> I think this compulsive 'he'-avoiding is making the text worse. >> >> >> - environment variable); any user can make such a change for his >> session. >> + environment variable); any user

[COMMITTERS] pgsql: Correct value of LW_SHARED_MASK.

2015-09-22 Thread Andres Freund
Correct value of LW_SHARED_MASK. The previous wrong value lead to wrong LOCK_DEBUG output, never showing any shared lock holders. Reported-By: Alexander Korotkov Discussion: CAPpHfdsPmWqz9FB0AnxJrwp1=KLF0n=-ib+qvr0q8gsmpfv...@mail.gmail.com Backpatch: 9.5, where the bug was introduced. Branch

[COMMITTERS] pgsql: Correct value of LW_SHARED_MASK.

2015-09-22 Thread Andres Freund
Correct value of LW_SHARED_MASK. The previous wrong value lead to wrong LOCK_DEBUG output, never showing any shared lock holders. Reported-By: Alexander Korotkov Discussion: CAPpHfdsPmWqz9FB0AnxJrwp1=KLF0n=-ib+qvr0q8gsmpfv...@mail.gmail.com Backpatch: 9.5, where the bug was introduced. Branch

[COMMITTERS] pgsql: Add some notes about coding conventions do the docs.

2015-09-22 Thread Andres Freund
Add some notes about coding conventions do the docs. This deserves to be greatly expanded and improved, but it's a start. Discussion: 20150827145219.gi2...@awork2.anarazel.de Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d9cb34abb40c547325dbf24e8986698dffc9ffa8

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Geoff Winkless
On 22 September 2015 at 14:09, Andrew Dunstan wrote: > You are fighting a losing battle. Think of they/them/their/theirs as being > indefinitely gendered third person singular pronouns, as well as being > third person plural pronouns. Yes it's a relatively new usage, but I

[COMMITTERS] pgsql: test_decoding: Protect against rare spurious test failures.

2015-09-22 Thread Andres Freund
test_decoding: Protect against rare spurious test failures. A bunch of tests missed specifying that empty transactions shouldn't be displayed. That causes problems when e.g. autovacuum runs in an unfortunate moment. The tests in question only run for a very short time, making this quite unlikely.

[COMMITTERS] pgsql: test_decoding: Protect against rare spurious test failures.

2015-09-22 Thread Andres Freund
test_decoding: Protect against rare spurious test failures. A bunch of tests missed specifying that empty transactions shouldn't be displayed. That causes problems when e.g. autovacuum runs in an unfortunate moment. The tests in question only run for a very short time, making this quite unlikely.

[COMMITTERS] pgsql: test_decoding: Protect against rare spurious test failures.

2015-09-22 Thread Andres Freund
test_decoding: Protect against rare spurious test failures. A bunch of tests missed specifying that empty transactions shouldn't be displayed. That causes problems when e.g. autovacuum runs in an unfortunate moment. The tests in question only run for a very short time, making this quite unlikely.

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Gavin Flower
On 22/09/15 21:33, Geoff Winkless wrote: On 22 September 2015 at 09:28, Albe Laurenz >wrote: Peter Geoghegan wrote: > On Mon, Sep 21, 2015 at 9:32 PM, Erik Rijkers > wrote: >> I

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Geoff Winkless
On 22 September 2015 at 10:52, Gavin Flower wrote: > On 22/09/15 21:33, Geoff Winkless wrote: > >> ​​ >> Without wanting to get into a grammar war, ​I'm not so sure I agree that >> it "condones" it. Dictionaries reflect the current state of usage, they >> don't act

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Bill Moran
On Tue, 22 Sep 2015 11:17:54 +0100 Geoff Winkless wrote: > On 22 September 2015 at 10:52, Gavin Flower > wrote: > > > On 22/09/15 21:33, Geoff Winkless wrote: > >> ?? > >> Without wanting to get into a grammar war, ?I'm not so sure I agree

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Wolfgang Wilhelm
Hello all, I'm a non-native speaker and to my shame not very good in english at all. So just my 2c on the topic: "Users can make such a change for their individual sessions" is for me perfectly understandable. "any user can make such a change for their session" is for me a mixture of a

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Gavin Flower
On 22/09/15 22:17, Geoff Winkless wrote: On 22 September 2015 at 10:52, Gavin Flower >wrote: On 22/09/15 21:33, Geoff Winkless wrote: ​ ​ Without wanting to get into a grammar war, ​I'm not so sure I

Re: [COMMITTERS] pgsql: Restrict file mode creation mask during tmpfile().

2015-09-22 Thread Andres Freund
On 2015-09-21 11:14:10 -0400, Noah Misch wrote: > On Mon, Sep 21, 2015 at 01:00:46AM +, Noah Misch wrote: > > Restrict file mode creation mask during tmpfile(). > > > REL9_0_STABLE > > This broke buildfarm member frogmouth (Windows, gcc) on this branch only. I > will look into it. Seems to

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 09:25 AM, Geoff Winkless wrote: If someone sends me a document that uses "their" in a singular usage, I will think that person is lazy. That will continue to be the case, whether people tell me that it's accepted usage or not. You can think that if you like, but it's not

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/68e83c12088aa2272ccdd632a37d647ea67548a0 Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/fe6d2ab473fdbe4b9408d8da3e97a5091171c743 Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 10:29 AM, Geoff Winkless wrote: Oh, good! We're actually going to have this argument? Even though I said I don't care what you do? On 22 September 2015 at 15:11, Andrew Dunstan > wrote: On 09/22/2015 09:25 AM, Geoff

Re: [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 12:32 AM, Erik Rijkers wrote: - might not be the same as the database user he needs to connect as. + might not be the same as the database user that is to be connect as. It is not an improvement. I would like to see this change rolled back. I agree this is awkward.

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 06:17 AM, Geoff Winkless wrote: On 22 September 2015 at 10:52, Gavin Flower >wrote: On 22/09/15 21:33, Geoff Winkless wrote: ​ ​ Without wanting to get into a grammar war, ​I'm not so

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Geoff Winkless
Oh, good! We're actually going to have this argument? Even though I said I don't care what you do? On 22 September 2015 at 15:11, Andrew Dunstan wrote: > On 09/22/2015 09:25 AM, Geoff Winkless wrote: > >> If someone sends me a document that uses "their" in a singular

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a86eab94304a9dee7a2c1504e0051f1959a37b6a Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d546ce7281c57b2bff3fc8702b88035dbcb0826c Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/11b44d1cf65bcd59f0a827e1ffab1f1bba1cd1e2 Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b1d5cc375b8786b2ff6293b3f3986c8edf120898 Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

2015-09-22 Thread Tom Lane
Docs: fix typo in to_char() example. Per bug #13631 from KOIZUMI Satoru. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f5f9d1b74e9cbf3a19ef947ac36376f73a0c10f5 Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1