[COMMITTERS] pgsql: Fix regrole and regnamespace output functions to do quoting, too

2016-01-03 Thread Tom Lane
Fix regrole and regnamespace output functions to do quoting, too. We discussed this but somehow failed to implement it... Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b0cadc08fea564f75a0702e15b2bd949377bd2f3 Modified Files -- src/backend/utils/adt/reg

[COMMITTERS] pgsql: Fix regrole and regnamespace output functions to do quoting, too

2016-01-03 Thread Tom Lane
Fix regrole and regnamespace output functions to do quoting, too. We discussed this but somehow failed to implement it... Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/de93252386e25b78400228b08326a50c43dd232b Modified Files -- src/backend/utils/

[COMMITTERS] pgsql: Fix regrole and regnamespace types to honor quoting like other r

2016-01-03 Thread Tom Lane
Fix regrole and regnamespace types to honor quoting like other reg* types. Aside from any consistency arguments, this is logically necessary because the I/O functions for these types also handle numeric OID values. Without a quoting rule it is impossible to distinguish numeric OIDs from role or n

[COMMITTERS] pgsql: Fix regrole and regnamespace types to honor quoting like other r

2016-01-03 Thread Tom Lane
Fix regrole and regnamespace types to honor quoting like other reg* types. Aside from any consistency arguments, this is logically necessary because the I/O functions for these types also handle numeric OID values. Without a quoting rule it is impossible to distinguish numeric OIDs from role or n

[COMMITTERS] pgsql: Fix bogus lock release in RemovePolicyById and RemoveRoleFromObj

2016-01-03 Thread Tom Lane
Fix bogus lock release in RemovePolicyById and RemoveRoleFromObjectPolicy. Can't release the AccessExclusiveLock on the target table until commit. Otherwise there is a race condition whereby other backends might service our cache invalidation signals before they can actually see the updated catalo

[COMMITTERS] pgsql: Fix bogus lock release in RemovePolicyById and RemoveRoleFromObj

2016-01-03 Thread Tom Lane
Fix bogus lock release in RemovePolicyById and RemoveRoleFromObjectPolicy. Can't release the AccessExclusiveLock on the target table until commit. Otherwise there is a race condition whereby other backends might service our cache invalidation signals before they can actually see the updated catalo

[COMMITTERS] pgsql: Do some copy-editing on the docs for row-level security.

2016-01-03 Thread Tom Lane
Do some copy-editing on the docs for row-level security. Clarifications, markup improvements, corrections of misleading or outright wrong statements. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/35adf6e44cb65111f7caf5a9988c0738790ef02d Modified Files -

[COMMITTERS] pgsql: Do some copy-editing on the docs for row-level security.

2016-01-03 Thread Tom Lane
Do some copy-editing on the docs for row-level security. Clarifications, markup improvements, corrections of misleading or outright wrong statements. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c1611db01fec587525e88270854c4b993846dcb3 Modified Files

[COMMITTERS] pgsql: Guard against null arguments in binary_upgrade_create_empty_exte

2016-01-03 Thread Tom Lane
Guard against null arguments in binary_upgrade_create_empty_extension(). The CHECK_IS_BINARY_UPGRADE macro is not sufficient security protection if we're going to dereference pass-by-reference arguments before it. But in any case we really need to explicitly check PG_ARGISNULL for all the argumen

[COMMITTERS] pgsql: Guard against null arguments in binary_upgrade_create_empty_exte

2016-01-03 Thread Tom Lane
Guard against null arguments in binary_upgrade_create_empty_extension(). The CHECK_IS_BINARY_UPGRADE macro is not sufficient security protection if we're going to dereference pass-by-reference arguments before it. But in any case we really need to explicitly check PG_ARGISNULL for all the argumen

[COMMITTERS] pgsql: Do some copy-editing on the docs for replication origins.

2016-01-03 Thread Tom Lane
Do some copy-editing on the docs for replication origins. Minor grammar and markup improvements. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2e5c9284f688d124b0169ff5b86003ca86842666 Modified Files -- doc/src/sgml/func.sgml| 3

[COMMITTERS] pgsql: Do some copy-editing on the docs for replication origins.

2016-01-03 Thread Tom Lane
Do some copy-editing on the docs for replication origins. Minor grammar and markup improvements. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c6aeba353a15d71f584488a7482fb88337f843e3 Modified Files -- doc/src/sgml/func.sgml| 39 +

[COMMITTERS] pgsql: Do a final round of copy-editing on the 9.5 release notes.

2016-01-03 Thread Tom Lane
Do a final round of copy-editing on the 9.5 release notes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/027989197aab9e555328721b003ebd1839a16704 Modified Files -- doc/src/sgml/release-9.5.sgml | 179 ++--- 1 file cha

[COMMITTERS] pgsql: Do a final round of copy-editing on the 9.5 release notes.

2016-01-03 Thread Tom Lane
Do a final round of copy-editing on the 9.5 release notes. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/78d0e582ab1087d0cde9d00d8c8994591ae3c955 Modified Files -- doc/src/sgml/release-9.5.sgml | 179 ++--- 1 f

[COMMITTERS] pgsql: Fix treatment of *lpNumberOfBytesRecvd == 0: that's a completion

2016-01-03 Thread Tom Lane
Fix treatment of *lpNumberOfBytesRecvd == 0: that's a completion condition. pgwin32_recv() has treated a non-error return of zero bytes from WSARecv() as being a reason to block ever since the current implementation was introduced in commit a4c40f140d23cefb. However, so far as one can tell from M

[COMMITTERS] pgsql: Fix treatment of *lpNumberOfBytesRecvd == 0: that's a completion

2016-01-03 Thread Tom Lane
Fix treatment of *lpNumberOfBytesRecvd == 0: that's a completion condition. pgwin32_recv() has treated a non-error return of zero bytes from WSARecv() as being a reason to block ever since the current implementation was introduced in commit a4c40f140d23cefb. However, so far as one can tell from M