[COMMITTERS] pgsql: Add explicit cast to amcostestimate call.

2016-01-17 Thread Tom Lane
Add explicit cast to amcostestimate call. My compiler doesn't complain here, but David Rowley's does ... Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/49b49506502026a3653bca490c939dc8934afe95 Modified Files -- src/backend/optimizer/path/costsize.c |

[COMMITTERS] pgsql: Re-pgindent a few files.

2016-01-17 Thread Tom Lane
Re-pgindent a few files. In preparation for landing index AM interface changes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8d290c8ec6c182a4df1d089c21fe84c7912f01fe Modified Files -- src/backend/catalog/index.c | 20 ++--

[COMMITTERS] pgsql: Restructure index access method API to hide most of it at the C

2016-01-17 Thread Tom Lane
Restructure index access method API to hide most of it at the C level. This patch reduces pg_am to just two columns, a name and a handler function. All the data formerly obtained from pg_am is now provided in a C struct returned by the handler function. This is similar to the designs we've

[COMMITTERS] pgsql: Remove dead code in pg_dump.

2016-01-17 Thread Tom Lane
Remove dead code in pg_dump. Coverity quite reasonably complained that this check for fout==NULL occurred after we'd already dereferenced fout. However, the check is just dead code since there is no code path by which CreateArchive can return a null pointer. Errors such as can't-open-that-file

[COMMITTERS] pgsql: Remove dead code in pg_dump.

2016-01-17 Thread Tom Lane
Remove dead code in pg_dump. Coverity quite reasonably complained that this check for fout==NULL occurred after we'd already dereferenced fout. However, the check is just dead code since there is no code path by which CreateArchive can return a null pointer. Errors such as can't-open-that-file