[COMMITTERS] pgsql: Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable

2016-02-10 Thread Noah Misch
Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable. Many automated test suites call pg_ctl. Buildfarm members axolotl, hornet, mandrill, shearwater, sungazer and tern have failed when server shutdown took longer than the pg_ctl default 60s timeout. This addition permits slow hosts

[COMMITTERS] pgsql: Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable

2016-02-10 Thread Noah Misch
Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable. Many automated test suites call pg_ctl. Buildfarm members axolotl, hornet, mandrill, shearwater, sungazer and tern have failed when server shutdown took longer than the pg_ctl default 60s timeout. This addition permits slow hosts

[COMMITTERS] pgsql: In pg_rewind test suite, triple promote timeout to 90s.

2016-02-10 Thread Noah Misch
In pg_rewind test suite, triple promote timeout to 90s. Thirty seconds was not consistently enough for promotion to complete on buildfarm members sungazer and tern. Experiments suggest 43s would have been enough. Back-patch to 9.5, where pg_rewind was introduced. Branch -- master Details -

[COMMITTERS] pgsql: In pg_rewind test suite, triple promote timeout to 90s.

2016-02-10 Thread Noah Misch
In pg_rewind test suite, triple promote timeout to 90s. Thirty seconds was not consistently enough for promotion to complete on buildfarm members sungazer and tern. Experiments suggest 43s would have been enough. Back-patch to 9.5, where pg_rewind was introduced. Branch -- REL9_5_STABLE De

[COMMITTERS] pgsql: Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable

2016-02-10 Thread Noah Misch
Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable. Many automated test suites call pg_ctl. Buildfarm members axolotl, hornet, mandrill, shearwater, sungazer and tern have failed when server shutdown took longer than the pg_ctl default 60s timeout. This addition permits slow hosts

[COMMITTERS] pgsql: Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable

2016-02-10 Thread Noah Misch
Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable. Many automated test suites call pg_ctl. Buildfarm members axolotl, hornet, mandrill, shearwater, sungazer and tern have failed when server shutdown took longer than the pg_ctl default 60s timeout. This addition permits slow hosts

[COMMITTERS] pgsql: Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable

2016-02-10 Thread Noah Misch
Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable. Many automated test suites call pg_ctl. Buildfarm members axolotl, hornet, mandrill, shearwater, sungazer and tern have failed when server shutdown took longer than the pg_ctl default 60s timeout. This addition permits slow hosts

[COMMITTERS] pgsql: Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable

2016-02-10 Thread Noah Misch
Accept pg_ctl timeout from the PGCTLTIMEOUT environment variable. Many automated test suites call pg_ctl. Buildfarm members axolotl, hornet, mandrill, shearwater, sungazer and tern have failed when server shutdown took longer than the pg_ctl default 60s timeout. This addition permits slow hosts

[COMMITTERS] pgsql: Avoid use of sscanf() to parse ispell dictionary files.

2016-02-10 Thread Tom Lane
Avoid use of sscanf() to parse ispell dictionary files. It turns out that on FreeBSD-derived platforms (including OS X), the *scanf() family of functions is pretty much brain-dead about multibyte characters. In particular it will apply isspace() to individual bytes of input even when those bytes

[COMMITTERS] pgsql: Avoid use of sscanf() to parse ispell dictionary files.

2016-02-10 Thread Tom Lane
Avoid use of sscanf() to parse ispell dictionary files. It turns out that on FreeBSD-derived platforms (including OS X), the *scanf() family of functions is pretty much brain-dead about multibyte characters. In particular it will apply isspace() to individual bytes of input even when those bytes

[COMMITTERS] pgsql: Avoid use of sscanf() to parse ispell dictionary files.

2016-02-10 Thread Tom Lane
Avoid use of sscanf() to parse ispell dictionary files. It turns out that on FreeBSD-derived platforms (including OS X), the *scanf() family of functions is pretty much brain-dead about multibyte characters. In particular it will apply isspace() to individual bytes of input even when those bytes

[COMMITTERS] pgsql: Avoid use of sscanf() to parse ispell dictionary files.

2016-02-10 Thread Tom Lane
Avoid use of sscanf() to parse ispell dictionary files. It turns out that on FreeBSD-derived platforms (including OS X), the *scanf() family of functions is pretty much brain-dead about multibyte characters. In particular it will apply isspace() to individual bytes of input even when those bytes

[COMMITTERS] pgsql: Avoid use of sscanf() to parse ispell dictionary files.

2016-02-10 Thread Tom Lane
Avoid use of sscanf() to parse ispell dictionary files. It turns out that on FreeBSD-derived platforms (including OS X), the *scanf() family of functions is pretty much brain-dead about multibyte characters. In particular it will apply isspace() to individual bytes of input even when those bytes

[COMMITTERS] pgsql: Avoid use of sscanf() to parse ispell dictionary files.

2016-02-10 Thread Tom Lane
Avoid use of sscanf() to parse ispell dictionary files. It turns out that on FreeBSD-derived platforms (including OS X), the *scanf() family of functions is pretty much brain-dead about multibyte characters. In particular it will apply isspace() to individual bytes of input even when those bytes

[COMMITTERS] pgsql: Revert "Temporarily make pg_ctl and server shutdown a whole lot

2016-02-10 Thread Tom Lane
Revert "Temporarily make pg_ctl and server shutdown a whole lot chattier." This reverts commit 3971f64843b02e4a55d854156bd53e46a0588e45 and a couple of followon debugging commits; I think we've learned what we can from them. Branch -- master Details --- http://git.postgresql.org/pg/commi

Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.

2016-02-10 Thread Heikki Linnakangas
On 10/02/16 17:12, Robert Haas wrote: Code cleanup in the wake of recent LWLock refactoring. As of commit c1772ad9225641c921545b35c84ee478c326b95e, there's no longer any way of requesting additional LWLocks in the main tranche, so we don't need NumLWLocks() or LWLockAssign() any more. Also, som

[COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.

2016-02-10 Thread Robert Haas
Code cleanup in the wake of recent LWLock refactoring. As of commit c1772ad9225641c921545b35c84ee478c326b95e, there's no longer any way of requesting additional LWLocks in the main tranche, so we don't need NumLWLocks() or LWLockAssign() any more. Also, some of the allocation counters that we had

[COMMITTERS] pgsql: postgres_fdw: Remove unnecessary variable.

2016-02-10 Thread Robert Haas
postgres_fdw: Remove unnecessary variable. It causes warnings in non-Assert-enabled builds. Per report from Jeff Janes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/019e78813760e664a85f505b5953d362a2b468cc Modified Files -- contrib/postgres_fdw/postg