[COMMITTERS] pgsql: Improve error reporting in format()

2016-02-11 Thread Teodor Sigaev
Improve error reporting in format() Clarify invalid format conversion type error message and add hint. Author: Jim Nasby Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/07d25a964b2fb78169a4a34c6f6893736f69903a Modified Files --

[COMMITTERS] pgsql: Shift the responsibility for emitting "database system is shut d

2016-02-11 Thread Tom Lane
Shift the responsibility for emitting "database system is shut down". Historically this message has been emitted at the end of ShutdownXLOG(). That's not an insane place for it in a standalone backend, but in the postmaster environment we've grown a fair amount of stuff that happens later,

[COMMITTERS] pgsql: Use separate lwlock tranches for buffer, lock, and predicate loc

2016-02-11 Thread Robert Haas
Use separate lwlock tranches for buffer, lock, and predicate lock managers. This finishes the work - spread across many commits over the last several months - of putting each type of lock other than the named individual locks into a separate tranche. Amit Kapila Branch -- master Details

[COMMITTERS] pgsql: Fix typo in comment.

2016-02-11 Thread Tom Lane
Fix typo in comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2564be360a1d25a4c66e7cd34997ab027e0ec9a8 Modified Files -- src/backend/optimizer/plan/planner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Rename PGPROC fields related to group XID clearing again.

2016-02-11 Thread Robert Haas
Rename PGPROC fields related to group XID clearing again. Commit 0e141c0fbb211bdd23783afa731e3eef95c9ad7a introduced a new facility to reduce ProcArrayLock contention by clearing several XIDs from the ProcArray under a single lock acquisition. The names initially chosen were deemed not to be

[COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution.

2016-02-11 Thread Robert Haas
Add some isolation tests for deadlock detection and resolution. Previously, we had no test coverage for the deadlock detector. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4c9864b9b4d87d02f07f40bb27976da737afdcab Modified Files --

Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution.

2016-02-11 Thread Tom Lane
Robert Haas writes: > Add some isolation tests for deadlock detection and resolution. Buildfarm says this needs work ... dromedary is one of mine, do you need me to look into what is happening? regards, tom lane -- Sent via pgsql-committers

[COMMITTERS] pgsql: Remove GROUP BY columns that are functionally dependent on other

2016-02-11 Thread Tom Lane
Remove GROUP BY columns that are functionally dependent on other columns. If a GROUP BY clause includes all columns of a non-deferred primary key, as well as other columns of the same relation, those other columns are redundant and can be dropped from the grouping; the pkey is enough to ensure

[COMMITTERS] pgsql: Move pg_constraint.h function declarations to new file pg_constr

2016-02-11 Thread Tom Lane
Move pg_constraint.h function declarations to new file pg_constraint_fn.h. A pending patch requires exporting a function returning Bitmapset from catalog/pg_constraint.c. As things stand, that would mean including nodes/bitmapset.h in pg_constraint.h, which might be hazardous for the client-side

[COMMITTERS] pgsql: Refactor check_functional_grouping() to use get_primary_key_attn

2016-02-11 Thread Tom Lane
Refactor check_functional_grouping() to use get_primary_key_attnos(). If we ever get around to allowing functional dependency to be proven from other things besides simple primary keys, this code will need to be rethought, but that was true anyway. In the meantime, we might as well not have two

[COMMITTERS] pgsql: Further tweaking of deadlock isolation tests.

2016-02-11 Thread Tom Lane
Further tweaking of deadlock isolation tests. The new deadlock-soft-2 test has a timing dependency too: it supposes that isolationtester will detect step s1b as waiting before the deadlock detector runs and grants it the lock. Adjust deadlock_timeout to ensure that that's true even in

[COMMITTERS] pgsql: Code review for isolationtester changes.

2016-02-11 Thread Tom Lane
Code review for isolationtester changes. Fix a few oversights in 38f8bdcac4982215beb9f65a19debecaf22fd470: don't leak memory in run_permutation(), remember when we've issued a cancel rather than issuing another one every 10ms, fix some typos in comments. Branch -- master Details ---

[COMMITTERS] pgsql: Make new deadlock isolation test more reproducible.

2016-02-11 Thread Tom Lane
Make new deadlock isolation test more reproducible. The original formulation of 4c9864b9b4d87d02f07f40bb27976da737afdcab was extremely timing-sensitive, because it arranged for the deadlock detector to be running (and possibly unblocking the current query) at almost exactly the same time as