[COMMITTERS] pgsql: logical decoding: fix decoding of a commit's commit time.

2016-03-02 Thread Andres Freund
logical decoding: fix decoding of a commit's commit time. When adding replication origins in 5aa235042, I somehow managed to set the timestamp of decoded transactions to InvalidXLogRecptr when decoding one made without a replication origin. Fix that, and the wrong type of the new commit_time varia

[COMMITTERS] pgsql: logical decoding: fix decoding of a commit's commit time.

2016-03-02 Thread Andres Freund
logical decoding: fix decoding of a commit's commit time. When adding replication origins in 5aa235042, I somehow managed to set the timestamp of decoded transactions to InvalidXLogRecptr when decoding one made without a replication origin. Fix that, and the wrong type of the new commit_time varia

[COMMITTERS] pgsql: Fix json_to_record() bug with nested objects.

2016-03-02 Thread Tom Lane
Fix json_to_record() bug with nested objects. A thinko concerning nesting depth caused json_to_record() to produce bogus output if a field of its input object contained a sub-object with a field name matching one of the requested output column names. Per bug #13996 from Johann Visagie. I added a

[COMMITTERS] pgsql: Fix json_to_record() bug with nested objects.

2016-03-02 Thread Tom Lane
Fix json_to_record() bug with nested objects. A thinko concerning nesting depth caused json_to_record() to produce bogus output if a field of its input object contained a sub-object with a field name matching one of the requested output column names. Per bug #13996 from Johann Visagie. I added a

[COMMITTERS] pgsql: Fix json_to_record() bug with nested objects.

2016-03-02 Thread Tom Lane
Fix json_to_record() bug with nested objects. A thinko concerning nesting depth caused json_to_record() to produce bogus output if a field of its input object contained a sub-object with a field name matching one of the requested output column names. Per bug #13996 from Johann Visagie. I added a

[COMMITTERS] pgsql: Create stub functions to support pg_upgrade of old contrib/tsear

2016-03-02 Thread Tom Lane
Create stub functions to support pg_upgrade of old contrib/tsearch2. Commits 9ff60273e35cad6e and dbe2328959e12701 adjusted the declarations of some core functions referenced by contrib/tsearch2's install script, forgetting that in a pg_upgrade situation, we'll be trying to restore operator class

[COMMITTERS] pgsql: Prefix temp data dirs with the node name

2016-03-02 Thread Alvaro Herrera
Prefix temp data dirs with the node name This makes it easier to relate the temporary data dirs to each node in a test script. Author: Kyotaro Horiguchi Reviewed-By: Craig Ringer, Alvaro Herrera Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cc6077d4d540d821548b704

[COMMITTERS] pgsql: Fix PL/Tcl's encoding conversion logic.

2016-03-02 Thread Tom Lane
Fix PL/Tcl's encoding conversion logic. PL/Tcl appears to contain logic to convert strings between the database encoding and UTF8, which is the only encoding modern Tcl will deal with. However, that code has been disabled since commit 034895125d648b86, which made it "#if defined(UNICODE_CONVERSION

[COMMITTERS] pgsql: Make PL/Tcl require Tcl 8.4 or later.

2016-03-02 Thread Tom Lane
Make PL/Tcl require Tcl 8.4 or later. As of commit 287822068246a6ae30bb2c7191de727672ae6328, PL/Tcl will not compile against pre-8.0 Tcl, whereas it used to work (more or less anyway) with quite prehistoric versions. As long as we're moving these goalposts, let's reinstall them at someplace that

[COMMITTERS] pgsql: Convert PL/Tcl to use Tcl's "object" interfaces.

2016-03-02 Thread Tom Lane
Convert PL/Tcl to use Tcl's "object" interfaces. The original implementation of Tcl was all strings, but they improved performance significantly by introducing typed "objects" (integers, lists, code, etc). It's past time we made use of that; that happened in Tcl 8.0 which was released in 1997. T