[COMMITTERS] pgsql: Remove a couple of useless pstrdup() calls.

2016-03-09 Thread Tom Lane
Remove a couple of useless pstrdup() calls. There's no point in pstrdup'ing the result of TextDatumGetCString, since that's necessarily already a freshly-palloc'd C string. These particular calls are unlikely to be of any consequence performance-wise, but still they're a bad precedent that can co

[COMMITTERS] pgsql: Avoid unlikely data-loss scenarios due to rename() without fsync

2016-03-09 Thread Andres Freund
Avoid unlikely data-loss scenarios due to rename() without fsync. Renaming a file using rename(2) is not guaranteed to be durable in face of crashes. Use the previously added durable_rename()/durable_link_or_rename() in various places where we previously just renamed files. Most of the changed ca

[COMMITTERS] pgsql: Avoid unlikely data-loss scenarios due to rename() without fsync

2016-03-09 Thread Andres Freund
Avoid unlikely data-loss scenarios due to rename() without fsync. Renaming a file using rename(2) is not guaranteed to be durable in face of crashes. Use the previously added durable_rename()/durable_link_or_rename() in various places where we previously just renamed files. Most of the changed ca

[COMMITTERS] pgsql: Introduce durable_rename() and durable_link_or_rename().

2016-03-09 Thread Andres Freund
Introduce durable_rename() and durable_link_or_rename(). Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in

[COMMITTERS] pgsql: Avoid unlikely data-loss scenarios due to rename() without fsync

2016-03-09 Thread Andres Freund
Avoid unlikely data-loss scenarios due to rename() without fsync. Renaming a file using rename(2) is not guaranteed to be durable in face of crashes. Use the previously added durable_rename()/durable_link_or_rename() in various places where we previously just renamed files. Most of the changed ca

[COMMITTERS] pgsql: Avoid unlikely data-loss scenarios due to rename() without fsync

2016-03-09 Thread Andres Freund
Avoid unlikely data-loss scenarios due to rename() without fsync. Renaming a file using rename(2) is not guaranteed to be durable in face of crashes. Use the previously added durable_rename()/durable_link_or_rename() in various places where we previously just renamed files. Most of the changed ca

[COMMITTERS] pgsql: Avoid unlikely data-loss scenarios due to rename() without fsync

2016-03-09 Thread Andres Freund
Avoid unlikely data-loss scenarios due to rename() without fsync. Renaming a file using rename(2) is not guaranteed to be durable in face of crashes. Use the previously added durable_rename()/durable_link_or_rename() in various places where we previously just renamed files. Most of the changed ca

[COMMITTERS] pgsql: Introduce durable_rename() and durable_link_or_rename().

2016-03-09 Thread Andres Freund
Introduce durable_rename() and durable_link_or_rename(). Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in

[COMMITTERS] pgsql: Avoid unlikely data-loss scenarios due to rename() without fsync

2016-03-09 Thread Andres Freund
Avoid unlikely data-loss scenarios due to rename() without fsync. Renaming a file using rename(2) is not guaranteed to be durable in face of crashes. Use the previously added durable_rename()/durable_link_or_rename() in various places where we previously just renamed files. Most of the changed ca

[COMMITTERS] pgsql: Introduce durable_rename() and durable_link_or_rename().

2016-03-09 Thread Andres Freund
Introduce durable_rename() and durable_link_or_rename(). Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in

[COMMITTERS] pgsql: Introduce durable_rename() and durable_link_or_rename().

2016-03-09 Thread Andres Freund
Introduce durable_rename() and durable_link_or_rename(). Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in

[COMMITTERS] pgsql: Introduce durable_rename() and durable_link_or_rename().

2016-03-09 Thread Andres Freund
Introduce durable_rename() and durable_link_or_rename(). Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in

[COMMITTERS] pgsql: Introduce durable_rename() and durable_link_or_rename().

2016-03-09 Thread Andres Freund
Introduce durable_rename() and durable_link_or_rename(). Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in

[COMMITTERS] pgsql: doc: Reorganize pg_resetxlog reference page

2016-03-09 Thread Peter Eisentraut
doc: Reorganize pg_resetxlog reference page The pg_resetxlog reference page didn't have a proper options list, only running text listing the options and some explanations of them. This might have worked when there were only a few options, but the list has grown over the releases, and now it's har

[COMMITTERS] pgsql: PostgresNode: add backup_fs_hot and backup_fs_cold

2016-03-09 Thread Alvaro Herrera
PostgresNode: add backup_fs_hot and backup_fs_cold These simple methods rely on RecursiveCopy to create a filesystem-level backup of a server. They aren't currently used anywhere yet,but will be useful for future tests. Author: Craig Ringer Reviewed-By: Michael Paquier, Salvador Fandino, Álvaro

[COMMITTERS] pgsql: Add filter capability to RecursiveCopy::copypath

2016-03-09 Thread Alvaro Herrera
Add filter capability to RecursiveCopy::copypath This allows skipping copying certain files and subdirectories in tests. This is useful in some circumstances such as copying a data directory; future tests want this feature. Also POD-ify the module. Authors: Craig Ringer, Pallavi Sontakke Reviewe

[COMMITTERS] pgsql: Fix incorrect handling of NULL index entries in indexed ROW() co

2016-03-09 Thread Tom Lane
Fix incorrect handling of NULL index entries in indexed ROW() comparisons. An index search using a row comparison such as ROW(a, b) > ROW('x', 'y') would stop upon reaching a NULL entry in the "b" column, ignoring the fact that there might be non-NULL "b" values associated with later values of "a"

[COMMITTERS] pgsql: Fix incorrect handling of NULL index entries in indexed ROW() co

2016-03-09 Thread Tom Lane
Fix incorrect handling of NULL index entries in indexed ROW() comparisons. An index search using a row comparison such as ROW(a, b) > ROW('x', 'y') would stop upon reaching a NULL entry in the "b" column, ignoring the fact that there might be non-NULL "b" values associated with later values of "a"

[COMMITTERS] pgsql: Fix incorrect handling of NULL index entries in indexed ROW() co

2016-03-09 Thread Tom Lane
Fix incorrect handling of NULL index entries in indexed ROW() comparisons. An index search using a row comparison such as ROW(a, b) > ROW('x', 'y') would stop upon reaching a NULL entry in the "b" column, ignoring the fact that there might be non-NULL "b" values associated with later values of "a"

[COMMITTERS] pgsql: Fix incorrect handling of NULL index entries in indexed ROW() co

2016-03-09 Thread Tom Lane
Fix incorrect handling of NULL index entries in indexed ROW() comparisons. An index search using a row comparison such as ROW(a, b) > ROW('x', 'y') would stop upon reaching a NULL entry in the "b" column, ignoring the fact that there might be non-NULL "b" values associated with later values of "a"

[COMMITTERS] pgsql: Fix incorrect handling of NULL index entries in indexed ROW() co

2016-03-09 Thread Tom Lane
Fix incorrect handling of NULL index entries in indexed ROW() comparisons. An index search using a row comparison such as ROW(a, b) > ROW('x', 'y') would stop upon reaching a NULL entry in the "b" column, ignoring the fact that there might be non-NULL "b" values associated with later values of "a"

[COMMITTERS] pgsql: Fix incorrect handling of NULL index entries in indexed ROW() co

2016-03-09 Thread Tom Lane
Fix incorrect handling of NULL index entries in indexed ROW() comparisons. An index search using a row comparison such as ROW(a, b) > ROW('x', 'y') would stop upon reaching a NULL entry in the "b" column, ignoring the fact that there might be non-NULL "b" values associated with later values of "a"

[COMMITTERS] pgsql: Re-pgindent vacuumlazy.c.

2016-03-09 Thread Robert Haas
Re-pgindent vacuumlazy.c. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/be060cbcd42737693f6fd425db4c139121181cce Modified Files -- src/backend/commands/vacuumlazy.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) -- Se

[COMMITTERS] pgsql: pgbench: When -T is used, don't wait for transactions beyond end

2016-03-09 Thread Robert Haas
pgbench: When -T is used, don't wait for transactions beyond end of run. At low rates, this can lead to pgbench taking significantly longer to terminate than the user might expect. Repair. Fabien Coelho, reviewed by Aleksander Alekseev, Álvaro Herrera, and me. Branch -- master Details

[COMMITTERS] pgsql: pgcrypto: support changing S2K iteration count

2016-03-09 Thread Alvaro Herrera
pgcrypto: support changing S2K iteration count pgcrypto already supports key-stretching during symmetric encryption, including the salted-and-iterated method; but the number of iterations was not configurable. This commit implements a new s2k-count parameter to pgp_sym_encrypt() which permits sel

[COMMITTERS] pgsql: Add a generic command progress reporting facility.

2016-03-09 Thread Robert Haas
Add a generic command progress reporting facility. Using this facility, any utility command can report the target relation upon which it is operating, if there is one, and up to 10 64-bit counters; the intent of this is that users should be able to figure out what a utility command is doing withou

[COMMITTERS] pgsql: Fix incorrect tlist generation in create_gather_plan().

2016-03-09 Thread Tom Lane
Fix incorrect tlist generation in create_gather_plan(). This function is written as though Gather doesn't project; but it does. Even if it did not project, though, we must use build_path_tlist to ensure that the output columns receive correct sortgroupref labeling. Per report from Amit Kapila. B

[COMMITTERS] pgsql: postgres_fdw: Consider foreign joining and foreign sorting toget

2016-03-09 Thread Robert Haas
postgres_fdw: Consider foreign joining and foreign sorting together. Commit ccd8f97922944566d26c7d90eb67ab7848ee9905 gave us the ability to request that the remote side sort the data, and, later, commit e4106b2528727c4b48639c0e12bf2f70a766b910 gave us the ability to request that the remote side pe

[COMMITTERS] pgsql: Fix copy-and-pasteo in comment.

2016-03-09 Thread Tom Lane
Fix copy-and-pasteo in comment. Wensheng Zhang Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d31f20e2b5a246f276c73134b610ac7a2f34e274 Modified Files -- src/backend/parser/gram.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-