[COMMITTERS] pgsql: Further minor improvement in generic_xlog.c: always say REGBUF_S

Further minor improvement in generic_xlog.c: always say REGBUF_STANDARD. Since we're requiring pages handled by generic_xlog.c to be standard format, specify REGBUF_STANDARD when doing a full-page image, so that xloginsert.c can compress out the "hole" between pd_lower and pd_upper. Given the curr

[COMMITTERS] pgsql: Micro-optimize GenericXLogFinish().

Micro-optimize GenericXLogFinish(). Make the inner comparison loops of computeDelta() as tight as possible by pulling considerations of valid and invalid ranges out of the inner loops, and extending a match or non-match detection as far as possible before deciding what to do next. To keep this tr

[COMMITTERS] pgsql: Fix PL/Python ereport() test to work on Python 2.3.

Fix PL/Python ereport() test to work on Python 2.3. Per buildfarm. Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c7a141a9866b8c15d9e3b6fd5310e54837900394 Modified Files -- src/pl/plpython/expected/plpython_test.out | 24 ++---

[COMMITTERS] pgsql: Get rid of GenericXLogUnregister().

Get rid of GenericXLogUnregister(). This routine is unsafe as implemented, because it invalidates the page image pointers returned by previous GenericXLogRegister() calls. Rather than complicate the API or the implementation to avoid that, let's just get rid of it; the use-case for having it seem

[COMMITTERS] pgsql: Get rid of blinsert()'s use of GenericXLogUnregister().

Get rid of blinsert()'s use of GenericXLogUnregister(). That routine is dangerous, and unnecessary once we get rid of this one caller. In passing, fix failure to clean up temp memory context, or switch back to caller's context, during slowest exit path. Branch -- master Details --- http

[COMMITTERS] pgsql: Code review/prettification for generic_xlog.c.

Code review/prettification for generic_xlog.c. Improve commentary, use more specific names for the delta fields, const-ify pointer arguments where possible, avoid assuming that initializing only the first element of a local array will guarantee that the remaining elements end up as we need them.

[COMMITTERS] pgsql: Run pgindent on generic_xlog.c.

Run pgindent on generic_xlog.c. This code desperately needs some micro-optimization, and I'd like it to be formatted a bit more nicely while I work on it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2dd318d277b8e1d8269b030f545240193943162f Modified Files ---

Re: [COMMITTERS] pgsql: Turn special page pointer validation to static inline function

On 04/09/2016 09:19 AM, Kevin Grittner wrote: Turn special page pointer validation to static inline function Inclusion of multiple macros inside another macro was pushing MSVC past its size liimit. Reported by buildfarm. FTR, not only MSVC. pademelon is an HP-UX box running the HP compil

[COMMITTERS] pgsql: Fix typo in C comment.

Fix typo in C comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/381200be4b565292eba6f62200248cb775f06940 Modified Files -- src/include/storage/bufpage.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-committers ma

[COMMITTERS] pgsql: Turn special page pointer validation to static inline function

Turn special page pointer validation to static inline function Inclusion of multiple macros inside another macro was pushing MSVC past its size liimit. Reported by buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/56dffb5a73ab157fc8d35a76c1170d656a051f14 M