Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

Alvaro Herrera writes: > Peter Geoghegan wrote: >> What does this mean? >> >> + /* XXX broken */ >> if (attno < 0) >> elog(ERROR, "system column in index"); > My guess is that it means we do support indexes in system columns (oid > in particular) and that

[COMMITTERS] pgsql: Fix infer_arbiter_indexes() to not barf on system columns.

Fix infer_arbiter_indexes() to not barf on system columns. While it could be argued that rejecting system column mentions in the ON CONFLICT list is an unsupported feature, falling over altogether just because the table has a unique index on OID is indubitably a bug. As far as I can tell, fixing

[COMMITTERS] pgsql: Fix infer_arbiter_indexes() to not barf on system columns.

Fix infer_arbiter_indexes() to not barf on system columns. While it could be argued that rejecting system column mentions in the ON CONFLICT list is an unsupported feature, falling over altogether just because the table has a unique index on OID is indubitably a bug. As far as I can tell, fixing

Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

On Wed, May 11, 2016 at 1:54 PM, Alvaro Herrera wrote: > My guess is that it means we do support indexes in system columns (oid > in particular) and that instead of an ugly error this should do > something else. Maybe silently ignore the index. Why ignore the index?

Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

Peter Geoghegan wrote: > On Wed, May 11, 2016 at 1:20 PM, Tom Lane wrote: > > Fix assorted missing infrastructure for ON CONFLICT. > > What does this mean? > > + /* XXX broken */ > if (attno < 0) > elog(ERROR, "system column in index");

Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

On Wed, May 11, 2016 at 1:20 PM, Tom Lane wrote: > Fix assorted missing infrastructure for ON CONFLICT. What does this mean? + /* XXX broken */ if (attno < 0) elog(ERROR, "system column in index"); -- Peter Geoghegan -- Sent via

[COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

Fix assorted missing infrastructure for ON CONFLICT. subquery_planner() failed to apply expression preprocessing to the arbiterElems and arbiterWhere fields of an OnConflictExpr. No doubt the theory was that this wasn't necessary because we don't actually try to execute those expressions; but

[COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

Fix assorted missing infrastructure for ON CONFLICT. subquery_planner() failed to apply expression preprocessing to the arbiterElems and arbiterWhere fields of an OnConflictExpr. No doubt the theory was that this wasn't necessary because we don't actually try to execute those expressions; but

[COMMITTERS] pgsql: Update key words table for 9.6

Update key words table for 9.6 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9be58a2b8ef222c1de80ccbb55b19ab0cff33237 Modified Files -- doc/src/sgml/keywords.sgml | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) -- Sent via