[COMMITTERS] pgsql: Fix hard to hit race condition in heapam's tuple locking code.

2016-08-04 Thread Andres Freund
Fix hard to hit race condition in heapam's tuple locking code. As mentioned in its commit message, eca0f1db left open a race condition, where a page could be marked all-visible, after the code checked PageIsAllVisible() to pin the VM, but before the page is locked. Plug that hole. Reviewed-By: R

Re: [COMMITTERS] pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu

2016-08-04 Thread Robert Haas
On Thu, Aug 4, 2016 at 7:23 PM, Tom Lane wrote: > Robert Haas writes: >> Prevent "snapshot too old" from trying to return pruned TOAST tuples. > > Looks like this patch broke the build on castoroides. Recommend > changing InitToastSnapshot into a macro. (There's a reason why > InitDirtySnapshot

Re: [COMMITTERS] pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu

2016-08-04 Thread Tom Lane
Robert Haas writes: > Prevent "snapshot too old" from trying to return pruned TOAST tuples. Looks like this patch broke the build on castoroides. Recommend changing InitToastSnapshot into a macro. (There's a reason why InitDirtySnapshot is a macro.) regards, tom lane

[COMMITTERS] pgsql: docs: mention rsync of temp and unlogged tables

2016-08-04 Thread Bruce Momjian
docs: mention rsync of temp and unlogged tables This happens when using rsync to pg_upgrade slaves. Reported-by: Jerry Sievers Discussion: [email protected] Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4eb4b3f24561cb115b24984c755b2a75155afedf Mo

[COMMITTERS] pgsql: Fix bogus coding in WaitForBackgroundWorkerShutdown().

2016-08-04 Thread Tom Lane
Fix bogus coding in WaitForBackgroundWorkerShutdown(). Some conditions resulted in "return" directly out of a PG_TRY block, which left the exception stack dangling, and to add insult to injury failed to restore the state of set_latch_on_sigusr1. This is a bug only in 9.5; in HEAD it was accidenta

[COMMITTERS] pgsql: Fix bogus coding in WaitForBackgroundWorkerShutdown().

2016-08-04 Thread Tom Lane
Fix bogus coding in WaitForBackgroundWorkerShutdown(). Some conditions resulted in "return" directly out of a PG_TRY block, which left the exception stack dangling, and to add insult to injury failed to restore the state of set_latch_on_sigusr1. This is a bug only in 9.5; in HEAD it was accidenta