[COMMITTERS] pgsql: Fix typo in comment.

2016-09-22 Thread Heikki Linnakangas
Fix typo in comment. Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/674e2de64d66b3a1e261bf07825be54c7cd2f3f6 Modified Files -- src/interfaces/libpq/libpq-int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: C comment: fix function header comment

2016-09-22 Thread Bruce Momjian
C comment: fix function header comment Fix for transformOnConflictClause(). Author: Tomonari Katsumata Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1ff0042165cf835d1b6a2ab2c3b84c201eb6577b Modified Files -- src/backend/parser/analyze.c | 2 +- 1 file

[COMMITTERS] pgsql: Remove nearly-unused SizeOfIptrData macro.

2016-09-22 Thread Tom Lane
Remove nearly-unused SizeOfIptrData macro. Past refactorings have removed all but one reference to SizeOfIptrData (and that one place was in a pretty noncritical spot). Since nobody's complained, it seems probable that there are no supported compilers that don't think sizeof(ItemPointerData) is 6

[COMMITTERS] Re: pgsql: Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use i

2016-09-22 Thread Andrew Borodin
2016-09-22 23:11 GMT+05:00 Tom Lane : > Yeah, I explained it in part of the commit message you didn't quote: Oh.. sorry, my bad. Focused on code and missed whole thing. > Note that this patch causes a rather subtle WAL incompatibility: the > physical page content change represented by cer

Re: [COMMITTERS] pgsql: Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use i

2016-09-22 Thread Tom Lane
Andrew Borodin writes: > 2016-09-10 3:02 GMT+05:00 Tom Lane : >> Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use it. > This commit changes shape of WAL records of GiST and BRIN, but does > not bump XLOG_PAGE_MAGIC. Is it for a reason? Yeah, I explained it in part of the commit mes

[COMMITTERS] Re: pgsql: Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use i

2016-09-22 Thread Andrew Borodin
Hello! 2016-09-10 3:02 GMT+05:00 Tom Lane : > Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use it. > > Discussion: > > > Details > --- > http://git.postgresql.org/pg/commitdiff/b1328d78f88cdf4f7504004159e530b776f0de16 > > Modified Files > -- > src/backend/access/br

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Be sure to rewind the tuplestore read pointer in non-leader CTES

2016-09-22 Thread Tom Lane
Be sure to rewind the tuplestore read pointer in non-leader CTEScan nodes. ExecInitCteScan supposed that it didn't have to do anything to the extra tuplestore read pointer it gets from tuplestore_alloc_read_pointer. However, it needs this read pointer to be positioned at the start of the tuplestor

[COMMITTERS] pgsql: Add tests for various connection string issues

2016-09-22 Thread Peter Eisentraut
Add tests for various connection string issues Add tests for consistent support of connection strings in frontend programs as well as proper handling of unusual characters in database and user names. These tests were developed for the issues of CVE-2016-5424. To allow testing of names with space