[COMMITTERS] pgsql: Set log_line_prefix and application name in test drivers

2016-09-30 Thread Peter Eisentraut
Set log_line_prefix and application name in test drivers Before pg_regress runs psql, set the application name to the test name. Similarly, set the application name to the test file name in the TAP tests. Also, set a default log_line_prefix that show the application name, as well as the PID and a

[COMMITTERS] pgsql: Improve error reporting in pg_upgrade's file copying/linking/rew

2016-09-30 Thread Tom Lane
Improve error reporting in pg_upgrade's file copying/linking/rewriting. The previous design for this had copyFile(), linkFile(), and rewriteVisibilityMap() returning strerror strings, with the caller producing one-size-fits-all error messages based on that. This made it impossible to produce mess

[COMMITTERS] pgsql: Fix multiple portability issues in pg_upgrade's rewriteVisibilit

2016-09-30 Thread Tom Lane
Fix multiple portability issues in pg_upgrade's rewriteVisibilityMap(). This is new code in 9.6, and evidently we missed out testing it as thoroughly as it should have been. Bugs fixed here: 1. Use binary not text mode to open the files on Windows. Before, if the visibility map chanced to conta

[COMMITTERS] pgsql: Fix multiple portability issues in pg_upgrade's rewriteVisibilit

2016-09-30 Thread Tom Lane
Fix multiple portability issues in pg_upgrade's rewriteVisibilityMap(). This is new code in 9.6, and evidently we missed out testing it as thoroughly as it should have been. Bugs fixed here: 1. Use binary not text mode to open the files on Windows. Before, if the visibility map chanced to conta

[COMMITTERS] pgsql: Improve error reporting in pg_upgrade's file copying/linking/rew

2016-09-30 Thread Tom Lane
Improve error reporting in pg_upgrade's file copying/linking/rewriting. The previous design for this had copyFile(), linkFile(), and rewriteVisibilityMap() returning strerror strings, with the caller producing one-size-fits-all error messages based on that. This made it impossible to produce mess

Re: [COMMITTERS] pgsql: Separate enum from struct

2016-09-30 Thread Peter Eisentraut
On 9/30/16 3:20 PM, Stephen Frost wrote: > Peter, > > * Peter Eisentraut ([email protected]) wrote: >> Separate enum from struct >> >> Otherwise the enum symbols are not visible outside the struct in C++. >> >> Reviewed-by: Thomas Munro > > Looks like this upset the buildfarm pretty badly... Yup,

[COMMITTERS] pgsql: Fix breakage in previous change

2016-09-30 Thread Peter Eisentraut
Fix breakage in previous change Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cd03890d0b5d9cbcfca169195d71f1693f84cafa Modified Files -- src/include/utils/jsonb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers maili

Re: [COMMITTERS] pgsql: Separate enum from struct

2016-09-30 Thread Stephen Frost
Peter, * Peter Eisentraut ([email protected]) wrote: > Separate enum from struct > > Otherwise the enum symbols are not visible outside the struct in C++. > > Reviewed-by: Thomas Munro Looks like this upset the buildfarm pretty badly... Thanks! Stephen signature.asc Description: Digital sign

[COMMITTERS] pgsql: Separate enum from struct

2016-09-30 Thread Peter Eisentraut
Separate enum from struct Otherwise the enum symbols are not visible outside the struct in C++. Reviewed-by: Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/330b48b94b53bcbbc490f952d6798d5ab637721a Modified Files -- src/include/utils/jsonb

[COMMITTERS] pgsql: Remove unnecessary prototypes

2016-09-30 Thread Peter Eisentraut
Remove unnecessary prototypes Prototypes for functions implementing V1-callable functions are no longer necessary. Reviewed-by: Heikki Linnakangas Reviewed-by: Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0665023b4435a469e42289d7065c436967a022b6 M

[COMMITTERS] pgsql: Use return instead of exit() in configure

2016-09-30 Thread Peter Eisentraut
Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). Reviewed-by: Heikki Linnakangas Reviewed-by: Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1c0cf5

[COMMITTERS] pgsql: Add missing include files to configure tests

2016-09-30 Thread Peter Eisentraut
Add missing include files to configure tests atoi() needs stdlib.h strcmp() needs string.h Reviewed-by: Heikki Linnakangas Reviewed-by: Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a5da81359dbddfee49ea7800b43d99c204b4d31f Modified Files --

[COMMITTERS] pgsql: Fix use of offsetof()

2016-09-30 Thread Peter Eisentraut
Fix use of offsetof() Using offsetof() with a run-time computed argument is not allowed in either C or C++. Apparently, gcc allows it, but g++ doesn't. Reviewed-by: Heikki Linnakangas Reviewed-by: Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f1a46

[COMMITTERS] pgsql: Retry opening new segments in pg_xlogdump --folllow

2016-09-30 Thread Magnus Hagander
Retry opening new segments in pg_xlogdump --folllow There is a small window between when the server closes out the existing segment and the new one is created. Put a loop around the open call in this case to make sure we wait for the new file to actually appear. Branch -- REL9_6_STABLE Detai

[COMMITTERS] pgsql: Retry opening new segments in pg_xlogdump --folllow

2016-09-30 Thread Magnus Hagander
Retry opening new segments in pg_xlogdump --folllow There is a small window between when the server closes out the existing segment and the new one is created. Put a loop around the open call in this case to make sure we wait for the new file to actually appear. Branch -- REL9_4_STABLE Detai

[COMMITTERS] pgsql: Retry opening new segments in pg_xlogdump --folllow

2016-09-30 Thread Magnus Hagander
Retry opening new segments in pg_xlogdump --folllow There is a small window between when the server closes out the existing segment and the new one is created. Put a loop around the open call in this case to make sure we wait for the new file to actually appear. Branch -- REL9_5_STABLE Detai

[COMMITTERS] pgsql: Retry opening new segments in pg_xlogdump --folllow

2016-09-30 Thread Magnus Hagander
Retry opening new segments in pg_xlogdump --folllow There is a small window between when the server closes out the existing segment and the new one is created. Put a loop around the open call in this case to make sure we wait for the new file to actually appear. Branch -- REL9_3_STABLE Detai

[COMMITTERS] pgsql: Retry opening new segments in pg_xlogdump --folllow

2016-09-30 Thread Magnus Hagander
Retry opening new segments in pg_xlogdump --folllow There is a small window between when the server closes out the existing segment and the new one is created. Put a loop around the open call in this case to make sure we wait for the new file to actually appear. Branch -- master Details