[COMMITTERS] pgsql: Avoid using a C++ keyword in header file

2016-10-26 Thread Peter Eisentraut
Avoid using a C++ keyword in header file per cpluspluscheck Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c32fe432afd4bc428acf4a237f911271746f689f Modified Files -- src/backend/executor/execGrouping.c | 6 +++--- src/include/lib/simplehash.h| 2

Re: [COMMITTERS] pgsql: Properly indent postgresql.conf comments to align

2016-10-26 Thread Tom Lane
Bruce Momjian writes: > Properly indent postgresql.conf comments to align I think "properly" here is very dependent on what you believe the tab width is. While most of us have our editors set up for 4-space tabs in C files, I don't think all contributors do so for text files (I don't, for one).

[COMMITTERS] pgsql: Properly indent postgresql.conf comments to align

2016-10-26 Thread Bruce Momjian
Properly indent postgresql.conf comments to align A few comments were misaligned. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/586a46c22cea1526995195283fee0521fc6674b8 Modified Files -- src/backend/utils/misc/postgresql.conf.sample | 8 1 file

[COMMITTERS] pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT.

2016-10-26 Thread Tom Lane
Fix incorrect trigger-property updating in ALTER CONSTRAINT. The code to change the deferrability properties of a foreign-key constraint updated all the associated triggers to match; but a moment's examination of the code that creates those triggers in the first place shows that only some of them

[COMMITTERS] pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT.

2016-10-26 Thread Tom Lane
Fix incorrect trigger-property updating in ALTER CONSTRAINT. The code to change the deferrability properties of a foreign-key constraint updated all the associated triggers to match; but a moment's examination of the code that creates those triggers in the first place shows that only some of them

[COMMITTERS] pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT.

2016-10-26 Thread Tom Lane
Fix incorrect trigger-property updating in ALTER CONSTRAINT. The code to change the deferrability properties of a foreign-key constraint updated all the associated triggers to match; but a moment's examination of the code that creates those triggers in the first place shows that only some of them

[COMMITTERS] pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT.

2016-10-26 Thread Tom Lane
Fix incorrect trigger-property updating in ALTER CONSTRAINT. The code to change the deferrability properties of a foreign-key constraint updated all the associated triggers to match; but a moment's examination of the code that creates those triggers in the first place shows that only some of them

[COMMITTERS] pgsql: Fix not-HAVE_SYMLINK code in zic.c.

2016-10-26 Thread Tom Lane
Fix not-HAVE_SYMLINK code in zic.c. I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard agains

[COMMITTERS] pgsql: Fix not-HAVE_SYMLINK code in zic.c.

2016-10-26 Thread Tom Lane
Fix not-HAVE_SYMLINK code in zic.c. I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard agains

[COMMITTERS] pgsql: Fix not-HAVE_SYMLINK code in zic.c.

2016-10-26 Thread Tom Lane
Fix not-HAVE_SYMLINK code in zic.c. I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard agains

[COMMITTERS] pgsql: Fix not-HAVE_SYMLINK code in zic.c.

2016-10-26 Thread Tom Lane
Fix not-HAVE_SYMLINK code in zic.c. I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard agains

[COMMITTERS] pgsql: Fix not-HAVE_SYMLINK code in zic.c.

2016-10-26 Thread Tom Lane
Fix not-HAVE_SYMLINK code in zic.c. I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard agains

[COMMITTERS] pgsql: Fix not-HAVE_SYMLINK code in zic.c.

2016-10-26 Thread Tom Lane
Fix not-HAVE_SYMLINK code in zic.c. I broke this in commit f3094920a. Apparently it's dead code anyway, at least as far as our buildfarm is concerned (and the upstream IANA code doesn't worry at all about symlink() not being present). But as long as the rest of our code is willing to guard agains

[COMMITTERS] pgsql: Doc: improve documentation about inheritance.

2016-10-26 Thread Tom Lane
Doc: improve documentation about inheritance. Clarify documentation about inheritance of check constraints, in particular mentioning the NO INHERIT option, which didn't exist when this text was written. Document that in an inherited query, the applicable row security policies are those of the exp

[COMMITTERS] pgsql: Doc: improve documentation about inheritance.

2016-10-26 Thread Tom Lane
Doc: improve documentation about inheritance. Clarify documentation about inheritance of check constraints, in particular mentioning the NO INHERIT option, which didn't exist when this text was written. Document that in an inherited query, the applicable row security policies are those of the exp

[COMMITTERS] pgsql: Doc: improve documentation about inheritance.

2016-10-26 Thread Tom Lane
Doc: improve documentation about inheritance. Clarify documentation about inheritance of check constraints, in particular mentioning the NO INHERIT option, which didn't exist when this text was written. Document that in an inherited query, the applicable row security policies are those of the exp

[COMMITTERS] pgsql: Suppress unused-variable warning in non-assert builds.

2016-10-26 Thread Tom Lane
Suppress unused-variable warning in non-assert builds. Introduced in commit 7012b132d. Kyotaro Horiguchi Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8529686ccbb9f1c2fe350920ad324c223135a957 Modified Files -- contrib/postgres_fdw/deparse.c | 3 +-- 1

[COMMITTERS] pgsql: Remove platform-dependent PL/python test case.

2016-10-26 Thread Heikki Linnakangas
Remove platform-dependent PL/python test case. Turns out that the output format of Python Decimal isn't totally platform- independent either. There are other tests for multi-dimensional arrays, so rather than try to fix this test case, just remove it. Per buildfarm member prairiedog. Branch

Re: [COMMITTERS] pgsql: Avoid using platform-dependent floats in test case.

2016-10-26 Thread Heikki Linnakangas
On 10/26/2016 04:42 PM, Tom Lane wrote: Heikki Linnakangas writes: Avoid using platform-dependent floats in test case. The number of decimals printed for floats varied in this test case, as noted by several buildfarm members. There's nothing special about floats and arrays in the code being tes

Re: [COMMITTERS] pgsql: Avoid using platform-dependent floats in test case.

2016-10-26 Thread Tom Lane
Heikki Linnakangas writes: > Avoid using platform-dependent floats in test case. > The number of decimals printed for floats varied in this test case, as > noted by several buildfarm members. There's nothing special about floats > and arrays in the code being tested, so replace the floats with num

[COMMITTERS] pgsql: Only treat Python Lists as array dimensions.

2016-10-26 Thread Heikki Linnakangas
Only treat Python Lists as array dimensions. Instead of treating all python sequence types as array dimensions, except for tuples and various kinds of strings, only treat Python lists as dimensions. The PyBytes_Check() function used previously is only available on Python 2.6 and newer, and it was

[COMMITTERS] pgsql: Avoid using platform-dependent floats in test case.

2016-10-26 Thread Heikki Linnakangas
Avoid using platform-dependent floats in test case. The number of decimals printed for floats varied in this test case, as noted by several buildfarm members. There's nothing special about floats and arrays in the code being tested, so replace the floats with numerics to make the output platform-i

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-26 Thread Dave Page
On Tue, Oct 25, 2016 at 10:22 PM, Andrew Dunstan wrote: > > > On 10/25/2016 10:26 AM, Dave Page wrote: >> >> >> OK, I think I got the perl stuff right - running test builds now. >> > > > Ping me if you need help. Thanks - looks like I got it though, they're all green again :-) -- Dave Page Post

[COMMITTERS] pgsql: Fix regression test to also work with Python 2.

2016-10-26 Thread Heikki Linnakangas
Fix regression test to also work with Python 2. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e131ba4fe58123ce5726c1405486913b429c068c Modified Files -- src/pl/plpython/expected/plpython_composite.out | 2 +- 1 file changed, 1 insertion(+

[COMMITTERS] pgsql: Fix typos in comments.

2016-10-26 Thread Heikki Linnakangas
Fix typos in comments. Vinayak Pokale Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/56f39009c53e752493ca4478449a1311865dd51a Modified Files -- src/backend/postmaster/pgstat.c | 2 +- src/backend/replication/logical/reorderbuffer.c | 2 +-

[COMMITTERS] pgsql: Fix typo in comment.

2016-10-26 Thread Heikki Linnakangas
Fix typo in comment. Daniel Gustafsson Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e3c5e48bb82975cfca4c90a30fd8e2452840909d Modified Files -- contrib/pageinspect/heapfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via p

[COMMITTERS] pgsql: Fix typo in comment.

2016-10-26 Thread Heikki Linnakangas
Fix typo in comment. Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8a2f08fbeaf75f67da122b49f05f96257df3faed Modified Files -- contrib/pageinspect/heapfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-co

[COMMITTERS] pgsql: Fix typos in comments.

2016-10-26 Thread Heikki Linnakangas
Fix typos in comments. Vinayak Pokale Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e9c0335c3306f7737c7b3fc0cf0c36ff19397e19 Modified Files -- src/backend/postmaster/pgstat.c | 2 +- src/backend/replication/logical/reorderbuffer.c

[COMMITTERS] pgsql: Give a hint, when [] is incorrectly used for a composite type in

2016-10-26 Thread Heikki Linnakangas
Give a hint, when [] is incorrectly used for a composite type in array. That used to be accepted, so let's try to give a hint to users on why their PL/python functions no longer work. Reviewed by Pavel Stehule. Discussion: Branch -- master Details --- http://git.postgresql.org/pg/comm

[COMMITTERS] pgsql: Support multi-dimensional arrays in PL/python.

2016-10-26 Thread Heikki Linnakangas
Support multi-dimensional arrays in PL/python. Multi-dimensional arrays can now be used as arguments to a PL/python function (used to throw an error), and they can be returned as nested Python lists. This makes a backwards-incompatible change to the handling of composite types in arrays. Previous