Re: [COMMITTERS] pgsql: Fix bugs in RelationGetPartitionDispatchInfo.

2016-12-13 Thread Amit Langote
Hi Alexander, On 2016/12/14 15:18, Alexander Korotkov wrote: > Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with > only difference of variables naming and comments [2]. But he is not > mentioned in commit message. That doesn't look fine. I apologize for my part in failing

Re: [COMMITTERS] pgsql: Fix bugs in RelationGetPartitionDispatchInfo.

2016-12-13 Thread Robert Haas
On Wed, Dec 14, 2016 at 1:18 AM, Alexander Korotkov wrote: > Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with only > difference of variables naming and comments [2]. But he is not mentioned in > commit message. That doesn't look fine. > > 1. > https://www.postgresql.org/mes

Re: [COMMITTERS] pgsql: Fix bugs in RelationGetPartitionDispatchInfo.

2016-12-13 Thread Alexander Korotkov
Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with only difference of variables naming and comments [2]. But he is not mentioned in commit message. That doesn't look fine. 1. https://www.postgresql.org/message-id/e6c56fe9-4b87-4f64-ac6f-bc99675f3f9e%40postgrespro.ru 2. https:

[COMMITTERS] pgsql: Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix

2016-12-13 Thread Kevin Grittner
Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix. When there is both a serialization failure and a unique violation, throw the former rather than the latter. When initially pushed, this was viewed as a feature to assist application framework developers, so that they could more acc

[COMMITTERS] pgsql: Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix

2016-12-13 Thread Kevin Grittner
Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix. When there is both a serialization failure and a unique violation, throw the former rather than the latter. When initially pushed, this was viewed as a feature to assist application framework developers, so that they could more acc

[COMMITTERS] pgsql: Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix

2016-12-13 Thread Kevin Grittner
Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix. When there is both a serialization failure and a unique violation, throw the former rather than the latter. When initially pushed, this was viewed as a feature to assist application framework developers, so that they could more acc

[COMMITTERS] pgsql: Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix

2016-12-13 Thread Kevin Grittner
Back-patch fcff8a575198478023ada8a48e13b50f70054766 as a bug fix. When there is both a serialization failure and a unique violation, throw the former rather than the latter. When initially pushed, this was viewed as a feature to assist application framework developers, so that they could more acc

[COMMITTERS] pgsql: Improve handling of array elements as getdiag_targets and cursor

2016-12-13 Thread Tom Lane
Improve handling of array elements as getdiag_targets and cursor_variables. There's no good reason why plpgsql's GET DIAGNOSTICS statement can't support an array element as target variable, since the execution code already uses the generic exec_assign_value() function to assign to it. Hence, refac

[COMMITTERS] pgsql: Prevent planagg.c from failing on queries containing CTEs.

2016-12-13 Thread Tom Lane
Prevent planagg.c from failing on queries containing CTEs. The existing tests in preprocess_minmax_aggregates() usually prevent it from trying to do anything with queries containing CTEs, but there's an exception: a CTE could be present as a member of an appendrel, if we flattened a UNION ALL that

[COMMITTERS] pgsql: Prevent planagg.c from failing on queries containing CTEs.

2016-12-13 Thread Tom Lane
Prevent planagg.c from failing on queries containing CTEs. The existing tests in preprocess_minmax_aggregates() usually prevent it from trying to do anything with queries containing CTEs, but there's an exception: a CTE could be present as a member of an appendrel, if we flattened a UNION ALL that

[COMMITTERS] pgsql: Fix bug in hashbulkdelete.

2016-12-13 Thread Robert Haas
Fix bug in hashbulkdelete. Commit 6d46f4783efe457f74816a75173eb23ed8930020 failed to account for the possibility that hashbulkdelete() might encounter a bucket that has been split since it began scanning the bucket array. Repair. Extracted from a larger pathc by Amit Kapila; I rewrote the commen

[COMMITTERS] pgsql: Fix bugs in RelationGetPartitionDispatchInfo.

2016-12-13 Thread Robert Haas
Fix bugs in RelationGetPartitionDispatchInfo. The previous coding was not quite right for cases involving multiple levels of partitioning. Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a25665088d812d08bb888e961f208eaebf522050 Modified Files -

[COMMITTERS] pgsql: Clean up code, comments, and formatting for table partitioning.

2016-12-13 Thread Robert Haas
Clean up code, comments, and formatting for table partitioning. Amit Langote, plus pgindent-ing by me. Inspired in part by review comments from Tomas Vondra. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4b9a98e154cec81849af24091443747a6057c968 Modified Files ---

[COMMITTERS] pgsql: Update typedefs.list

2016-12-13 Thread Robert Haas
Update typedefs.list So developers can more easily run pgindent locally Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/acddbe221b084956a0efd6e4b6c6586e8fd994d7 Modified Files -- src/tools/pgindent/typedefs.list | 115

[COMMITTERS] pgsql: doc: Improve documentation related to table partitioning feature

2016-12-13 Thread Robert Haas
doc: Improve documentation related to table partitioning feature. Commit f0e44751d7175fa3394da2c8f85e3ceb3cdbfe63 implemented table partitioning, but failed to mention the "no row movement" restriction in the documentation. Fix that and a few other issues. Amit Langote, with some additional word