[COMMITTERS] pgsql: Add basic pg_dumpall/pg_restore TAP tests

2017-01-06 Thread Stephen Frost
Add basic pg_dumpall/pg_restore TAP tests For reasons unknown, pg_dumpall and pg_restore managed to escape the basic set of TAP tests that were added for pg_dump in 6bd356c3, so let's get them added now. A few minor adjustments are also made to the dump/restore tests to improve code coverage for

[COMMITTERS] pgsql: Merge two copies of tuple-building code in pltcl.c.

2017-01-06 Thread Tom Lane
Merge two copies of tuple-building code in pltcl.c. Make pltcl_trigger_handler() construct modified tuples using pltcl_build_tuple_result(), rather than its own copy of essentially the same logic. This results in slightly different message wording for the error cases, and in one case a different

[COMMITTERS] pgsql: Protect against NULL-dereference in pg_dump

2017-01-06 Thread Stephen Frost
Protect against NULL-dereference in pg_dump findTableByOid() is allowed to return NULL and we should therefore be checking for that case. getOwnedSeqs() and dumpSequence() shouldn't ever actually see this happen, but given odd circumstances it might and commit f9e439b1 probably shouldn't have rem

[COMMITTERS] pgsql: Protect against NULL-dereference in pg_dump

2017-01-06 Thread Stephen Frost
Protect against NULL-dereference in pg_dump findTableByOid() is allowed to return NULL and we should therefore be checking for that case. getOwnedSeqs() and dumpSequence() shouldn't ever actually see this happen, but given odd circumstances it might and commit f9e439b1 probably shouldn't have rem

[COMMITTERS] pgsql: Invalidate cached plans on FDW option changes.

2017-01-06 Thread Tom Lane
Invalidate cached plans on FDW option changes. This fixes problems where a plan must change but fails to do so, as seen in a bug report from Rajkumar Raghuwanshi. For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of forcing a relcache flush on the table. For ALTER FOREIGN DATA

[COMMITTERS] pgsql: Invalidate cached plans on FDW option changes.

2017-01-06 Thread Tom Lane
Invalidate cached plans on FDW option changes. This fixes problems where a plan must change but fails to do so, as seen in a bug report from Rajkumar Raghuwanshi. For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of forcing a relcache flush on the table. For ALTER FOREIGN DATA

[COMMITTERS] pgsql: Invalidate cached plans on FDW option changes.

2017-01-06 Thread Tom Lane
Invalidate cached plans on FDW option changes. This fixes problems where a plan must change but fails to do so, as seen in a bug report from Rajkumar Raghuwanshi. For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of forcing a relcache flush on the table. For ALTER FOREIGN DATA

[COMMITTERS] pgsql: Invalidate cached plans on FDW option changes.

2017-01-06 Thread Tom Lane
Invalidate cached plans on FDW option changes. This fixes problems where a plan must change but fails to do so, as seen in a bug report from Rajkumar Raghuwanshi. For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of forcing a relcache flush on the table. For ALTER FOREIGN DATA

[COMMITTERS] pgsql: Invalidate cached plans on FDW option changes.

2017-01-06 Thread Tom Lane
Invalidate cached plans on FDW option changes. This fixes problems where a plan must change but fails to do so, as seen in a bug report from Rajkumar Raghuwanshi. For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of forcing a relcache flush on the table. For ALTER FOREIGN DATA

Re: [COMMITTERS] pgsql: Update copyright for 2017

2017-01-06 Thread Bruce Momjian
On Wed, Jan 4, 2017 at 10:05:10AM -0500, Tom Lane wrote: > Andres Freund writes: > > On 2017-01-03 13:02:28 -0500, Bruce Momjian wrote: > >> Yeah, I was doing parallel pulls of different branches in git via shell > >> script, and it seems the size of this commit showed me that doesn't > >> work.

[COMMITTERS] pgsql: Repair commit b81b5a96f424531b97cdd1dba97d9d1b9c9d372e.

2017-01-06 Thread Robert Haas
Repair commit b81b5a96f424531b97cdd1dba97d9d1b9c9d372e. This commit purported to use a variable hash seed for Partial HashAggregate, but actually did the opposite - it made us use a variable seed for any HashAggregate that is NOT partial. Woops. Branch -- master Details --- http://git.p