Re: [COMMITTERS] pgsql: Fix some more regression test row-order-instability issues.

2017-01-13 Thread Amit Langote
On Sat, Jan 14, 2017 at 7:32 AM, Tom Lane wrote: > Fix some more regression test row-order-instability issues. > > Commit 0563a3a8b just introduced another instance of the same unsafe > testing methodology that appeared in 2ac3ef7a0, which I corrected in > 257d81572. Robert/Amit, please stop doin

[COMMITTERS] pgsql: Updates to reflect that pg_ctl stop -m fast is the default

2017-01-13 Thread Peter Eisentraut
Updates to reflect that pg_ctl stop -m fast is the default Various example and test code used -m fast explicitly, but since it's the default, this can be omitted now or should be replaced by a better example. pg_upgrade is not touched, so it can continue to operate with older installations. Bran

[COMMITTERS] pgsql: Fix some more regression test row-order-instability issues.

2017-01-13 Thread Tom Lane
Fix some more regression test row-order-instability issues. Commit 0563a3a8b just introduced another instance of the same unsafe testing methodology that appeared in 2ac3ef7a0, which I corrected in 257d81572. Robert/Amit, please stop doing that. Also look through the rest of f0e44751d's test cas

[COMMITTERS] pgsql: In PL/Tcl tests, don't choke if optional error fields are missin

2017-01-13 Thread Tom Lane
In PL/Tcl tests, don't choke if optional error fields are missing. This fixes a portability issue introduced by commit 961bed020: with a compiler that doesn't support PG_FUNCNAME_MACRO, the "funcname" field of errorCode won't be provided, leading to a failure of the unset command. I added -nocompl

[COMMITTERS] pgsql: pg_upgrade: Fix for changed pg_ctl default stop mode

2017-01-13 Thread Peter Eisentraut
pg_upgrade: Fix for changed pg_ctl default stop mode In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". pg_upgrade still thought the default mode was "smart" and only specified the mode when "fast" was asked for. This results in using "fast" all the time. It's not clear wha

[COMMITTERS] pgsql: pg_upgrade: Fix for changed pg_ctl default stop mode

2017-01-13 Thread Peter Eisentraut
pg_upgrade: Fix for changed pg_ctl default stop mode In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". pg_upgrade still thought the default mode was "smart" and only specified the mode when "fast" was asked for. This results in using "fast" all the time. It's not clear wha

[COMMITTERS] pgsql: pg_upgrade: Fix for changed pg_ctl default stop mode

2017-01-13 Thread Peter Eisentraut
pg_upgrade: Fix for changed pg_ctl default stop mode In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". pg_upgrade still thought the default mode was "smart" and only specified the mode when "fast" was asked for. This results in using "fast" all the time. It's not clear wha

[COMMITTERS] pgsql: Fix a bug in how we generate partition constraints.

2017-01-13 Thread Robert Haas
Fix a bug in how we generate partition constraints. Move the code for doing parent attnos to child attnos mapping for Vars in partition constraint expressions to a separate function map_partition_varattnos() and call it from the appropriate places. Doing it in get_qual_from_partbound(), as is now,

[COMMITTERS] pgsql: Fix cardinality estimates for parallel joins.

2017-01-13 Thread Robert Haas
Fix cardinality estimates for parallel joins. For a partial path, the cardinality estimate needs to reflect the number of rows we think each worker will see, rather than the total number of rows; otherwise, costing will go wrong. The previous coding got this completely wrong for parallel joins.

[COMMITTERS] pgsql: Fix cardinality estimates for parallel joins.

2017-01-13 Thread Robert Haas
Fix cardinality estimates for parallel joins. For a partial path, the cardinality estimate needs to reflect the number of rows we think each worker will see, rather than the total number of rows; otherwise, costing will go wrong. The previous coding got this completely wrong for parallel joins.