Re: [HACKERS] [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-20 Thread Andres Freund
Hi, On 2017-03-21 07:22:57 +0100, Fabien COELHO wrote: > > Add missing support for new node fields > > > > Commit b6fb534f added two new node fields but neglected to add copy and > > comparison support for them, Mea culpa, should have checked for that. > > I've been annoyed by these stupid functio

Re: [COMMITTERS] pgsql: Add missing support for new node fields

2017-03-20 Thread Fabien COELHO
Add missing support for new node fields Commit b6fb534f added two new node fields but neglected to add copy and comparison support for them, Mea culpa, should have checked for that. I've been annoyed by these stupid functions and forgetting to update them since I run into them while trying t

[COMMITTERS] pgsql: doc: clarify that function "ownership" that controls permission

2017-03-20 Thread Bruce Momjian
doc: clarify that function "ownership" that controls permission It used to say the creation user. Reported-by: Nathan Wagner Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/17fa3e834f288a2a8f0b3927d3f7f02451126686 Modified Files -- doc/src/sgml/ref/cre

[COMMITTERS] pgsql: doc: adjust 'Infinity' example to include minus

2017-03-20 Thread Bruce Momjian
doc: adjust 'Infinity' example to include minus This clarifies that quoted infinity values must have the negative signs inside single quotes. Reported-by: Don Morrison Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/692ed0567d0a17013b8bc631ad6cab29470a944d Modifie

[COMMITTERS] pgsql: Add missing support for new node fields

2017-03-20 Thread Andrew Dunstan
Add missing support for new node fields Commit b6fb534f added two new node fields but neglected to add copy and comparison support for them, Mea culpa, should have checked for that. per buildfarm animals with -DCOPY_PARSE_PLAN_TREES Branch -- master Details --- http://git.postgresql.org

Re: [COMMITTERS] pgsql: Add IF NOT EXISTS for CREATE SERVER and CREATE USER MAPPING

2017-03-20 Thread Andrew Dunstan
On 03/20/2017 07:58 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Add IF NOT EXISTS for CREATE SERVER and CREATE USER MAPPING > Several of the buildfarm members seem not to like this. > > If you need more details, I can poke into it on dromedary later tonight. > > Loo

[COMMITTERS] pgsql: doc: improve createdb example

2017-03-20 Thread Bruce Momjian
doc: improve createdb example The previous example could error out due to encoding mismatches; use -T/template instead. Reported-by: Jason O'Donnell Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c709b113e8f5433ea2a66b2fb08d9324dd596642 Modified Files --

Re: [COMMITTERS] pgsql: Add IF NOT EXISTS for CREATE SERVER and CREATE USER MAPPING

2017-03-20 Thread Tom Lane
Andrew Dunstan writes: > Add IF NOT EXISTS for CREATE SERVER and CREATE USER MAPPING Several of the buildfarm members seem not to like this. If you need more details, I can poke into it on dromedary later tonight. regards, tom lane -- Sent via pgsql-committers mailing

[COMMITTERS] pgsql: Force the regression databases to have bytea_output set to hex

2017-03-20 Thread Andrew Dunstan
Force the regression databases to have bytea_output set to hex Even if the installation defaults to escape output, this makes pg_regress make the setting hex, so that installcheck tests can pass in such a setting. Jeff Janes. Discussion: http://postgr.es/m/CAMkU=1xivktneycfzhwdhj+vh5qpu+4gsiprn

[COMMITTERS] pgsql: Add IF NOT EXISTS for CREATE SERVER and CREATE USER MAPPING

2017-03-20 Thread Andrew Dunstan
Add IF NOT EXISTS for CREATE SERVER and CREATE USER MAPPING There is still some inconsistency with the error messages surrounding foreign servers. Some use the word "foreign" and some don't. My inclination is to remove all such uses of "foreign" on the basis that the CREATE/ALTER/DROP SERVER comm

[COMMITTERS] pgsql: Use a consistent error message style for user mappings.

2017-03-20 Thread Andrew Dunstan
Use a consistent error message style for user mappings. User mappings are essentially anonymous, so messages referring to "user mapping foo on server bar" are wrong, and inconsistent with other error messages referring to user mappings. To be consistent with existing use, use "user mapping for foo

[COMMITTERS] pgsql: Another fix for single-page hash index vacuum.

2017-03-20 Thread Robert Haas
Another fix for single-page hash index vacuum. The WAL consistency checking code needed to be updated for the new page status bit, but that didn't get done previously. Ashutosh Sharma, reviewed by Amit Kapila Discussion: http://postgr.es/m/caa4ek1lp_oz4efmen14ojjuzn5cqpdfrkffua-mfkcfee8z...@mai

[COMMITTERS] pgsql: Fixes for single-page hash index vacuum.

2017-03-20 Thread Robert Haas
Fixes for single-page hash index vacuum. Clear LH_PAGE_HAS_DEAD_TUPLES during replay, similar to what gets done for btree. Update hashdesc.c for xl_hash_vacuum_one_page. Oversights in commit 6977b8b7f4dfb40896ff5e2175cad7fdbda862eb spotted by Amit Kapila. Patch by Ashutosh Sharma. Bump WAL ver

[COMMITTERS] pgsql: Add configure test to see if the C compiler has gcc-style comput

2017-03-20 Thread Tom Lane
Add configure test to see if the C compiler has gcc-style computed gotos. We'll need this for the upcoming patch to speed up expression evaluation. Might as well push it now to see if it behaves sanely in the buildfarm. Andres Freund Discussion: https://postgr.es/m/20170320062511.hp5qeurtxrwsv.

[COMMITTERS] pgsql: Add .gitignore for src/test/authentication/tmp_check.

2017-03-20 Thread Heikki Linnakangas
Add .gitignore for src/test/authentication/tmp_check. Michael Paquier Discussion: https://www.postgresql.org/message-id/CAB7nPqRZ_LNTCJ7gGjE_SpRanGoALfTgsxdauNsKq%2BLBRH9fxg%40mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/14a72525d2cf88a024ade4c109

[COMMITTERS] pgsql: Add missed "make clean" logic in src/interfaces/libpq/Makefile.

2017-03-20 Thread Tom Lane
Add missed "make clean" logic in src/interfaces/libpq/Makefile. Commit 818fd4a67 missed cleaning up the symlinks it added for various .c files imported from src/port and src/common. Neatnik-ishly make the file lists in the "clean" target look exactly like the earlier lists of what to symlink in.

[COMMITTERS] pgsql: Improve regression test coverage for TID scanning.

2017-03-20 Thread Tom Lane
Improve regression test coverage for TID scanning. TidScan plan nodes were not systematically tested before. These additions raise the LOC coverage number for the basic regression tests from 52% to 92% in nodeTidscan.c, and from 60% to 93% in tidpath.c. Andres Freund, tweaked a bit by me Discus

[COMMITTERS] pgsql: Revert unintentional change in increasing usage count during pin

2017-03-20 Thread Teodor Sigaev
Revert unintentional change in increasing usage count during pin of buffers, this makes buffer access strategy have no effect. Change was a part of commit 48354581a49c30f5757c203415aa8412d85b0f70 during 9.6 release cycle, so backpath to 9.6 Reported-by: Jim Nasby Author: Alexander Korotkov Reviewe

[COMMITTERS] pgsql: Revert unintentional change in increasing usage count during pin

2017-03-20 Thread Teodor Sigaev
Revert unintentional change in increasing usage count during pin of buffers, this makes buffer access strategy have no effect. Change was a part of commit 48354581a49c30f5757c203415aa8412d85b0f70 during 9.6 release cycle, so backpath to 9.6 Reported-by: Jim Nasby Author: Alexander Korotkov Reviewe

Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage

2017-03-20 Thread Robert Haas
So was this 3340 line patch posted or discussed anyplace before it got committed? On Sat, Mar 18, 2017 at 1:18 PM, Stephen Frost wrote: > Improve pg_dump regression tests and code coverage > > These improvements bring the lines-of-code coverage of pg_dump.c up to > 87.7% (at least using LCOV 1.12