Re: [COMMITTERS] pgsql: Fix a couple of problems in pg_get_statisticsextdef

2017-03-26 Thread Andrew Gierth
> "Alvaro" == Alvaro Herrera writes: Alvaro> Fix a couple of problems in pg_get_statisticsextdef Alvaro> src/test/regress/expected/stats_ext.out | 7 +++ Missed an update to stats_ext_1.out ? -- Andrew (irc:RhodiumToad) -- Sent via pgsql-committers mailing list (pgsql-committers@

[COMMITTERS] pgsql: Attempt to stabilize grouping sets regression test plans.

2017-03-26 Thread Andrew Gierth
Attempt to stabilize grouping sets regression test plans. Per buildfarm members dromedary and arapaima. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de4da168d57de812bb30d359394b7913635d21a9 Modified Files -- src/test/regress/expected/groupingsets.out

Re: [COMMITTERS] pgsql: Support hashed aggregation with grouping sets.

2017-03-26 Thread Tom Lane
Andrew Gierth writes: > Support hashed aggregation with grouping sets. Looks like this needs a bit more work to ensure the plans chosen for the regression test examples are stable ... regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgre

Re: [COMMITTERS] pgsql: Support hashed aggregation with grouping sets.

2017-03-26 Thread Andrew Gierth
> "Andrew" == Andrew Gierth writes: Andrew> Support hashed aggregation with grouping sets. Looks like some regression test plans aren't as stable as I hoped. On it. -- Andrew (irc:RhodiumToad) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes t

[COMMITTERS] pgsql: Fix a couple of problems in pg_get_statisticsextdef

2017-03-26 Thread Alvaro Herrera
Fix a couple of problems in pg_get_statisticsextdef There was a thinko whereby we tested the wrong tuple after fetching it from cache; avoid that by using generate_relation_name instead, which is simpler. Also, the statistics name was not qualified, so add that. (It could be argued that qualific

[COMMITTERS] pgsql: Support hashed aggregation with grouping sets.

2017-03-26 Thread Andrew Gierth
Support hashed aggregation with grouping sets. This extends the Aggregate node with two new features: HashAggregate can now run multiple hashtables concurrently, and a new strategy MixedAggregate populates hashtables while doing sorted grouping. The planner will now attempt to save as many sorts

[COMMITTERS] pgsql: Fix comment.

2017-03-26 Thread Robert Haas
Fix comment. Cut-and-paste led to something silly. Ashutosh Sharma, reviewed by Amit Kapila and by me Discussion: http://postgr.es/m/cae9k0pmubvqsby7kwn_okuqbyyhrxbx-c1zkuagr5vgf0ge...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f0a6046bcb15c2fe

[COMMITTERS] pgsql: Show more processes in pg_stat_activity.

2017-03-26 Thread Robert Haas
Show more processes in pg_stat_activity. Previously, auxiliary processes and background workers not connected to a database (such as the logical replication launcher) weren't shown. Include them, so that we can see the associated wait state information. Add a new column to identify the processes

[COMMITTERS] pgsql: Improve performance of ExecEvalWholeRowVar.

2017-03-26 Thread Tom Lane
Improve performance of ExecEvalWholeRowVar. In commit b8d7f053c, we needed to fix ExecEvalWholeRowVar to not change the state of the slot it's copying. The initial quick hack at that required two rounds of tuple construction, which is not very nice. To fix, add another primitive to tuptoaster.c t

[COMMITTERS] pgsql: Fix cpluspluscheck warning

2017-03-26 Thread Peter Eisentraut
Fix cpluspluscheck warning Structure tag cannot be the same as a typedef that is a pointer to that struct. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/895f93701fd78b6faab6b437685357298a91dfe3 Modified Files -- src/include/utils/pg_locale.h | 4 ++-- 1

[COMMITTERS] pgsql: Use ExecPrepareExpr in place of ExecPrepareCheck where appropria

2017-03-26 Thread Tom Lane
Use ExecPrepareExpr in place of ExecPrepareCheck where appropriate. Change one more place where ExecInitCheck/ExecPrepareCheck's insistence on getting implicit-AND-format quals wasn't really helpful, because the caller had to do make_ands_implicit() for no reason that it cared about. Using ExecPre

[COMMITTERS] pgsql: Fix typos in logical replication support for initial data copy.

2017-03-26 Thread Tom Lane
Fix typos in logical replication support for initial data copy. Fix an incorrect assert condition (noted by Coverity), and spell the new name of the function correctly. Typos introduced in commit 7c4f52409. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commi

[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod

2017-03-26 Thread Tom Lane
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements.

[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod

2017-03-26 Thread Tom Lane
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements.

[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod

2017-03-26 Thread Tom Lane
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements.

[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod

2017-03-26 Thread Tom Lane
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements.

[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod

2017-03-26 Thread Tom Lane
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements.

[COMMITTERS] pgsql: Fix some minor resource leaks in PerformRadiusTransaction().

2017-03-26 Thread Tom Lane
Fix some minor resource leaks in PerformRadiusTransaction(). Failure to free serveraddrs pointed out by Coverity, failure to close socket noted by code-reading. These bugs seem to be quite old, but given the low probability of taking these error-exit paths and the minimal consequences of the leak

[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod

2017-03-26 Thread Tom Lane
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements.

[COMMITTERS] pgsql: Improve implementation of EEOP_BOOLTEST_* opcodes.

2017-03-26 Thread Tom Lane
Improve implementation of EEOP_BOOLTEST_* opcodes. Both Andres and I were happy with "*op->resvalue = *op->resvalue;", but Coverity isn't; and it has a point, because some compilers might not be smart enough to elide that. So remove it. In passing, also avoid doing unnecessary assignments to *op

[COMMITTERS] pgsql: doc: Fix oldhtml/old PDF build

2017-03-26 Thread Peter Eisentraut
doc: Fix oldhtml/old PDF build "xref to REFSECT1 unsupported" with the DSSSL stylesheets. Reported-by: Devrim Gündüz Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e259e1f748c7a6d67e307a90d6c27b8ab8b90df8 Modified Files -- doc/src/sgml/ref/alter_colla

[COMMITTERS] pgsql: doc: Clean up bibliography rendering for XSLT

2017-03-26 Thread Peter Eisentraut
doc: Clean up bibliography rendering for XSLT In the DSSSL stylesheets, we had an extensive customization of the bibliography rendering. Since the bibliography isn't that used much, it doesn't seem worth doing an elaborate porting of that to XSLT. So this just moves some things around, removes s

[COMMITTERS] pgsql: Add missing break

2017-03-26 Thread Alvaro Herrera
Add missing break Noticed by Coverity Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6a101b0aed78e09b51e2162e6b68a4aeab52b61e Modified Files -- src/backend/tcop/utility.c | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list

[COMMITTERS] pgsql: Update some obsolete comments.

2017-03-26 Thread Tom Lane
Update some obsolete comments. Fix a few stray references to expression eval functions that don't exist anymore or don't take the same input representation they used to. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/244dd95ce9d9831f8498f5746860325f7adcecbf Modifie