Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Amit Langote
On 2017/06/12 11:51, Tom Lane wrote: > Amit Langote writes: >> On 2017/06/12 11:09, Joe Conway wrote: >>> On 06/11/2017 05:35 PM, Tom Lane wrote: First guess is that map_partition_varattnos has forgotten to handle WithCheckOption.qual. > >>> Drat. I'll take a look, but it would probably

[COMMITTERS] pgsql: Fix ALTER TABLE doc examples.

2017-06-11 Thread Tatsuo Ishii
Fix ALTER TABLE doc examples. Patch by Yugo Nagata . Confirmed by Amit Langote, who is the original author of the document part. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eab86897bd8cbeb21ae8959ca9a095ce7cb663df Modified Files -- doc/src/sgml/ref

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Tom Lane
Amit Langote writes: > On 2017/06/12 11:09, Joe Conway wrote: >> On 06/11/2017 05:35 PM, Tom Lane wrote: >>> First guess is that map_partition_varattnos has forgotten to handle >>> WithCheckOption.qual. >> Drat. I'll take a look, but it would probably be good if someone >> generally familiar with

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Amit Langote
On 2017/06/12 11:09, Joe Conway wrote: > On 06/11/2017 05:35 PM, Tom Lane wrote: >> Joe Conway writes: >>> Apply RLS policies to partitioned tables. >> >> Buildfarm member skink has grown a "make check" failure with this commit. >> >> ==28150== VALGRINDERROR-BEGIN >> ==28150== Invalid read of size

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Joe Conway
On 06/11/2017 05:35 PM, Tom Lane wrote: > Joe Conway writes: >> Apply RLS policies to partitioned tables. > > Buildfarm member skink has grown a "make check" failure with this commit. > > ==28150== VALGRINDERROR-BEGIN > ==28150== Invalid read of size 8 > ==28150==at 0x39A355: ExecInitModifyT

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Tom Lane
Joe Conway writes: > Apply RLS policies to partitioned tables. Buildfarm member skink has grown a "make check" failure with this commit. ==28150== VALGRINDERROR-BEGIN ==28150== Invalid read of size 8 ==28150==at 0x39A355: ExecInitModifyTable (nodeModifyTable.c:1862) ==28150==by 0x37F0F8:

[COMMITTERS] pgsql: Handle unqualified SEQUENCE NAME options properly in parse_utilc

2017-06-11 Thread Tom Lane
Handle unqualified SEQUENCE NAME options properly in parse_utilcmd.c. generateSerialExtraStmts() was sloppy about handling the case where SEQUENCE NAME is given with a not-schema-qualified name. It was generating a CreateSeqStmt with an unqualified sequence name, and an AlterSeqStmt whose "owned_

[COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

2017-06-11 Thread Joe Conway
Apply RLS policies to partitioned tables. The new partitioned table capability added a new relkind, namely RELKIND_PARTITIONED_TABLE. Update fireRIRrules() to apply RLS policies on RELKIND_PARTITIONED_TABLE as it does RELKIND_RELATION. In addition, add RLS regression test coverage for partitioned