Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

On 2017/06/12 22:46, Tom Lane wrote: > Amit Langote writes: >> How about something like the attached? The patch makes >> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on >> WithCheckOption.qual that is being initialized for each partition. > > Well, the question then is

[COMMITTERS] pgsql: Fix confusion about number of subplans in partitioned INSERT set

Fix confusion about number of subplans in partitioned INSERT setup. ExecInitModifyTable() thought there was a plan per partition, but no, there's only one. The problem had escaped detection so far because there would only be visible misbehavior if there were a SubPlan (not an InitPlan) in the qua

[COMMITTERS] pgsql: pg_dump: Fix harmless type mixup

pg_dump: Fix harmless type mixup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/791ef001c9fe980e32092227a72ec24a7d66fa3d Modified Files -- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mai

[COMMITTERS] pgsql: doc: Update external PL list

doc: Update external PL list Add PL/Lua, PL/v8. Remove stale/unmaintained PL/PHP, PL/Py, PL/Ruby, PL/Scheme. Reported-by: Adam Sah Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2440c442d167d9d081a3e69c4fa78f3b6f8932e9 Modified Files -- doc/src/sgml

[COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

Assert that we don't invent relfilenodes or type OIDs in binary upgrade. During pg_upgrade's restore run, all relfilenode choices should be overridden by commands in the dump script. If we ever find ourselves choosing a relfilenode in the ordinary way, someone blew it. Likewise for pg_type OIDs.

[COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

Assert that we don't invent relfilenodes or type OIDs in binary upgrade. During pg_upgrade's restore run, all relfilenode choices should be overridden by commands in the dump script. If we ever find ourselves choosing a relfilenode in the ordinary way, someone blew it. Likewise for pg_type OIDs.

[COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

Assert that we don't invent relfilenodes or type OIDs in binary upgrade. During pg_upgrade's restore run, all relfilenode choices should be overridden by commands in the dump script. If we ever find ourselves choosing a relfilenode in the ordinary way, someone blew it. Likewise for pg_type OIDs.

[COMMITTERS] pgsql: Fix ALTER SEQUENCE OWNED BY to not rewrite the sequence relation

Fix ALTER SEQUENCE OWNED BY to not rewrite the sequence relation. It's not necessary for it to do that, since OWNED BY requires only ordinary catalog updates and doesn't affect future sequence values. And pg_upgrade needs to use OWNED BY without having it change the sequence's relfilenode. Commit

[COMMITTERS] pgsql: doc: Update information_schema documentation for identity column

doc: Update information_schema documentation for identity columns This was apparently forgotten in the original patch. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5d8beac8bee344bdf4b05a63b93f06e05d999b39 Modified Files -- doc/src/sgml/information_sc

[COMMITTERS] pgsql: Add ICU_CFLAGS to global CPPFLAGS

Add ICU_CFLAGS to global CPPFLAGS The original code only added ICU_CFLAGS to the backend build. But it is also needed for building external modules that include pg_locale.h. So add it to the global CPPFLAGS. (This is only relevant if ICU is not in a compiler default path, so it apparently hasn'

[COMMITTERS] pgsql: Remove "synchronized table states" notice message

Remove "synchronized table states" notice message It appears to be more confusing than useful. Reported-by: Jeff Janes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7f28a7946a37e1716fe12c9e8466dbb868292087 Modified Files -- src/backend/commands/subs

[COMMITTERS] pgsql: Add MSVC build system support for ICU

Add MSVC build system support for ICU Author: Ashutosh Sharma Reviewed-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/03c396080ddc77b188a11dd54aa2a075ab2718e0 Modified Files -- src/tools/msvc/Solution.pm | 12 sr

[COMMITTERS] pgsql: Fix build of ICU support in Windows

Fix build of ICU support in Windows and also any platform that does not have locale_t but enabled ICU. Author: Ashutosh Sharma Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/253504fb9f804b6aa7cec9b9b2506fa88accf0dc Modified Files -- src/backend/comma

[COMMITTERS] pgsql: Trim trailing whitespace

Trim trailing whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bf6e4c3c82d349dc311ef795cc8eb7a9badf49eb Modified Files -- doc/src/sgml/func.sgml | 2 +- doc/src/sgml/high-availability.sgml | 2 +- doc/src/sgml/libpq.sgml

Re: [COMMITTERS] pgsql: Apply RLS policies to partitioned tables.

Amit Langote writes: > How about something like the attached? The patch makes > mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on > WithCheckOption.qual that is being initialized for each partition. Well, the question then is whether that behaves correctly. Where it woul

[COMMITTERS] pgsql: Stop table sync workers when subscription relation entry is remo

Stop table sync workers when subscription relation entry is removed When a table sync worker is in waiting state and the subscription table entry is removed because of a concurrent subscription refresh, the worker could be left orphaned. To avoid that, explicitly stop the worker when the pg_subsc