[COMMITTERS] pgsql: Fix up some misusage of appendStringInfo() and friends

2017-08-15 Thread Peter Eisentraut
Fix up some misusage of appendStringInfo() and friends Change to appendStringInfoChar() or appendStringInfoString() where those can be used. Author: David Rowley Reviewed-by: Ashutosh Bapat Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77d05706beb115b412728bd94

[COMMITTERS] pgsql: Initialize replication_slot_catalog_xmin in procarray

2017-08-15 Thread Peter Eisentraut
Initialize replication_slot_catalog_xmin in procarray Although not confirmed and probably rare, if the newly allocated memory is not already zero, this could possibly have caused some problems. Also reorder the initializations slightly so they match the order of the struct definition. Author: Wo

[COMMITTERS] pgsql: Initialize replication_slot_catalog_xmin in procarray

2017-08-15 Thread Peter Eisentraut
Initialize replication_slot_catalog_xmin in procarray Although not confirmed and probably rare, if the newly allocated memory is not already zero, this could possibly have caused some problems. Also reorder the initializations slightly so they match the order of the struct definition. Author: Wo

[COMMITTERS] pgsql: Initialize replication_slot_catalog_xmin in procarray

2017-08-15 Thread Peter Eisentraut
Initialize replication_slot_catalog_xmin in procarray Although not confirmed and probably rare, if the newly allocated memory is not already zero, this could possibly have caused some problems. Also reorder the initializations slightly so they match the order of the struct definition. Author: Wo

[COMMITTERS] pgsql: Initialize replication_slot_catalog_xmin in procarray

2017-08-15 Thread Peter Eisentraut
Initialize replication_slot_catalog_xmin in procarray Although not confirmed and probably rare, if the newly allocated memory is not already zero, this could possibly have caused some problems. Also reorder the initializations slightly so they match the order of the struct definition. Author: Wo

[COMMITTERS] pgsql: Initialize replication_slot_catalog_xmin in procarray

2017-08-15 Thread Peter Eisentraut
Initialize replication_slot_catalog_xmin in procarray Although not confirmed and probably rare, if the newly allocated memory is not already zero, this could possibly have caused some problems. Also reorder the initializations slightly so they match the order of the struct definition. Author: Wo

[COMMITTERS] pgsql: doc: Document pg_receivewal exit behavior and status

2017-08-15 Thread Peter Eisentraut
doc: Document pg_receivewal exit behavior and status Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0a2d43d988eef2aee679582ba1b72b2587cbaab2 Modified Files -- doc/src/sgml/ref/pg_receivewal.sgml | 18 ++ 1 file changed, 18 insertions(+)

[COMMITTERS] pgsql: pg_receivewal: Improve verbose mode

2017-08-15 Thread Peter Eisentraut
pg_receivewal: Improve verbose mode Some informational messages showed up even if verbose mode was not used. Move them to verbose mode. Author: Michael Paquier Reviewed-by: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/514731af58765f62b233098

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- REL_10_STABLE Details --- https://git.pos

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- REL9_3_STABLE Details --- https://git.pos

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- REL9_6_STABLE Details --- https://git.pos

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- master Details --- https://git.postgresql

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- REL9_5_STABLE Details --- https://git.pos

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- REL9_2_STABLE Details --- https://git.pos

[COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
Include foreign tables in information_schema.table_privileges This appears to have been an omission in the original commit 0d692a0dc9f. All related information_schema views already include foreign tables. Reported-by: Nicolas Thauvin Branch -- REL9_4_STABLE Details --- https://git.pos

[COMMITTERS] pgsql: psql: Add tab completion for \pset pager

2017-08-15 Thread Peter Eisentraut
psql: Add tab completion for \pset pager Author: Pavel Stehule Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/62c9eaf5535df8efb417600add99f6e0d111dac2 Modified Files -- src/bin/psql/tab-complete.c | 2 ++ 1 file changed, 2 insertions(+) -- Se

[COMMITTERS] pgsql: psql: Add tab completion for \pset pager

2017-08-15 Thread Peter Eisentraut
psql: Add tab completion for \pset pager Author: Pavel Stehule Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7502f399de38c68d2bb327e4071dd2fcdb5a20e6 Modified Files -- src/bin/psql/tab-complete.c | 2 ++ 1 file changed, 2 insertions(+) -- Se

[COMMITTERS] pgsql: psql: Add tab completion for \pset pager

2017-08-15 Thread Peter Eisentraut
psql: Add tab completion for \pset pager Author: Pavel Stehule Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0f0ee68e94319e3f32baf3c18dcae1d5842b0d5c Modified Files -- src/bin/psql/tab-complete.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via

[COMMITTERS] pgsql: Simplify autovacuum work-item implementation

2017-08-15 Thread Alvaro Herrera
Simplify autovacuum work-item implementation The initial implementation of autovacuum work-items used a dynamic shared memory area (DSA). However, it's argued that dynamic shared memory is not portable enough, so we cannot rely on it being supported everywhere; at the same time, autovacuum work-i

[COMMITTERS] pgsql: Simplify autovacuum work-item implementation

2017-08-15 Thread Alvaro Herrera
Simplify autovacuum work-item implementation The initial implementation of autovacuum work-items used a dynamic shared memory area (DSA). However, it's argued that dynamic shared memory is not portable enough, so we cannot rely on it being supported everywhere; at the same time, autovacuum work-i

[COMMITTERS] pgsql: Make simpler-simple-expressions code cope with a Gather plan.

2017-08-15 Thread Tom Lane
Make simpler-simple-expressions code cope with a Gather plan. Commit 00418c612 expected that the plan generated for a simple-expression query would always be a plain Result node. However, if force_parallel_mode is on, the planner might stick a Gather atop that. Cope by looking through the Gather

[COMMITTERS] pgsql: Fix logical replication protocol comparison logic

2017-08-15 Thread Peter Eisentraut
Fix logical replication protocol comparison logic Since we currently only have one protocol, this doesn't make much of a difference other than the error message. Author: Yugo Nagata Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/70b573b2677eb5ef28515e824e5027e26c

[COMMITTERS] pgsql: Fix logical replication protocol comparison logic

2017-08-15 Thread Peter Eisentraut
Fix logical replication protocol comparison logic Since we currently only have one protocol, this doesn't make much of a difference other than the error message. Author: Yugo Nagata Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/edbad25877b10df07164345a8e6

[COMMITTERS] pgsql: doc: Add missing logical replication protocol message

2017-08-15 Thread Peter Eisentraut
doc: Add missing logical replication protocol message Author: Masahiko Sawada Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0cafc267b5b2a0b9d8d93c7c3f1e88adb37fea6e Modified Files -- doc/src/sgml/protocol.sgml | 56

[COMMITTERS] pgsql: doc: Add missing logical replication protocol message

2017-08-15 Thread Peter Eisentraut
doc: Add missing logical replication protocol message Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/34a23a34269519e19b5da3ea4e29e4e0abadfee3 Modified Files -- doc/src/sgml/protocol.sgml | 56 +++

[COMMITTERS] pgsql: Simplify some code in logical replication launcher

2017-08-15 Thread Peter Eisentraut
Simplify some code in logical replication launcher Avoid unnecessary locking calls when a subscription is disabled. Author: Yugo Nagata Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/292d9b66e2251df4767a43d78927a614561a21d6 Modified Files -- s

[COMMITTERS] pgsql: Simplify some code in logical replication launcher

2017-08-15 Thread Peter Eisentraut
Simplify some code in logical replication launcher Avoid unnecessary locking calls when a subscription is disabled. Author: Yugo Nagata Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e42351ae07c19bb4eaedbdce8ccd4dfb4e905069 Modified Files -- src/back

[COMMITTERS] pgsql: doc: Improve PDF bookmarks

2017-08-15 Thread Peter Eisentraut
doc: Improve PDF bookmarks Also create PDF bookmarks/ToC entries for subsections of reference pages. This was a regression from the previous jadetex-based build. Reported-by: Erik Rijkers Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/270fec9f0bc9082ed99f0c447d4

[COMMITTERS] pgsql: doc: Improve PDF bookmarks

2017-08-15 Thread Peter Eisentraut
doc: Improve PDF bookmarks Also create PDF bookmarks/ToC entries for subsections of reference pages. This was a regression from the previous jadetex-based build. Reported-by: Erik Rijkers Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4e7cd035abaae16e4530

[COMMITTERS] pgsql: Avoid out-of-memory in a hash join with many duplicate inner key

2017-08-15 Thread Tom Lane
Avoid out-of-memory in a hash join with many duplicate inner keys. The executor is capable of splitting buckets during a hash join if too much memory is being used by a small number of buckets. However, this only helps if a bucket's population is actually divisible; if all the hash keys are alike

[COMMITTERS] pgsql: Fix error handling path in autovacuum launcher

2017-08-15 Thread Alvaro Herrera
Fix error handling path in autovacuum launcher The original code (since 00e6a16d01) was assuming aborting the transaction in autovacuum launcher was sufficient to release all resources, but in reality the launcher runs quite a lot of code out of any transactions. Re-introduce individual cleanup c

[COMMITTERS] pgsql: Fix error handling path in autovacuum launcher

2017-08-15 Thread Alvaro Herrera
Fix error handling path in autovacuum launcher The original code (since 00e6a16d01) was assuming aborting the transaction in autovacuum launcher was sufficient to release all resources, but in reality the launcher runs quite a lot of code out of any transactions. Re-introduce individual cleanup c

[COMMITTERS] pgsql: Assorted preparatory refactoring for partition-wise join.

2017-08-15 Thread Robert Haas
Assorted preparatory refactoring for partition-wise join. Instead of duplicating the logic to search for a matching ParamPathInfo in multiple places, factor it out into a separate function. Pass only the relevant bits of the PartitionKey to partition_bounds_equal instead of the whole thing, becau

[COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.

2017-08-15 Thread Tom Lane
Simplify plpgsql's check for simple expressions. plpgsql wants to recognize expressions that it can execute directly via ExecEvalExpr() instead of going through the full SPI machinery. Originally the test for this consisted of recursively groveling through the post-planning expression tree to see

[COMMITTERS] pgsql: Allow continuation lines in ecpg cppline parsing.

2017-08-15 Thread Michael Meskes
Allow continuation lines in ecpg cppline parsing. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a4619b26a6a69ab31cab4a0632460647d7f5510f Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[COMMITTERS] pgsql: Distinguish wait-for-connection from wait-for-write-ready on Win

2017-08-15 Thread Tom Lane
Distinguish wait-for-connection from wait-for-write-ready on Windows. The API for WaitLatch and friends followed the Unix convention in which waiting for a socket connection to complete is identical to waiting for the socket to accept a write. While Windows provides a select(2) emulation that agr

[COMMITTERS] pgsql: Distinguish wait-for-connection from wait-for-write-ready on Win

2017-08-15 Thread Tom Lane
Distinguish wait-for-connection from wait-for-write-ready on Windows. The API for WaitLatch and friends followed the Unix convention in which waiting for a socket connection to complete is identical to waiting for the socket to accept a write. While Windows provides a select(2) emulation that agr

[COMMITTERS] pgsql: Teach adjust_appendrel_attrs(_multilevel) to do multiple transla

2017-08-15 Thread Robert Haas
Teach adjust_appendrel_attrs(_multilevel) to do multiple translations. Currently, child relations are always base relations, so when we translate parent relids to child relids, we only need to translate a singler relid. However, the proposed partition-wise join feature will create child joins, wh

[COMMITTERS] pgsql: Fix whitespace

2017-08-15 Thread Peter Eisentraut
Fix whitespace Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c4dd62db1995d17b85c77d901b5eba8f25dfe2ff Modified Files -- src/backend/po/es.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: Avoid unnecessary single-child Append nodes.

2017-08-15 Thread Robert Haas
Avoid unnecessary single-child Append nodes. Before commit d3cc37f1d801a6b5cad9bf179274a8, an inheritance parent whose only children were temp tables of other sessions would end up as a simple scan of the parent; but with that commit, we end up with an Append node, per a report from Ashutosh Bapat

[COMMITTERS] pgsql: Avoid unnecessary single-child Append nodes.

2017-08-15 Thread Robert Haas
Avoid unnecessary single-child Append nodes. Before commit d3cc37f1d801a6b5cad9bf179274a8, an inheritance parent whose only children were temp tables of other sessions would end up as a simple scan of the parent; but with that commit, we end up with an Append node, per a report from Ashutosh Bapat

[COMMITTERS] pgsql: Add missing call to ExecReScanGatherMerge.

2017-08-15 Thread Robert Haas
Add missing call to ExecReScanGatherMerge. Amit Kapila Discussion: http://postgr.es/m/caa4ek1keqwzoodmdmgmwuqzpw9jhrs+ditqvfdafgjnmmzz...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/29990634c76a2278ae68bfb951fd20d5510a732d Modified Files

[COMMITTERS] pgsql: Add missing call to ExecReScanGatherMerge.

2017-08-15 Thread Robert Haas
Add missing call to ExecReScanGatherMerge. Amit Kapila Discussion: http://postgr.es/m/caa4ek1keqwzoodmdmgmwuqzpw9jhrs+ditqvfdafgjnmmzz...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1295a777882b8ed180a854e249f91be565a99422 Modified Files --