Hello Tom,
Well, I think it's mostly about valgrind making everything really slow.
Since we have seen some passes from skink recently, perhaps there was
also a component of more-load-on-the-machine-than-usual. But in the end
this is just evidence for my point that regression tests have to
You are attacking a straw man.
I thought it was tilting at windmills:-)
In the TAP-test context, you do have quite a bit of freedom to decide
what is a pass and what is a fail. So maybe the path forward is to be
more flexible about the pass conditions for this test.
Hmmm. I'm not sure
If the test must run even when postgres doesn't, it is a little bit
hard as a starting assumption for a benchmarking tool:-(
I'm unsure what the point of this is. It's not like we discussing
removing pgbench, we're talking about an unreliable test.
My sentence was probably not very clear.
Hello Tom,
Remove pgbench "progress" test pending solution of its timing issues.
It would have been nicer to simply comment them out...
Buildfarm member skink shows that this is even more flaky than I
thought. There are probably some actual pgbench bugs here as well as a
timing
Provide a test for variable existence in psql
Thanks for the editing & commit.
Pavel's feedback helped to devise a nicer syntax, although it was not
strictly speaking a review.
--
Fabien.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your
Fix more portability issues in new pgbench TAP tests.
Sorry for all these issues unforeseen issues. Thanks to the farm!
* Remove no-such-user test case, output isn't stable, and we really
don't need to be testing such cases here anyway.
Ok.
* Fix the process exit code test logic to
Hello,
Please find attached "blind" additional fixes for Windows & AIX.
- more nan/inf variants
- different message on non existing user
- illegal vs unrecognized options
I suspect that $windows_os is not true on "bowerbird", in order to fix it
the value of "$Config{osname}" is needed...
Fix assorted portability issues in new pgbench TAP tests.
Most where hard to guess without having the report. Thanks.
* Test was way too optimistic about the platform independence of
NaN and Infinity outputs. I rather imagine we might have to lose
those tests altogether, but for the moment
Hello Andres,
It is not done yet, but it looks that it can work in the end with limited
effort. Currently it works for copy & equal.
It'd have to do out/read as well imo.
Sure. This part is WIP, though.
Is there some interest to generate the x00kB of sources rather than edit
them
Add missing support for new node fields
Commit b6fb534f added two new node fields but neglected to add copy and
comparison support for them, Mea culpa, should have checked for that.
I've been annoyed by these stupid functions and forgetting to update them
since I run into them while trying
Not only did it not accept --builtin as a synonym for -b, but what it did
accept as a synonym was --tpc-b (huh?), which it got even further wrong
by marking as no_argument, so that if you did try that you got a core
dump. I suppose this is leftover from some early design for the new
switches
Will fix.
Oops, I missed this line... Thanks!
--
Fabien.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Hello Tom,
I think the problem is here (pgbench.c lines 4550):
Hmmm... Indeed "typedef char bool;". I thought postgresql bool was an
int, I usually do "typedef enum { false, true } bool;"
I see a number of other things that look pretty infelicitous in this
code --- for example, why is
Hello Tom,
There's at least one bug in this patch.
Indeed.
It's caused pgbench to go into an infinite loop during the TAP tests on
my buildfarm machine longfin.
buildfarm 719:14.18 /Users/buildfarm/bf-data/HEAD/inst/bin/pgbench --no-vacuum
--client=5 --protocol=prepared
Rename pgbench min/max to least/greatest, and fix handling of double
args.
Ok.
The very minor patch attached re-establishes the alphabetical order when
listing functions names in pgbench documentation.
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
Hello Peter,
http://git.postgresql.org/pg/commitdiff/b87b2f4bda1a3b98f8dea867b8bc419ace7a9ea9
doc/src/sgml/ref/pgbench.sgml | 8
- Here is example outputs:
+ Here is example output:
I think that something is missing now on this line. Should it rather be
"Here is an example
ISTM that in stack variables are initialized to zero automatically, so
although it is not explicitely initialized, it is not uninitialized...
Uh? They're not.
Indeed, I mixed up with "static", shame on me!
--
Fabien.
--
Sent via pgsql-committers mailing list
pgbench.c:2765: warning: 'ps.stats.lag.sum2' is used uninitialized in this
function
Sorry for the noise.
Strangely, I did not get that warning with gcc 4.8.4.
ISTM that in stack variables are initialized to zero automatically, so
although it is not explicitely initialized, it is not
A removed check in ba3deeefb
Indeed. It seems that it was really removed by 1bc90f7a, that I should
have checked...
--
Fabien.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
Also, it appears that the exprscan.h file doesn't actually
get (or need to be) generated here.
Indeed.
So I think we need something like the attached.
There is a $(RM) make macro usually defined as rm -f, but it does not
seem to be used elsewhere.
--
Fabien.
--
Sent via
The makefile changes in this do not look right to me. Files that are
meant to be shipped in the tarball should be removed by make
maintainer-clean, not an ordinary make clean which is what the committed
patch appears to do. Otherwise, a tarball user without bison installed
would be cut off at
Hello Alvaro,
I have submitted a small patch to improve tests on event triggers,
including tests for GRANT/REVOKE/COMMENT:
https://commitfest.postgresql.org/5/179/
--
Fabien.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your
doc/src/sgml/event-trigger.sgml | 125 +-
While reading the documentation, it occured to me that the first sentence
of the first subsection lacks a reference to table_rewrite, see attached
very minor suggestion.
BTW, I'll try to send a check script.
Hello,
* Add tool to query pg_stat_* tables and report indexes that aren't needed
or tables that might need indexes
Good.
This is the kind of things I'm planning for the pg-advisor tool, which
queries system relations thru views and report inconsistencies (such as
mismatching types for foreign
Dear Tom,
Fix unintended assignment of sequences to the containing schema's
default tablespace
You might consider fixing the CREATE SCHEMA documentation as well.
Thanks, have a nice day,
--
Fabien Coelho - [EMAIL PROTECTED]
---(end of broadcast
else want to do it, fine with me, I don't stick to my
particular implementation: I just want the feature;-)
Have a nice day,
--
Fabien Coelho - [EMAIL PROTECTED]
---(end of broadcast)---
TIP 8: explain analyze is your friend
Dear Bruce,
Remove NT4 mention in release notes.
please find attached a patch to make it even clearer that NT4 is not
supported, by *not* using NT-based Windows expression as NT4 is not
included, and by specify explicitely NT4 as not supported...
Have a nice day,
--
Fabien Coelho - [EMAIL
Dear Peter,
PostgreSQL extension makefile framework (pgxs), by Fabien Coelho, with
some massaging by Peter Eisentraut. This is basically a simple
generalization of the existing contrib makefiles.
Thanks for your help.
I'm having a look at CVS know, and it seems to me that one cannot pgxs
the aclitem data type.
I'll submit a few lines anyway.
--
Fabien Coelho - [EMAIL PROTECTED]
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
possible users/groups
and all possible objects. Moreover, I need access to the raw information
to check for its consistency, not the derived functionnal stuff.
--
Fabien Coelho - [EMAIL PROTECTED]
---(end of broadcast)---
TIP 5: Have you checked
. Moreover, I don't think this patch
did hurt anybody, as it was pretty invisible and was useful to me.
I'm tired. When I'll be too tired, you'll just lose a contributor. A very
small loss indeed, but I don't think it is a good policy for your project.
Have a nice day,
--
Fabien Coelho - [EMAIL
31 matches
Mail list logo
