[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_6_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_3_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- master Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL_10_STABLE Details ---

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp. This suite had been a proper superset of the regular ecpg test suite, but the three newest tests didn't reach it. To make this less likely to recur, delete the extra schedule file and pass the TCP-specific test on the command line. Back-patch to 9.3 (all

[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp. This suite had been a proper superset of the regular ecpg test suite, but the three newest tests didn't reach it. To make this less likely to recur, delete the extra schedule file and pass the TCP-specific test on the command line. Back-patch to 9.3 (all

[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6. Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed "localhost" resolves to both ::1 and 127.0.0.1. We gain nothing from that assumption, and it does not hold in a default installation of Red Hat Enterprise Linux 5. Back-patch

[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp. This suite had been a proper superset of the regular ecpg test suite, but the three newest tests didn't reach it. To make this less likely to recur, delete the extra schedule file and pass the TCP-specific test on the command line. Back-patch to 9.3 (all

[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp. This suite had been a proper superset of the regular ecpg test suite, but the three newest tests didn't reach it. To make this less likely to recur, delete the extra schedule file and pass the TCP-specific test on the command line. Back-patch to 9.3 (all

[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6. Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed "localhost" resolves to both ::1 and 127.0.0.1. We gain nothing from that assumption, and it does not hold in a default installation of Red Hat Enterprise Linux 5. Back-patch

[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6. Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed "localhost" resolves to both ::1 and 127.0.0.1. We gain nothing from that assumption, and it does not hold in a default installation of Red Hat Enterprise Linux 5. Back-patch

[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6. Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed "localhost" resolves to both ::1 and 127.0.0.1. We gain nothing from that assumption, and it does not hold in a default installation of Red Hat Enterprise Linux 5. Back-patch

[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp. This suite had been a proper superset of the regular ecpg test suite, but the three newest tests didn't reach it. To make this less likely to recur, delete the extra schedule file and pass the TCP-specific test on the command line. Back-patch to 9.3 (all

[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6. Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed "localhost" resolves to both ::1 and 127.0.0.1. We gain nothing from that assumption, and it does not hold in a default installation of Red Hat Enterprise Linux 5. Back-patch

[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp. This suite had been a proper superset of the regular ecpg test suite, but the three newest tests didn't reach it. To make this less likely to recur, delete the extra schedule file and pass the TCP-specific test on the command line. Back-patch to 9.3 (all

[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6. Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed "localhost" resolves to both ::1 and 127.0.0.1. We gain nothing from that assumption, and it does not hold in a default installation of Red Hat Enterprise Linux 5. Back-patch

[COMMITTERS] pgsql: Fix connect/test1 expected output.

2017-11-11 Thread Noah Misch
Fix connect/test1 expected output. The test runs only as part of "checktcp". This is a back-patch to 9.5 and 9.4 of part of commit 868898739a8da9ab74c105b8349b7b5c711f265a. Oversight in commit 61bee9f756ce875f3b678099a6bb9654bd2fa21a. Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: Fix connect/test1 expected output.

2017-11-11 Thread Noah Misch
Fix connect/test1 expected output. The test runs only as part of "checktcp". This is a back-patch to 9.5 and 9.4 of part of commit 868898739a8da9ab74c105b8349b7b5c711f265a. Oversight in commit 61bee9f756ce875f3b678099a6bb9654bd2fa21a. Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds. To ensure stable output, catch one more configuration-specific error. Back-patch to 9.3, like the commit that added the test. Branch -- REL9_3_STABLE Details ---

[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds. To ensure stable output, catch one more configuration-specific error. Back-patch to 9.3, like the commit that added the test. Branch -- REL_10_STABLE Details ---

[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds. To ensure stable output, catch one more configuration-specific error. Back-patch to 9.3, like the commit that added the test. Branch -- REL9_6_STABLE Details ---

[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds. To ensure stable output, catch one more configuration-specific error. Back-patch to 9.3, like the commit that added the test. Branch -- master Details ---

[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds. To ensure stable output, catch one more configuration-specific error. Back-patch to 9.3, like the commit that added the test. Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds. To ensure stable output, catch one more configuration-specific error. Back-patch to 9.3, like the commit that added the test. Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
for non-UTF8 databases, so preserve behavior there until the xpath facility can support such databases comprehensively. Back-patch to 9.3 (all supported versions). Pavel Stehule and Noah Misch Discussion: https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
for non-UTF8 databases, so preserve behavior there until the xpath facility can support such databases comprehensively. Back-patch to 9.3 (all supported versions). Pavel Stehule and Noah Misch Discussion: https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
for non-UTF8 databases, so preserve behavior there until the xpath facility can support such databases comprehensively. Back-patch to 9.3 (all supported versions). Pavel Stehule and Noah Misch Discussion: https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
for non-UTF8 databases, so preserve behavior there until the xpath facility can support such databases comprehensively. Back-patch to 9.3 (all supported versions). Pavel Stehule and Noah Misch Discussion: https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
for non-UTF8 databases, so preserve behavior there until the xpath facility can support such databases comprehensively. Back-patch to 9.3 (all supported versions). Pavel Stehule and Noah Misch Discussion: https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
for non-UTF8 databases, so preserve behavior there until the xpath facility can support such databases comprehensively. Back-patch to 9.3 (all supported versions). Pavel Stehule and Noah Misch Discussion: https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion:

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion:

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion:

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion:

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion:

[COMMITTERS] pgsql: In client support of v10 features, use standard schema handling.

2017-11-01 Thread Noah Misch
In client support of v10 features, use standard schema handling. Back-patch to v10. This continues the work of commit 080351466c5a669bf35a323bdec9e296330a5dbb. Discussion: https://postgr.es/m/CAKOSWN=ds66zlw2sqkltm8wbxfgdbc_odkmt3djfpt2me5k...@mail.gmail.com Branch -- master Details

[COMMITTERS] pgsql: In client support of v10 features, use standard schema handling.

2017-11-01 Thread Noah Misch
In client support of v10 features, use standard schema handling. Back-patch to v10. This continues the work of commit 080351466c5a669bf35a323bdec9e296330a5dbb. Discussion: https://postgr.es/m/CAKOSWN=ds66zlw2sqkltm8wbxfgdbc_odkmt3djfpt2me5k...@mail.gmail.com Branch -- REL_10_STABLE

Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-13 Thread Noah Misch
hu, Oct 12, 2017 at 10:44:20PM -0400, Tom Lane wrote: > Noah Misch <n...@leadboat.com> writes: > > On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote: > >> Noah, any chance you could force restrict to off on that animal? > > > I can confirm it allows &

Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-12 Thread Noah Misch
On Thu, Oct 12, 2017 at 04:48:29PM -0700, Andres Freund wrote: > On 2017-10-12 16:08:44 -0700, Andres Freund wrote: > > wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall > > -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement > > -Wendif-labels -Wmissing-format-attribute

Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-12 Thread Noah Misch
On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote: > So we've two animals (hornet, sungazer) that are: > #define SIZEOF_SIZE_T 8 > #define WORDS_BIGENDIAN 1 > #define restrict __restrict > > one compiled with xlc that fails and one with gcc that succeeds. I'm > hesitant to reach for

Re: [COMMITTERS] pgsql: Remove ICU tests from default run

2017-10-06 Thread Noah Misch
On Sat, Mar 25, 2017 at 04:30:45AM +, Peter Eisentraut wrote: > Remove ICU tests from default run > > These tests require the test database to be in UTF8 encoding. Until > there is a better solution, take them out of the default test set and > treat them like the existing collate.linux.utf8

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion:

[COMMITTERS] pgsql: Inject $(ICU_LIBS) regardless of platform.

2017-08-20 Thread Noah Misch
Inject $(ICU_LIBS) regardless of platform. It appeared in a conditional that excludes AIX, Cygwin and MinGW. Give ICU support a chance to work on those platforms. Back-patch to v10, where ICU support was introduced. Branch -- REL_10_STABLE Details ---

[COMMITTERS] pgsql: Inject $(ICU_LIBS) regardless of platform.

2017-08-20 Thread Noah Misch
Inject $(ICU_LIBS) regardless of platform. It appeared in a conditional that excludes AIX, Cygwin and MinGW. Give ICU support a chance to work on those platforms. Back-patch to v10, where ICU support was introduced. Branch -- master Details ---

[COMMITTERS] pgsql: Fix vertical spanning in table "wait_event Description".

2017-08-12 Thread Noah Misch
Fix vertical spanning in table "wait_event Description". Michael Paquier Discussion: https://postgr.es/m/cab7npqqr3keqvxeuunycm7tdk2fb9oluq8du0+y0rzeon_1...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e88928c50dfe2623c899f82b54aad69da248ad07

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the

[COMMITTERS] pgsql: Disclaim xmltable() support for non-UTF8 databases.

2017-08-07 Thread Noah Misch
Disclaim xmltable() support for non-UTF8 databases. The xmltable() implementation mirrors xpath(), including its lack of character encoding awareness. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b4a2eea030ba74ea84335c7d5bc999f693ffd9a4 Modified Files

[COMMITTERS] pgsql: MSVC: Finish clean.bat build artifact coverage.

2017-07-24 Thread Noah Misch
MSVC: Finish clean.bat build artifact coverage. With this, "git clean -dnx" is clear after a "clean dist" following a build. Preserve sql_help.h in non-dist cleans, like the Makefile does. Branch -- master Details ---

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-24 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_3_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-24 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_6_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-24 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-24 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- master Details ---

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-24 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_2_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-24 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Don't link libpgcommon into pgcrypto.

2017-07-17 Thread Noah Misch
MSVC: Don't link libpgcommon into pgcrypto. Doing so was useful in 273c458a2b3a0fb73968020ea5e9e35eb6928967 but became obsolete when 818fd4a67d610991757b610755e3065fb99d80a5 caused postgres.exe to provide the relevant symbols. No other loadable module links to libpgcommon directly. Branch

[COMMITTERS] pgsql: MSVC: Repair libpq.rc generator.

2017-07-09 Thread Noah Misch
MSVC: Repair libpq.rc generator. It generates an empty file, so libpq.dll advertises no version information. Commit facde2a98f0b5f7689b4e30a9e7376e926e733b8 mistranslated "print O;" in this one place. Branch -- master Details ---

[COMMITTERS] pgsql: Reconcile nodes/*funcs.c with PostgreSQL 10 work.

2017-06-16 Thread Noah Misch
Reconcile nodes/*funcs.c with PostgreSQL 10 work. The _equalTableFunc() omission of coltypmods has semantic significance, but I did not track down resulting user-visible bugs, if any. The other changes are cosmetic only, affecting order. catversion bump due to readfuncs.c field order change.

[COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Noah Misch
On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: > Annotate the fact that somebody added location fields to PartitionBoundSpec > and PartitionRangeDatum but forgot to handle them in > outfuncs.c/readfuncs.c. This is fairly harmless for production purposes > (since readfuncs.c would just

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented

  1   2   3   4   5   6   7   8   >