Re: [COMMITTERS] pgsql: Accept that server might not be able to send error in crash reco

2017-09-22 Thread Andres Freund
On 2017-09-22 13:30:14 -0400, Tom Lane wrote: > Andres Freund writes: > > Accept that server might not be able to send error in crash recovery test. > > piculet says you didn't cover all the bases: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2017-09-22%2017%3A10%3A01 >

Re: [COMMITTERS] pgsql: Accept that server might not be able to send error in crash reco

2017-09-22 Thread Tom Lane
Andres Freund writes: > Accept that server might not be able to send error in crash recovery test. piculet says you didn't cover all the bases: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2017-09-22%2017%3A10%3A01 Looks like you missed adding the "server closed the connec

[COMMITTERS] pgsql: Accept that server might not be able to send error in crash reco

2017-09-19 Thread Andres Freund
Accept that server might not be able to send error in crash recovery test. As it turns out we can't rely that the script's monitoring session is terminated with a proper error by the server, because the session might be terminated while already trying to send data. Also improve robustness and err