[COMMITTERS] pgsql: Actually, it's not that hard to merge the Windows pqsignal code

2015-08-31 Thread Tom Lane
Actually, it's not that hard to merge the Windows pqsignal code ... ... just need to typedef sigset_t and provide sigemptyset/sigfillset, which are easy enough. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f333204bbcd32091311b070e8f8ab4717dd8cadf Modified Files -

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, I'll bet the mingw problem is lack of $(BE_DLLLIBS) ...

2010-01-15 Thread Tom Lane
Log Message: --- Actually, I'll bet the mingw problem is lack of $(BE_DLLLIBS) ... Modified Files: -- pgsql/src/backend/replication/walreceiver: Makefile (r1.2 -> r1.3) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walreceiver/Make

[COMMITTERS] pgsql: Actually, we need to bump the format identifier on twophase files

2009-08-31 Thread Tom Lane
Log Message: --- Actually, we need to bump the format identifier on twophase files because of readjustment of 2PC rmgr IDs for flatfile removal. Modified Files: -- pgsql/src/backend/access/transam: twophase.c (r1.54 -> r1.55) (http://anoncvs.postgresql.org/

[COMMITTERS] pgsql: Actually, instead of whining about how type internal might not

2008-11-13 Thread Tom Lane
Log Message: --- Actually, instead of whining about how type internal might not safely store a pointer, why don't we just fix that. Every known use of "internal" really means a pointer anyway. Modified Files: -- pgsql/src/backend/utils/adt: array_userfuncs.c (r1.25

[COMMITTERS] pgsql: Actually ...

2007-11-22 Thread Tom Lane
Log Message: --- Actually ... it's pretty silly that parse_oper.c doesn't set up the opfuncid of an OpExpr initially, considering that it has the information at hand already. We'll still treat opfuncid as a cache rather than a guaranteed-valid value, but this change saves one more syscache

[COMMITTERS] pgsql: > Actually, if you submit a patch that says either "SCROLL is the

2006-02-12 Thread Bruce Momjian
Log Message: --- > Actually, if you submit a patch that says either "SCROLL is the default" > or "NO SCROLL is the default", it will be rejected as incorrect. The > reason is that the default behavior is different from either of these, > as is explained in the NOTES section. Ok, so *that'

[COMMITTERS] pgsql: > Actually, if you submit a patch that says either "SCROLL is the

2006-02-12 Thread Bruce Momjian
Log Message: --- > Actually, if you submit a patch that says either "SCROLL is the default" > or "NO SCROLL is the default", it will be rejected as incorrect. The > reason is that the default behavior is different from either of these, > as is explained in the NOTES section. Ok, so *that'

[COMMITTERS] pgsql: Actually there's a better way to do this, which is to count

2006-02-11 Thread Tom Lane
Log Message: --- Actually there's a better way to do this, which is to count tuples during the vacuumcleanup scan that we're going to do anyway. Should save a few cycles (one calculation per page, not per tuple) as well as not having to depend on assumptions about heap and index being in s

[COMMITTERS] pgsql: Actually, this macro had worse problems than a bogus name ...

2005-08-05 Thread Tom Lane
Log Message: --- Actually, this macro had worse problems than a bogus name ... Modified Files: -- pgsql/src/include/mb: pg_wchar.h (r1.60 -> r1.61) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/mb/pg_wchar.h.diff?r1=1.60&r2=1.61) --

[COMMITTERS] pgsql: Actually, nodeBitmapIndexscan.c doesn't need to create a standard

2005-04-24 Thread Tom Lane
Log Message: --- Actually, nodeBitmapIndexscan.c doesn't need to create a standard ExprContext at all, since it never evaluates any qual or tlist expressions. Modified Files: -- pgsql/src/backend/executor: nodeBitmapIndexscan.c (r1.4 -> r1.5) (http://develo