Peter,
* Peter Eisentraut ([email protected]) wrote:
> Add COMMENT and SECURITY LABEL support for publications and subscriptions
Isn't this missing psql tab completion, and pg_dump support? And
regression tests for the latter?
Thanks!
Stephen
signature.asc
Description: Digital signature
Add COMMENT and SECURITY LABEL support for publications and subscriptions
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/87dee41f3ed6d6c2a93e7ff359776cfe24f145e0
Modified Files
--
doc/src/sgml/ref/comment.sgml | 2 ++
doc/src/sgml/re
Add comment & docs about no vacuum truncation with sto.
Omission noted by Andres Freund.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/1c15aac53f3421fd38ae145118d3204f055ba955
Modified Files
--
doc/src/sgml/config.sgml | 9 +
src/backen
Add comment about intentional fallthrough in switch.
Coverity complained about an apparent missing "break" in a switch
added by bb140506df605fab. The human-readable comments are pretty
clear that this is intentional, but add a standard /* FALL THRU */
comment to make it clear to tools too.
Branc
Add comment for "is_internal" parameter
This was missed in my commit f4c4335 of 9.3 vintage, so backpatch to
that.
Branch
--
REL9_4_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/2570e28827e3ac4a316300f92dfaf448e55c8e0c
Modified Files
--
src/backend/catalog/heap.
Add comment for "is_internal" parameter
This was missed in my commit f4c4335 of 9.3 vintage, so backpatch to
that.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/6f9d79904748c26a58991942dc6719db558f77b0
Modified Files
--
src/backend/catalog/heap.c |
Add comment for "is_internal" parameter
This was missed in my commit f4c4335 of 9.3 vintage, so backpatch to
that.
Branch
--
REL9_3_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/73f236f5793e25f04933247917092de39011afd9
Modified Files
--
src/backend/catalog/heap.
Add comment that ec_relids excludes "child" EquivalenceClass members.
This was already documented a few lines further down, but the comment
just beside the field declaration could be misleading. Per gripe
from Kyotaro Horiguchi.
Branch
--
master
Details
---
http://git.postgresql.org/pg/
Add comment for VARSIZE_ANY_EXHDR macro
Gurjeet Singh
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/0f59f4a645ec92e580baa4c8feb9f285a8279a15
Modified Files
--
src/include/postgres.h |1 +
1 file changed, 1 insertion(+)
--
Sent via pgsql-committer
Add comment why seemingly dead code is necessary
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/a76c857eba977a91a07ab752d4811eb5734f0b5c
Modified Files
--
src/pl/plperl/plperl.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
--
Sen
Add comment for missing break in switch
For clarity, following other sites, and to silence Coverity.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/c9f310d377d1d8f8acd2d05bf7920704d33affe5
Modified Files
--
src/backend/utils/adt/formatting.c |1 +
1
Add comment about skipping binary files for copyright changes.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/a8ab8d0eaa96dbaebb646971f8988a3edc28e52c
Modified Files
--
src/tools/copyright.pl |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
-
Add comment on why pulling data from a "name" index column can't crash.
It's been bothering me for several days that pretending that the cstring
data stored in a btree name_ops column is really a "name" Datum could lead
to reading past the end of memory. However, given the current memory
layout u
Add comment that attributes.is_nullable was removed from SQL standard
We don't have to remove the column if no one is bothered, but it's
useful to comment on it in case someone looks for it in newer
standards versions.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/
Add comment about pg_ctl stop
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/d69149ed71cc4f073f222f11f702a20a6d279e0c
Modified Files
--
src/tools/pgindent/README |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
--
Sent via pgsql-committers m
Add comment about memory reordering to PredicateLockTupleRowVersionLink.
Dan Ports, per head-scratching from Simon Riggs and myself.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/71932ecc2b6ca0d748176a7e8b11d3575bf4caf3
Modified Files
--
src/backend/st
Add comment to tools/git-external-diff.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/dae1e5546cdff98d85215a461f108f71fd254441
Modified Files
--
src/tools/git-external-diff |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
--
Sent via pgsq
Add comment on why we're passing a useless 'false' to the plperl function
compiler.
It's for compatibility with modules like PostgreSQL::PLPerl::NYTProf.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c73fe72e2735d20aa132640d8fab4e0eca1ced
Log Message:
---
Add comment about why "((void) 0)" is used in copy macros.
Modified Files:
--
pgsql/src/backend/commands:
copy.c (r1.309 -> r1.310)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c?r1=1.309&r2=1.310)
--
Sent via
Log Message:
---
Add comment about why BETWEEN uses operator strings and not opclasses,
with URL pointing to email discussion.
Modified Files:
--
pgsql/src/backend/parser:
gram.y (r2.651 -> r2.652)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend
Log Message:
---
Add comment that it is difficult to access the more accurate
'query_string' from current_query().
Modified Files:
--
pgsql/src/backend/utils/adt:
misc.c (r1.67 -> r1.68)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/
Log Message:
---
Add comment about GNUWin32's cp not having the file system problem.
Modified Files:
--
pgsql/contrib/pg_standby:
pg_standby.c (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_standby/pg_standby.c?r1=1.14&r2=1.15)
Log Message:
---
Add comment about the use of EXEC_BACKEND.
Modified Files:
--
pgsql/src/backend/postmaster:
postmaster.c (r1.564 -> r1.565)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c?r1=1.564&r2=1.565)
--
Sent via
Log Message:
---
Add comment about why pg_dump doesn't dump the public schema comment.
Modified Files:
--
pgsql/src/bin/pg_dump:
pg_backup_archiver.c (r1.157 -> r1.158)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_archiver.c?r1=
Log Message:
---
Add comment about the two different query strings that ExecuteQuery()
has to deal with.
Modified Files:
--
pgsql/src/backend/commands:
prepare.c (r1.88 -> r1.89)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/prepare.c
Log Message:
---
Add comment about literal strings in our syntax not being translated in
psql.
Modified Files:
--
pgsql/src/bin/psql:
describe.c (r1.178 -> r1.179)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c?r1=1.178&r2=1.179)
-
Log Message:
---
Add comment for deadlock_timeout:
/* This is PGC_SIGHUP so all backends have the same value. */
Modified Files:
--
pgsql/src/backend/utils/misc:
guc.c (r1.462 -> r1.463)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/u
Log Message:
---
Add comment about possible URL changes for www7.hp.com:
Modified Files:
--
pgsql/doc/src/sgml:
libpq.sgml (r1.253 -> r1.254)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/libpq.sgml?r1=1.253&r2=1.254)
runtime.s
Log Message:
---
Add comment about COMMENT ON DATABASE failing for differently-named
databases.
Modified Files:
--
pgsql/src/bin/pg_dump:
pg_dump.c (r1.477 -> r1.478)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.477&r2=1.
Log Message:
---
Add comment.
Modified Files:
--
pgsql/src/tools:
pgcvslog (r1.38 -> r1.39)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgcvslog?r1=1.38&r2=1.39)
---(end of broadcast)---
TIP 3
Log Message:
---
Add comment about cvs branch numbers.
Modified Files:
--
pgsql/src/tools:
pgcvslog (r1.37 -> r1.38)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgcvslog?r1=1.37&r2=1.38)
---(end of broadcast)
Log Message:
---
Add comment on why SGML -wfully-tagged flag is needed (for older SGML
tool chains).
Modified Files:
--
pgsql/doc/src/sgml:
Makefile (r1.98 -> r1.99)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/Makefile?r1=1.98&r2=1.99)
-
Log Message:
---
Add comment on why deadlock detection error messages only prints numbers.
Modified Files:
--
pgsql/src/backend/storage/lmgr:
deadlock.c (r1.46 -> r1.47)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/deadlock.c.d
Log Message:
---
Add comment that pg_dump 'append' format is used only by pg_dump, per
Dave Page.
Modified Files:
--
pgsql/src/bin/pg_dump:
pg_dump.c (r1.463 -> r1.464)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.46
Log Message:
---
Add comment that on Win32, we don't need to check the .pgpass file
permission, per Magnus.
Modified Files:
--
pgsql/src/interfaces/libpq:
fe-connect.c (r1.343 -> r1.344)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq
Log Message:
---
Add comment to explain why O_EXCL and O_TRUNC can be ignored in
openFlagsToCreateFileFlags() in certain cases.
Modified Files:
--
pgsql/src/port:
open.c (r1.18 -> r1.19)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/port/open.c.diff
Log Message:
---
Add comment that to_char() for broken glibc pt_BR might cause a problem.
Modified Files:
--
pgsql/src/backend/utils/adt:
formatting.c (r1.122 -> r1.123)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/formatting.c.di
Log Message:
---
Add comment noting that hashm_procid in a hash index's metapage isn't
actually used for anything.
Modified Files:
--
pgsql/src/backend/access/hash:
hashpage.c (r1.63 -> r1.64)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/ac
Log Message:
---
Add comment about exception lists in both winnt.h and ntstatus.h.
Modified Files:
--
pgsql/src/include/port:
win32.h (r1.69 -> r1.70)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/port/win32.h.diff?r1=1.69&r2=1.70)
Log Message:
---
Add comment about the use of pg_config_paths.h.
Modified Files:
--
pgsql/src/port:
Makefile (r1.31 -> r1.32)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/port/Makefile.diff?r1=1.31&r2=1.32)
---(end of broad
Log Message:
---
Add comment for why we recompile pgport C files.
# Need to recomple any libpgport object files because we need these
# object files to use the same compile flags as libpq. If we used
# the object files from libpgport, this would not be true on all
# platforms.
Modified F
Log Message:
---
Add comment about localized month names for to_date and to_timestamp.
Modified Files:
--
pgsql/src/backend/utils/adt:
formatting.c (r1.106 -> r1.107)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/formatting.c.diff?
Log Message:
---
Add comment explaining why RelationOpenSmgr() call is not needed.
Modified Files:
--
pgsql/src/backend/executor:
execMain.c (r1.262 -> r1.263)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c.diff?r1=1.262&r
Log Message:
---
Add comment on why pg *printf functions are used unconditionally on
Win32.
Backpatch to 8.1.X.
Tags:
REL8_1_STABLE
Modified Files:
--
pgsql:
configure (r1.461.2.1 -> r1.461.2.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/confi
Log Message:
---
Add comment on why pg *printf functions are used unconditionally on
Win32.
Backpatch to 8.1.X.
Modified Files:
--
pgsql:
configure (r1.464 -> r1.465)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.diff?r1=1.464&r2=1.465)
Log Message:
---
Add comment to pg_atoi.
Modified Files:
--
pgsql/src/backend/utils/adt:
numutils.c (r1.70 -> r1.71)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/numutils.c.diff?r1=1.70&r2=1.71)
---(end of
Log Message:
---
Add comment documenting actual failure case of using
interval_justify_hours in timestamp subtraction. TODO already has text
description.
Modified Files:
--
pgsql/src/backend/utils/adt:
timestamp.c (r1.156 -> r1.157)
(http://developer.postg
Log Message:
---
Add comment about pthread_self() cast.
Modified Files:
--
pgsql/src/interfaces/libpq:
fe-secure.c (r1.70 -> r1.71)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-secure.c.diff?r1=1.70&r2=1.71)
---
Log Message:
---
Add comment explaining that autoconf's failure to find getaddrinfo()
on Windows is now a feature, not a bug.
Modified Files:
--
pgsql:
configure.in (r1.424 -> r1.425)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.in.diff?r1=1.
Log Message:
---
Add comment about void* use in MemSet.
Modified Files:
--
pgsql/src/include:
c.h (r1.188 -> r1.189)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h.diff?r1=1.188&r2=1.189)
pgsql/src/include/utils:
timestamp.h (
Log Message:
---
Add comment marking non-exact time conversion macros.
Modified Files:
--
pgsql/src/include/utils:
timestamp.h (r1.48 -> r1.49)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/timestamp.h.diff?r1=1.48&r2=1.49)
pgsql/s
Log Message:
---
Add comment about \# in bcc makefiles.
Modified Files:
--
pgsql/src/bin/psql:
bcc32.mak (r1.13 -> r1.14)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/bcc32.mak.diff?r1=1.13&r2=1.14)
---(end of broa
Log Message:
---
Add comment about \# in bcc makefiles.
Modified Files:
--
pgsql/src/interfaces/libpq:
bcc32.mak (r1.18 -> r1.19)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/bcc32.mak.diff?r1=1.18&r2=1.19)
---
Log Message:
---
Add comment on tilde expansion.
Modified Files:
--
pgsql/src/bin/psql:
common.c (r1.98 -> r1.99)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.c.diff?r1=1.98&r2=1.99)
---(end of broadcast)---
Log Message:
---
Add comment for multi-byte computation.
Modified Files:
--
pgsql/src/backend/parser:
parse_expr.c (r1.182 -> r1.183)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_expr.c.diff?r1=1.182&r2=1.183)
Log Message:
---
Add comment on C locale test for upper/lower/initcap().
Modified Files:
--
pgsql/src/backend/utils/adt:
oracle_compat.c (r1.59 -> r1.60)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/oracle_compat.c.diff?r1=1.59&r2
Log Message:
---
Add comment about checkpoint panic behavior during shutdown, per
suggestion from Qingqing Zhou.
Modified Files:
--
pgsql/src/backend/access/transam:
xlog.c (r1.187 -> r1.188)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/acc
Log Message:
---
Add comment about permissions on pg_ts* tables
Modified Files:
--
pgsql/contrib/tsearch2/docs:
tsearch-V2-intro.html (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/tsearch2/docs/tsearch-V2-intro.html.diff?r1=1.5&r2
Log Message:
---
Add comment about permissions on pg_ts* tables
Tags:
REL7_4_STABLE
Modified Files:
--
pgsql/contrib/tsearch2/docs:
tsearch-V2-intro.html (r1.2 -> r1.2.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/tsearch2/docs/tsearc
Log Message:
---
Add comment about permissions on pg_ts* tables
Tags:
REL8_0_STABLE
Modified Files:
--
pgsql/contrib/tsearch2/docs:
tsearch-V2-intro.html (r1.5 -> r1.5.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/tsearch2/docs/tsearc
Log Message:
---
Add comment explaining possible compiler warning:
/*
* Some compilers with throw a warning knowing this test can never be
* true because off_t can't exceed the compared maximum.
*/
if (th->fileLen > MAX_TAR_MEMBER_FILELEN)
die_horribly(AH,
Log Message:
---
Add comment to postmaster.c that get_progname() will call exit if it
can't strdup().
Modified Files:
--
pgsql/src/backend/postmaster:
postmaster.c (r1.435 -> r1.436)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/p
Log Message:
---
Add comment about memory failure of get_progname exiting the postmaster:
exit(1);/* This could exit the postmaster */
Modified Files:
--
pgsql/src/port:
path.c (r1.40 -> r1.41)
(http://developer.postgresql.org/cvsweb.cgi/pg
63 matches
Mail list logo
