Re: [COMMITTERS] pgsql: Add pg_noinline macro to c.h.

2017-10-13 Thread Andres Freund
On 2017-10-13 18:32:08 -0400, Tom Lane wrote: > Andres Freund writes: > > Add pg_noinline macro to c.h. > > I think you want this to be parenthesized so that pgindent doesn't > go nuts when you use it. At least, that was the reason why > pg_attribute_noreturn() has parens. Even if the current v

Re: [COMMITTERS] pgsql: Add pg_noinline macro to c.h.

2017-10-13 Thread Tom Lane
Andres Freund writes: > Add pg_noinline macro to c.h. I think you want this to be parenthesized so that pgindent doesn't go nuts when you use it. At least, that was the reason why pg_attribute_noreturn() has parens. Even if the current version of pgindent doesn't have that problem, I would argu

[COMMITTERS] pgsql: Add pg_noinline macro to c.h.

2017-10-13 Thread Andres Freund
Add pg_noinline macro to c.h. Forcing a function not to be inlined can be useful if it's the slow-path of a performance critical function, or should be visible in profiles to allow for proper cost attribution. Author: Andres Freund Discussion: https://postgr.es/m/20170914061207.zxotvyopetm7l...@