On Sun, Jul 11, 2010 at 00:05, Peter Eisentraut wrote:
> On lör, 2010-07-10 at 16:23 -0400, Bruce Momjian wrote:
>> Wow, how would they know if the binaries are MinGW compiled? Does it
>> show in version()?
>
> Yes, I think so.
It definitely does.
--
Magnus Hagander
Me: http://www.hagander.n
On lör, 2010-07-10 at 16:23 -0400, Bruce Momjian wrote:
> Wow, how would they know if the binaries are MinGW compiled? Does it
> show in version()?
Yes, I think so.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.post
Bruce Momjian writes:
> Magnus Hagander wrote:
>> That laves the questions of docs - right now the docs just say it
>> works on windows. I guess we need to add some kind of disclaimer
>> around that, but the fact is that for 99+% of our windows users it
>> will work - since they use the binaries,
Magnus Hagander wrote:
> > An easy approximation would be to make the code #ifdef SIO_KEEPALIVE_VALS.
> > That would fail if the mingw guys decide to provide the #define without
> > adding the struct at the same time, but that seems moderately unlikely.
>
> Seems reasonable. I'll go do something a
Magnus Hagander writes:
> On Thu, Jul 8, 2010 at 18:37, Tom Lane wrote:
>> This is still going to need manual adjustment in the future,
> And it's far from certain they'll actually add it to mstcpip.h -
> sometimes they stick it in a different header...
Yeah, that's the other reason for waiting
On Thu, Jul 8, 2010 at 18:37, Tom Lane wrote:
> Magnus Hagander writes:
>> Here's what I came up with and will apply as soon as my msvc build
>> completes. (the mingw one works with this)
>
> This is still going to need manual adjustment in the future, since
> probably when mingw adds the #define
Magnus Hagander writes:
> Here's what I came up with and will apply as soon as my msvc build
> completes. (the mingw one works with this)
This is still going to need manual adjustment in the future, since
probably when mingw adds the #define, they will put it in ,
and this code will not see it.
On Thu, Jul 8, 2010 at 18:06, Magnus Hagander wrote:
> On Thu, Jul 8, 2010 at 17:45, Andrew Dunstan wrote:
>>
>>
>> Tom Lane wrote:
>>>
>>> Magnus Hagander writes:
>>>
Seems pretty simple - mingw doesn't have support for this. We have two
ways to deal with that I think:
1) Di
On Thu, Jul 8, 2010 at 17:45, Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>>
>> Magnus Hagander writes:
>>
>>>
>>> Seems pretty simple - mingw doesn't have support for this. We have two
>>> ways to deal with that I think:
>>> 1) Disable it on mingw.
>>> 2) Include it in our custom headers.
>>>
>>
Tom Lane wrote:
Magnus Hagander writes:
Seems pretty simple - mingw doesn't have support for this. We have two
ways to deal with that I think:
1) Disable it on mingw.
2) Include it in our custom headers.
For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as
well
On Thu, Jul 8, 2010 at 17:39, Tom Lane wrote:
> Magnus Hagander writes:
>> Seems pretty simple - mingw doesn't have support for this. We have two
>> ways to deal with that I think:
>> 1) Disable it on mingw.
>> 2) Include it in our custom headers.
>
>> For #2, what we need to include is the defin
On Thu, Jul 8, 2010 at 17:11, Magnus Hagander wrote:
> On Thu, Jul 8, 2010 at 17:04, Tom Lane wrote:
>> m...@postgresql.org (Magnus Hagander) writes:
>>> Log Message:
>>> ---
>>> Add support for TCP keepalives on Windows, both for backend and the new
>>> libpq support.
>>
>> Buildfarm mem
Magnus Hagander writes:
> Seems pretty simple - mingw doesn't have support for this. We have two
> ways to deal with that I think:
> 1) Disable it on mingw.
> 2) Include it in our custom headers.
> For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as
> well as the definition of
On Thu, Jul 8, 2010 at 17:04, Tom Lane wrote:
> m...@postgresql.org (Magnus Hagander) writes:
>> Log Message:
>> ---
>> Add support for TCP keepalives on Windows, both for backend and the new
>> libpq support.
>
> Buildfarm member narwhal doesn't like this patch. You have about six
> or e
m...@postgresql.org (Magnus Hagander) writes:
> Log Message:
> ---
> Add support for TCP keepalives on Windows, both for backend and the new
> libpq support.
Buildfarm member narwhal doesn't like this patch. You have about six
or eight hours to fix or revert it before beta3 wraps.
Log Message:
---
Add support for TCP keepalives on Windows, both for backend and the new
libpq support.
Modified Files:
--
pgsql/src/backend/libpq:
pqcomm.c (r1.210 -> r1.211)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/pqcomm.c?r1=1.2
16 matches
Mail list logo
