On Mon, Oct 24, 2016 at 2:58 PM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> I have following warning while compiling with clang.
>
> walmethods.c:437:9: warning: comparison of unsigned expression < 0 is
> always false [-Wtautological-compare]
> if (r < 0)
>
I have following warning while compiling with clang.
walmethods.c:437:9: warning: comparison of unsigned expression < 0 is
always false [-Wtautological-compare]
if (r < 0)
~ ^ ~
1 warning generated.
It seems that 'r' should be 'ssize_t' instead of 'size_t'.
--
On Sun, Oct 23, 2016 at 5:48 PM, Tom Lane wrote:
> Magnus Hagander writes:
> > The remaining windows buildfarm build issue looks like this:
> > src/bin/pg_basebackup/receivelog.c(135): error C2039: '_commit' : is
> > not a member of 'WalWriteMethod'
> > [C:\buildfarm\buildenv\HEAD\pgsql.build\
Magnus Hagander writes:
> The remaining windows buildfarm build issue looks like this:
> src/bin/pg_basebackup/receivelog.c(135): error C2039: '_commit' : is
> not a member of 'WalWriteMethod'
> [C:\buildfarm\buildenv\HEAD\pgsql.build\pg_basebackup.vcxproj]
> AFAICT this comes from using walmeth
The remaining windows buildfarm build issue looks like this:
src/bin/pg_basebackup/receivelog.c(135): error C2039: '_commit' : is
not a member of 'WalWriteMethod'
[C:\buildfarm\buildenv\HEAD\pgsql.build\pg_basebackup.vcxproj]
AFAICT this comes from using walmethod->fsync(), and we have a #defi
That broke some buildfarm. Looking into it.
//Magnus
On Sun, Oct 23, 2016 at 3:28 PM, Magnus Hagander
wrote:
> Allow pg_basebackup to stream transaction log in tar mode
>
> This will write the received transaction log into a file called
> pg_wal.tar(.gz) next to the other tarfiles instead of wr
Allow pg_basebackup to stream transaction log in tar mode
This will write the received transaction log into a file called
pg_wal.tar(.gz) next to the other tarfiles instead of writing it to
base.tar. When using fetch mode, the transaction log is still written to
base.tar like before, and when used
