[COMMITTERS] pgsql: Always build a custom plan node's targetlist from the path's pat

2017-04-17 Thread Tom Lane
Always build a custom plan node's targetlist from the path's pathtarget. We were applying the use_physical_tlist optimization to all relation scan plans, even those implemented by custom scan providers. However, that's a bad idea for a couple of reasons. The custom provider might be unable to pr

[COMMITTERS] pgsql: Always build a custom plan node's targetlist from the path's pat

2017-04-17 Thread Tom Lane
Always build a custom plan node's targetlist from the path's pathtarget. We were applying the use_physical_tlist optimization to all relation scan plans, even those implemented by custom scan providers. However, that's a bad idea for a couple of reasons. The custom provider might be unable to pr

[COMMITTERS] pgsql: Always build a custom plan node's targetlist from the path's pat

2017-04-17 Thread Tom Lane
Always build a custom plan node's targetlist from the path's pathtarget. We were applying the use_physical_tlist optimization to all relation scan plans, even those implemented by custom scan providers. However, that's a bad idea for a couple of reasons. The custom provider might be unable to pr