Re: [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.

2017-10-12 Thread Tom Lane
Robert Haas writes: > Avoid coercing a whole-row variable that is already coerced. This logic seems very strange and more than likely buggy: the added coerced_var flag feels like the sort of action at a distance that is likely to have unforeseen side effects. I'm not entirely sure what the issue

[COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.

2017-10-12 Thread Robert Haas
Avoid coercing a whole-row variable that is already coerced. Marginal efficiency and beautification hack. I'm not sure whether this case ever arises currently, but the pending patch for update tuple routing will cause it to arise. Amit Khandekar Discussion: http://postgr.es/m/caj3gd9cazfppe7-w