Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Heikki Linnakangas
On 08.09.2011 23:44, Tom Lane wrote: Andrew Dunstan writes: Maybe we need to include math.h. And while we're about it, should the result of round() be cast to an int, since that's what the function returns? Or use rint(), which we certainly have. Yeah, this broke the build on my old HPUX b

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Tom Lane
Andrew Dunstan writes: >> Maybe we need to include math.h. And while we're about it, should the >> result of round() be cast to an int, since that's what the function >> returns? > Or use rint(), which we certainly have. Yeah, this broke the build on my old HPUX box too. I committed a quick f

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Andrew Dunstan
On 09/08/2011 04:13 PM, Andrew Dunstan wrote: On 09/08/2011 10:56 AM, Heikki Linnakangas wrote: Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Andrew Dunstan
On 09/08/2011 10:56 AM, Heikki Linnakangas wrote: Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that would otherwise be needed to traverse all

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Heikki Linnakangas
On 08.09.2011 18:04, Thom Brown wrote: On 8 September 2011 15:56, Heikki Linnakangas wrote: Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Thom Brown
On 8 September 2011 15:56, Heikki Linnakangas wrote: > Buffering GiST index build algorithm. > > When building a GiST index that doesn't fit in cache, buffers are attached > to some internal nodes in the index. This speeds up the build by avoiding > random I/O that would otherwise be needed to tra

[COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Heikki Linnakangas
Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that would otherwise be needed to traverse all the way down the tree to the find right leaf page for