Re: [COMMITTERS] pgsql: Checkpoint sorting and balancing.

2016-03-10 Thread Michael Paquier
On Fri, Mar 11, 2016 at 2:29 AM, Andres Freund wrote: > Checkpoint sorting and balancing. +1. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Checkpoint sorting and balancing.

2016-03-10 Thread Peter Eisentraut
On 3/10/16 8:52 PM, Andres Freund wrote: > Hrmpf. I tried to fix the issue; could you quickly verify? looks good -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Checkpoint sorting and balancing.

2016-03-10 Thread Andres Freund
On 2016-03-10 20:47:10 -0500, Peter Eisentraut wrote: > On 3/10/16 8:29 PM, Andres Freund wrote: > > Checkpoint sorting and balancing. > > This patch appears to have introduced a change that makes the build > with dtrace fail: > > In file included from ../../../../src/include/pg_trace.h:15:0, >

Re: [COMMITTERS] pgsql: Checkpoint sorting and balancing.

2016-03-10 Thread Peter Eisentraut
On 3/10/16 8:29 PM, Andres Freund wrote: > Checkpoint sorting and balancing. This patch appears to have introduced a change that makes the build with dtrace fail: In file included from ../../../../src/include/pg_trace.h:15:0, from bufmgr.c:42: bufmgr.c: In function 'BufferSync':

[COMMITTERS] pgsql: Checkpoint sorting and balancing.

2016-03-10 Thread Andres Freund
Checkpoint sorting and balancing. Up to now checkpoints were written in the order they're in the BufferDescriptors. That's nearly random in a lot of cases, which performs badly on rotating media, but even on SSDs it causes slowdowns. To avoid that, sort checkpoints before writing them out. We cur