[COMMITTERS] pgsql: Code cleanup in SyncRepWaitForLSN()

2016-08-12 Thread Simon Riggs
Code cleanup in SyncRepWaitForLSN() Commit 14e8803f1 removed LWLocks when accessing MyProc->syncRepState but didn't clean up the surrounding code and comments. Cleanup and backpatch to 9.5, to keep code similar. Julien Rouhaud, improved by suggestion from Michael Paquier, implemented trivially b

[COMMITTERS] pgsql: Code cleanup in SyncRepWaitForLSN()

2016-08-12 Thread Simon Riggs
Code cleanup in SyncRepWaitForLSN() Commit 14e8803f1 removed LWLocks when accessing MyProc->syncRepState but didn't clean up the surrounding code and comments. Cleanup and backpatch to 9.5, to keep code similar. Julien Rouhaud, improved by suggestion from Michael Paquier, implemented trivially b

Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.

2016-02-10 Thread Heikki Linnakangas
On 10/02/16 17:12, Robert Haas wrote: Code cleanup in the wake of recent LWLock refactoring. As of commit c1772ad9225641c921545b35c84ee478c326b95e, there's no longer any way of requesting additional LWLocks in the main tranche, so we don't need NumLWLocks() or LWLockAssign() any more. Also, som

[COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring.

2016-02-10 Thread Robert Haas
Code cleanup in the wake of recent LWLock refactoring. As of commit c1772ad9225641c921545b35c84ee478c326b95e, there's no longer any way of requesting additional LWLocks in the main tranche, so we don't need NumLWLocks() or LWLockAssign() any more. Also, some of the allocation counters that we had

[COMMITTERS] pgsql: Code cleanup for REINDEX DATABASE/SCHEMA/SYSTEM.

2015-03-08 Thread Tom Lane
Code cleanup for REINDEX DATABASE/SCHEMA/SYSTEM. Fix some minor infelicities. Some of these things were introduced in commit fe263d115a7dd16095b8b8f1e943aff2bb4574d2, and some are older. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/90c35a9ed06c1353a0d3818c259e629

[COMMITTERS] pgsql: Code cleanup for heap_freeze_tuple.

2012-03-26 Thread Robert Haas
Code cleanup for heap_freeze_tuple. It used to be case that lazy vacuum could call this function with only a shared lock on the buffer, but neither lazy vacuum nor any other code path does that any more. Simplify the code accordingly and clean up some related, obsolete comments. Branch -- ma

[COMMITTERS] pgsql: Code cleanup for InitProcGlobal.

2011-06-11 Thread Robert Haas
Code cleanup for InitProcGlobal. The old code creates three separate arrays when only one is needed, using two different shmem allocation functions for no obvious reason. It also strangely splits up the initialization of AuxilaryProcs between the top and bottom of the function to no evident purpos

[COMMITTERS] pgsql: Code cleanup for assign_transaction_read_only.

2011-01-22 Thread Robert Haas
Code cleanup for assign_transaction_read_only. As in commit fb4c5d2798730f60b102d775f22fb53c26a6445d on 2011-01-21, this avoids spurious debug messages and allows idempotent changes at any time. Along the way, make assign_XactIsoLevel allow idempotent changes even when not within a subtransaction

[COMMITTERS] pgsql: Code cleanup for assign_XactIsoLevel.

2011-01-21 Thread Robert Haas
Code cleanup for assign_XactIsoLevel. The new coding avoids a spurious debug message when a transaction that has changed the isolation level has been rolled back. It also allows the property to be freely changed to the current value within a subtransaction. Kevin Grittner, with one small change

[COMMITTERS] pgsql: Code cleanup: use "bool" for Boolean variables, rather than

2007-05-27 Thread Neil Conway
Log Message: --- Code cleanup: use "bool" for Boolean variables, rather than "int". Modified Files: -- pgsql/src/backend/utils/adt: datetime.c (r1.178 -> r1.179) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c.diff?r1=1.17

[COMMITTERS] pgsql: Code cleanup for the new regexp UDFs: we can hardcode the OID and

2007-03-28 Thread Neil Conway
Log Message: --- Code cleanup for the new regexp UDFs: we can hardcode the OID and some properties of the "text" type, and then simplify the code accordingly. Patch from Jeremy Drake. Modified Files: -- pgsql/src/backend/utils/adt: regexp.c (r1.70 -> r1.71)

[COMMITTERS] pgsql: Code cleanup: mark some variables with the "const" modifier, when

2007-03-18 Thread Neil Conway
Log Message: --- Code cleanup: mark some variables with the "const" modifier, when they are initialized with a string literal. Patch from Stefan Huehner. Modified Files: -- pgsql/src/backend/utils/adt: ruleutils.c (r1.255 -> r1.256) (http://developer.postgr

[COMMITTERS] pgsql: Code cleanup for pg_buffercache, from Mark Kirkwood.

2006-10-22 Thread Tom Lane
Log Message: --- Code cleanup for pg_buffercache, from Mark Kirkwood. Modified Files: -- pgsql/contrib/pg_buffercache: pg_buffercache_pages.c (r1.10 -> r1.11) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_buffercache/pg_buffercache_pages.c.di

[COMMITTERS] pgsql: Code cleanup for log_disconnections().

2005-10-05 Thread Neil Conway
Log Message: --- Code cleanup for log_disconnections(). Patch from Qingqing Zhou, fixes by Neil Conway. Modified Files: -- pgsql/src/backend/tcop: postgres.c (r1.463 -> r1.464) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c.di

[COMMITTERS] pgsql: Code cleanup.

2005-07-28 Thread Bruce Momjian
Log Message: --- Code cleanup. Modified Files: -- pgsql/src/backend/libpq: hba.c (r1.144 -> r1.145) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/hba.c.diff?r1=1.144&r2=1.145) ---(end of broadcast)-

[COMMITTERS] pgsql: Code cleanup.

2005-06-28 Thread Teodor Sigaev
Log Message: --- Code cleanup. gistfillbuffer accepts InvalidOffsetNumber. Modified Files: -- pgsql/src/backend/access/gist: gist.c (r1.122 -> r1.123) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gist/gist.c.diff?r1=1.122&r2=1.123)

[COMMITTERS] pgsql: Code cleanup: remove 3 duplicate static function declarations.

2005-06-23 Thread Neil Conway
Log Message: --- Code cleanup: remove 3 duplicate static function declarations. Modified Files: -- pgsql/src/backend/utils/adt: formatting.c (r1.89 -> r1.90) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/formatting.c.diff?r1=1.89&r

[COMMITTERS] pgsql: Code cleanup: in C89, there is no point casting the first

2005-05-10 Thread Neil Conway
Log Message: --- Code cleanup: in C89, there is no point casting the first argument to memset() or MemSet() to a char *. For one, memset()'s first argument is a void *, and further void * can be implicitly coerced to/from any other pointer type. Modified Files: -- pgsql/src

[COMMITTERS] pgsql: Code cleanup in path.c and exec.c.

2004-11-05 Thread Tom Lane
Log Message: --- Code cleanup in path.c and exec.c. Handle Windows drive and network specs everywhere not just some places, get rid of . and .. when joining path sections together. This should eliminate most of the ugly paths like /foo/bar/./baz that we've been generating. Modified Files

[COMMITTERS] pgsql: Code cleanup in dirmod.c.

2004-10-28 Thread Tom Lane
Log Message: --- Code cleanup in dirmod.c. Andrew Dunstan, some further mods by moi. Modified Files: -- pgsql/src/port: dirmod.c (r1.31 -> r1.32) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/port/dirmod.c.diff?r1=1.31&r2=1.32) ---