Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-19 Thread Andres Freund
On 2014-03-19 22:12:28 +0900, Fujii Masao wrote: > LOGICAL option was added into CREATE_REPLICATION_SLOT, but it's not > been documented. > protocol.sgml should be updated? Yes, it should. There's some other things I noticed should be expanded upon, most notably the importance of feedbacks when re

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-19 Thread Fujii Masao
On Wed, Mar 19, 2014 at 10:06 PM, Andres Freund wrote: > On 2014-03-19 21:59:25 +0900, Fujii Masao wrote: >> Attached patch changes the example that way and does some minor improvements. > > That patch is fine with me. Thanks for checking the patch! Will commit. LOGICAL option was added into CRE

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-19 Thread Andres Freund
On 2014-03-19 21:59:25 +0900, Fujii Masao wrote: > Attached patch changes the example that way and does some minor improvements. That patch is fine with me. Thanks, Andres Freund -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription:

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-19 Thread Fujii Masao
On Wed, Mar 19, 2014 at 2:21 AM, Robert Haas wrote: > Documentation for logical decoding. > > Craig Ringer, Andres Freund, Christian Kruse, with edits by me. > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/commitdiff/49c0864d7ef5227faa24f903902db90e5c9d5d69 > > Mo

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Thom Brown
On 18 March 2014 18:16, Andres Freund wrote: > On 2014-03-18 18:12:25 +, Thom Brown wrote: >> I'd have put this in a patch, but I don't know if the output in the >> example is wrong, or just dependent on environmental factors. > > It's out of date, it should be integer now, so please submit a

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Andres Freund
On 2014-03-18 18:12:25 +, Thom Brown wrote: > I'd have put this in a patch, but I don't know if the output in the > example is wrong, or just dependent on environmental factors. It's out of date, it should be integer now, so please submit a bug. I wonder if we should change stuff that types a

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Thom Brown
On 18 March 2014 17:21, Robert Haas wrote: > Documentation for logical decoding. > > Craig Ringer, Andres Freund, Christian Kruse, with edits by me. In doc/src/sgml/logicaldecoding.sgml: s/demonstartes/demonstrates/ s/ot at least 1/to at least 1/ In this example: +postgres=# SELECT * FROM pg

[COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Robert Haas
Documentation for logical decoding. Craig Ringer, Andres Freund, Christian Kruse, with edits by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/49c0864d7ef5227faa24f903902db90e5c9d5d69 Modified Files -- doc/src/sgml/catalogs.sgml | 27 +-