Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Tom Lane
Peter Eisentraut writes: > On 1/17/17 2:35 PM, Tom Lane wrote: >> BTW, now that I've looked through this patch ... why does it add >> >> +#include "nodes/nodes.h" >> +#include "nodes/pg_list.h" >> >> to utils/builtins.h? > There are things in builtins.h that technically need those declarations.

Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Peter Eisentraut
On 1/17/17 2:35 PM, Tom Lane wrote: > Peter Eisentraut writes: >> Generate fmgr prototypes automatically > > BTW, now that I've looked through this patch ... why does it add > > +#include "nodes/nodes.h" > +#include "nodes/pg_list.h" > > to utils/builtins.h? AFAICS that shouldn't be necessary,

Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Tom Lane
Peter Eisentraut writes: > Generate fmgr prototypes automatically BTW, now that I've looked through this patch ... why does it add +#include "nodes/nodes.h" +#include "nodes/pg_list.h" to utils/builtins.h? AFAICS that shouldn't be necessary, since there are no declarations in builtins.h that w

Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Tom Lane
Peter Eisentraut writes: > Generate fmgr prototypes automatically Buildfarm's quite unhappy with this. Did you check parallel make? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

[COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Peter Eisentraut
Generate fmgr prototypes automatically Gen_fmgrtab.pl creates a new file fmgrprotos.h, which contains prototypes for all functions registered in pg_proc.h. This avoids having to manually maintain these prototypes across a random variety of header files. It also automatically enforces a correct f