Re: [COMMITTERS] pgsql: Improve gist XLOG code to follow the coding

2006-04-03 Thread Teodor Sigaev
Tom Lane wrote: Hmm. That probably needs to be redesigned then. Don't understand. Root will be fully regenerated and filled with invalid tuples. Well, ISTM that if complete replay of the WAL sequence yields an invalid index, then you've not got an adequate design for the WAL data. Specia

Re: [COMMITTERS] pgsql: Improve gist XLOG code to follow the coding

2006-04-03 Thread Tom Lane
>> Hmm. That probably needs to be redesigned then. > Don't understand. Root will be fully regenerated and filled with invalid > tuples. Well, ISTM that if complete replay of the WAL sequence yields an invalid index, then you've not got an adequate design for the WAL data. Special recovery acti

Re: [COMMITTERS] pgsql: Improve gist XLOG code to follow the coding

2006-04-03 Thread Teodor Sigaev
At line 543 itup vector was filled by invalid tuple, so newly filled root will contains only invalid tuples. Hence, reindex/vacuum full is required. Hmm. That probably needs to be redesigned then. The problem is that as the thing is written, you *must* reinit the buffer here --- the code

Re: [COMMITTERS] pgsql: Improve gist XLOG code to follow the coding

2006-03-31 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: > Here I am. Oleg now is in expedition to solar eclipse (should return soon). Cool ... I hope to see one someday ... > * gistxlog.c:gistContinueInsert > /* > * XXX fall out to avoid making LOG message at bottom of routine. > * I

Re: [COMMITTERS] pgsql: Improve gist XLOG code to follow the coding

2006-03-31 Thread Teodor Sigaev
--- Improve gist XLOG code to follow the coding rules needed to prevent torn-page problems. This introduces some issues of its own, mainly that there are now some critical sections of unreasonably broad scope, but it's a step forward anyway. Further cleanup will require some code refacto

[COMMITTERS] pgsql: Improve gist XLOG code to follow the coding rules needed to

2006-03-30 Thread Tom Lane
Log Message: --- Improve gist XLOG code to follow the coding rules needed to prevent torn-page problems. This introduces some issues of its own, mainly that there are now some critical sections of unreasonably broad scope, but it's a step forward anyway. Further cleanup will require some