[COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
Log Message: --- Make CheckRequiredParameterValues() depend upon correct combination of parameters. Fix bug report by Robert Haas that error message and hint was incorrect if wrong mode parameters specified on master. Internal changes only. Proposals for parameter simplification on

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Tom Lane
sri...@postgresql.org (Simon Riggs) writes: Log Message: --- Make CheckRequiredParameterValues() depend upon correct combination of parameters. Fix bug report by Robert Haas that error message and hint was incorrect if wrong mode parameters specified on master. Internal changes only.

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Robert Haas
On Fri, Apr 23, 2010 at 3:57 PM, Simon Riggs sri...@postgresql.org wrote: Log Message: --- Make CheckRequiredParameterValues() depend upon correct combination of parameters. Fix bug report by Robert Haas that error message and hint was incorrect if wrong mode parameters specified on

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
On Fri, 2010-04-23 at 16:04 -0400, Tom Lane wrote: sri...@postgresql.org (Simon Riggs) writes: Log Message: --- Make CheckRequiredParameterValues() depend upon correct combination of parameters. Fix bug report by Robert Haas that error message and hint was incorrect if wrong

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
On Fri, 2010-04-23 at 16:05 -0400, Robert Haas wrote: On Fri, Apr 23, 2010 at 3:57 PM, Simon Riggs sri...@postgresql.org wrote: Log Message: --- Make CheckRequiredParameterValues() depend upon correct combination of parameters. Fix bug report by Robert Haas that error message and

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: No intention of doing that. This change allows people to see what the dependency actually is once the bug has been fixed. Change needs to start from here, not from where we were before. Well, actually, now that I've looked at the patch I think it's

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Robert Haas
On Fri, Apr 23, 2010 at 4:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: No intention of doing that. This change allows people to see what the dependency actually is once the bug has been fixed. Change needs to start from here, not from where we were

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
On Fri, 2010-04-23 at 16:44 -0400, Tom Lane wrote: There's no connection at all between what the GUC state was at shutdown and what it might be after starting again. A design that might work is (1) store the active value of wal_mode in pg_control (but NOT as part of the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Apr 23, 2010 at 4:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: A design that might work is (1) store the active value of wal_mode in pg_control (but NOT as part of the last-checkpoint-record image). (2) invent a new WAL record type that is