Re: [COMMITTERS] pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().

2010-08-25 Thread Tom Lane
Robert Haas writes: > On Wed, Aug 25, 2010 at 11:46 AM, Simon Riggs wrote: >> I have a horrible nagging feeling this breaks something. > Well, the only place it's used at the moment is in the drop-object > code. Not sure if that might be enough to jog your memory? Also, it's pretty hard to see

Re: [COMMITTERS] pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().

2010-08-25 Thread Robert Haas
On Wed, Aug 25, 2010 at 11:46 AM, Simon Riggs wrote: > On Mon, 2010-08-16 at 02:02 +, Robert Haas wrote: >> Log Message: >> --- >> Make LockDatabaseObject() AcceptInvalidationMessages(). >> >> This is appropriate for the same reasons we already do it in >> LockSharedObject(): things mi

Re: [COMMITTERS] pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().

2010-08-25 Thread Simon Riggs
On Mon, 2010-08-16 at 02:02 +, Robert Haas wrote: > Log Message: > --- > Make LockDatabaseObject() AcceptInvalidationMessages(). > > This is appropriate for the same reasons we already do it in > LockSharedObject(): things might have changed while we were waiting > for the lock. There

[COMMITTERS] pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().

2010-08-15 Thread Robert Haas
Log Message: --- Make LockDatabaseObject() AcceptInvalidationMessages(). This is appropriate for the same reasons we already do it in LockSharedObject(): things might have changed while we were waiting for the lock. There doesn't seem to be a live bug here at the moment, but that's mostly