Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-27 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 11/20/2010 07:10 AM, Robert Haas wrote: > > Ah, the joy of debugging by buildfarm. Nothing better than having the > > whole world watch your mistakes in painstaking detail! > > At least this way you get to do it while your memory is fresh. In the > old days we

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-27 Thread Bruce Momjian
Robert Haas wrote: > On Sat, Nov 20, 2010 at 5:23 AM, Andrew Dunstan wrote: > >> Ugh. ?I made an attempt at a fix to both of these issues, but I'm not > >> totally sure I got it right, and I'm too tired to stay up any later to > >> see what happens. ?I'll check the BF in the morning. > > > > If yo

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Andrew Dunstan
On 11/20/2010 07:10 AM, Robert Haas wrote: Ah, the joy of debugging by buildfarm. Nothing better than having the whole world watch your mistakes in painstaking detail! At least this way you get to do it while your memory is fresh. In the old days we only found out some things were broken

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Robert Haas
On Sat, Nov 20, 2010 at 5:23 AM, Andrew Dunstan wrote: >> Ugh.  I made an attempt at a fix to both of these issues, but I'm not >> totally sure I got it right, and I'm too tired to stay up any later to >> see what happens.  I'll check the BF in the morning. > > If you change a test that has altern

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Andrew Dunstan
On 11/20/2010 01:10 AM, Robert Haas wrote: On Fri, Nov 19, 2010 at 11:47 PM, Tom Lane wrote: I wrote: Robert Haas writes: Speed up conversion of signed integers to C strings. This patch breaks the build here: ... and while I'm looking at it, the added int8 regression test cases definitel

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-19 Thread Robert Haas
On Fri, Nov 19, 2010 at 11:47 PM, Tom Lane wrote: > I wrote: >> Robert Haas writes: >>> Speed up conversion of signed integers to C strings. > >> This patch breaks the build here: > > ... and while I'm looking at it, the added int8 regression test cases > definitely merit a WTF.  They aren't test

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-19 Thread Tom Lane
I wrote: > Robert Haas writes: >> Speed up conversion of signed integers to C strings. > This patch breaks the build here: ... and while I'm looking at it, the added int8 regression test cases definitely merit a WTF. They aren't testing what I would expect. What they are testing is platform-spe

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-19 Thread Tom Lane
Robert Haas writes: > Speed up conversion of signed integers to C strings. This patch breaks the build here: gcc -O1 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing -g -I../../../../src/include -D_XOPEN_SOURCE_EXTENDED -c -o numutils.o numutils.c numutils.c: In function `pg_lt

[COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-19 Thread Robert Haas
Speed up conversion of signed integers to C strings. A hand-coded implementation turns out to be much faster than calling printf(). In passing, add a few more regresion tests. Andres Freund, with assorted, mostly cosmetic changes. Branch -- master Details --- http://git.postgresql.org/