Re: [COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Heikki Linnakangas
On 12/30/2014 07:21 PM, Alvaro Herrera wrote: Heikki Linnakangas wrote: There is one instance of the old message left in pg_get_object_address. Should change that too for consistency, and to reduce translation work. Hm, I couldn't find it ... care to provide a line number? Never mind, I must

Re: [COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Alvaro Herrera
Heikki Linnakangas wrote: > On 12/30/2014 06:58 PM, Alvaro Herrera wrote: > >-errmsg("name list length must be %d", 1))); > >+errmsg("name list length must be exactly %d", 1))); > > Seems silly to pass constant 1 as an argument. (Yeah, it was silly b

Re: [COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Heikki Linnakangas
On 12/30/2014 06:58 PM, Alvaro Herrera wrote: -errmsg("name list length must be %d", 1))); +errmsg("name list length must be exactly %d", 1))); Seems silly to pass constant 1 as an argument. (Yeah, it was silly before this commit too.) There is

[COMMITTERS] pgsql: Use TypeName to represent type names in certain commands

2014-12-30 Thread Alvaro Herrera
Use TypeName to represent type names in certain commands In COMMENT, DROP, SECURITY LABEL, and the new pg_get_object_address function, we were representing types as a list of names, same as other objects; but types are special objects that require their own representation to be totally accurate.