Re: [COMMITTERS] pgsql: Use standard interrupt handling in logical replication launcher.

2017-06-09 Thread Tom Lane
Andres Freund writes: > On 2017-06-09 17:47:23 -0400, Tom Lane wrote: >> On the less good side, something seems to have broken the pg_upgrade >> tests recently on skink and some (not all) of the CLOBBER_CACHE_ALWAYS >> animals. > Yea, I saw skinks failure. Unfortunately it seems we're either not

Re: [COMMITTERS] pgsql: Use standard interrupt handling in logical replication launcher.

2017-06-09 Thread Andres Freund
On 2017-06-09 17:47:23 -0400, Tom Lane wrote: > Andres Freund writes: > > Use standard interrupt handling in logical replication launcher. > > This seems to have fixed nightjar's subscription-test failures. > Were you expecting that? Well, hoping ;). Petr had pointed it out as the probable sour

Re: [COMMITTERS] pgsql: Use standard interrupt handling in logical replication launcher.

2017-06-09 Thread Tom Lane
Andres Freund writes: > Use standard interrupt handling in logical replication launcher. This seems to have fixed nightjar's subscription-test failures. Were you expecting that? On the less good side, something seems to have broken the pg_upgrade tests recently on skink and some (not all) of the

[COMMITTERS] pgsql: Use standard interrupt handling in logical replication launcher.

2017-06-08 Thread Andres Freund
Use standard interrupt handling in logical replication launcher. Previously the exit handling was only able to exit from within the main loop, and not from within the backend code it calls. Fix that by using the standard die() SIGTERM handler, and adding the necessary CHECK_FOR_INTERRUPTS() call.