Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I thought about that but I figured the less we change the tz library, > > the easier it will be to replace later. > > I have come to the conclusion that trying to minimize changes to the tz > library is a bad tradeoff. It's not going

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I thought about that but I figured the less we change the tz library, > the easier it will be to replace later. I have come to the conclusion that trying to minimize changes to the tz library is a bad tradeoff. It's not going to be a minimally sized dif

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h: > > > #ifndef HAVE_SYMLINK > > #define HAVE_SYMLINK 0 > > #endif > > Surely this is exactly the wrong thing to do. It will break code that > test

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h: > #ifndef HAVE_SYMLINK > #define HAVE_SYMLINK 0 > #endif Surely this is exactly the wrong thing to do. It will break code that tests for #ifdef HAVE_SYMLIN

[COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 13:58:48 Modified files: src/timezone : pgtz.h Log message: Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h: #ifndef HAVE_SYMLINK #def