Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Gavin Sherry wrote: > Here is a change to the alter_table regression test to use ALTER INDEX ... > RENAME instead of ALTER TABLE ... RENAME in the case of an index renaming. > Its probably not th

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-25 Thread Robert Treat
Shouldn't the regression tests reflect that? Robert Treat On Tue, 2004-08-24 at 22:31, Gavin Sherry wrote: > Yes > > On Tue, 24 Aug 2004, Robert Treat wrote: > > > I think I missed this in the earlier patches, but does the alter table syntax > > still work for indexes in addition to the new syn

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-24 Thread Gavin Sherry
Yes On Tue, 24 Aug 2004, Robert Treat wrote: > I think I missed this in the earlier patches, but does the alter table syntax > still work for indexes in addition to the new syntax? > > On Saturday 21 August 2004 22:47, Gavin Sherry wrote: > > Here is a change to the alter_table regression test to

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-24 Thread Robert Treat
I think I missed this in the earlier patches, but does the alter table syntax still work for indexes in addition to the new syntax? On Saturday 21 August 2004 22:47, Gavin Sherry wrote: > Here is a change to the alter_table regression test to use ALTER INDEX ... > RENAME instead of ALTER TABLE .

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Christopher Kings-Lynne
I have a whole separate CVS checkout for every path I'm working on - makes life a lot easier :) Dammit - I meant 'patch'. Chris ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Christopher Kings-Lynne
Thanks for spotting this sloppy work. Basically, I cropped my diff because there was lots of unrelated code in the work space. But I was a little too hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c and analyze.c. I was wondering if something like that might have happened --- I know you k

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Gavin Sherry
Here is a change to the alter_table regression test to use ALTER INDEX ... RENAME instead of ALTER TABLE ... RENAME in the case of an index renaming. Its probably not the right place for it, but I'm not sure where is the right place for it. Thanks, Gavin On Sat, 21 Aug 2004, Tom Lane wrote: > G

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.

2004-08-21 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > Thanks for spotting this sloppy work. Basically, I cropped my diff because > there was lots of unrelated code in the work space. But I was a little too > hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c and analyze.c. I was wondering if something

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Gavin Sherry
Umm... oops. On Sat, 21 Aug 2004, Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Add ALTER INDEX, particularly for moving tablespaces. > > This patch is a perfect example of why unreviewed patches should not > go in during beta. > > So far I have noticed the following problems wi

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for moving

2004-08-21 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > Considering point 3 seems a wee bit critical, at least to me, should the > patch be removed and postponed for a non-Beta period? No, the fixes are all trivial. I'm just chewing out Bruce and Gavin for sloppiness ;-) regard

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Marc G. Fournier
On Sat, 21 Aug 2004, Bruce Momjian wrote: Tom Lane wrote: [EMAIL PROTECTED] (Bruce Momjian) writes: Add ALTER INDEX, particularly for moving tablespaces. This patch is a perfect example of why unreviewed patches should not go in during beta. So far I have noticed the following problems with it: * A

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for moving

2004-08-21 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Add ALTER INDEX, particularly for moving tablespaces. > > This patch is a perfect example of why unreviewed patches should not > go in during beta. > > So far I have noticed the following problems with it: > > * Added reference page

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.

2004-08-21 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Add ALTER INDEX, particularly for moving tablespaces. This patch is a perfect example of why unreviewed patches should not go in during beta. So far I have noticed the following problems with it: * Added reference page wasn't linked into the docs build

[COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.

2004-08-19 Thread Bruce Momjian
Log Message: --- Add ALTER INDEX, particularly for moving tablespaces. Gavin Sherry Modified Files: -- pgsql-server/src/backend/parser: gram.y (r2.471 -> r2.472) (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/parser/gram.y.diff?r1=2.4