Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

2016-05-11 Thread Tom Lane
Alvaro Herrera writes: > Peter Geoghegan wrote: >> What does this mean? >> >> + /* XXX broken */ >> if (attno < 0) >> elog(ERROR, "system column in index"); > My guess is that it means we do support indexes in system columns (oid > in particular) and that instead of an ugly error this

Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

2016-05-11 Thread Peter Geoghegan
On Wed, May 11, 2016 at 1:54 PM, Alvaro Herrera wrote: > My guess is that it means we do support indexes in system columns (oid > in particular) and that instead of an ugly error this should do > something else. Maybe silently ignore the index. Why ignore the index? Either they're not supported,

Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

2016-05-11 Thread Alvaro Herrera
Peter Geoghegan wrote: > On Wed, May 11, 2016 at 1:20 PM, Tom Lane wrote: > > Fix assorted missing infrastructure for ON CONFLICT. > > What does this mean? > > + /* XXX broken */ > if (attno < 0) > elog(ERROR, "system column in index"); My guess is that it

Re: [COMMITTERS] pgsql: Fix assorted missing infrastructure for ON CONFLICT.

2016-05-11 Thread Peter Geoghegan
On Wed, May 11, 2016 at 1:20 PM, Tom Lane wrote: > Fix assorted missing infrastructure for ON CONFLICT. What does this mean? + /* XXX broken */ if (attno < 0) elog(ERROR, "system column in index"); -- Peter Geoghegan -- Sent via pgsql-committers mailing